From aecc85fe8fad1036236c437717333bf16c2086e7 Mon Sep 17 00:00:00 2001 From: Elly <ellyjones@chromium.org> Date: Wed, 20 Sep 2023 19:34:00 +0000 Subject: [PATCH] apps: remove redundant NonClientFrameView overrides The base class has empty bodies for these, so child classes don't need to do this. Bug: None Change-Id: I27702728d5f58206c724a5d3333c02634a478f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878563 Auto-Submit: Elly FJ <ellyjones@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1199172} --- apps/ui/views/app_window_frame_view.cc | 5 ----- apps/ui/views/app_window_frame_view.h | 4 ---- 2 files changed, 9 deletions(-) diff --git a/apps/ui/views/app_window_frame_view.cc b/apps/ui/views/app_window_frame_view.cc index 2dd2083dc2b89..f689a892bb833 100644 --- a/apps/ui/views/app_window_frame_view.cc +++ b/apps/ui/views/app_window_frame_view.cc @@ -221,11 +221,6 @@ int AppWindowFrameView::NonClientHitTest(const gfx::Point& point) { return HTCAPTION; } -void AppWindowFrameView::GetWindowMask(const gfx::Size& size, - SkPath* window_mask) { - // We got nothing to say about no window mask. -} - void AppWindowFrameView::SizeConstraintsChanged() { if (draw_frame_) { maximize_button_->SetEnabled(widget_->widget_delegate() && diff --git a/apps/ui/views/app_window_frame_view.h b/apps/ui/views/app_window_frame_view.h index 915a0fb059aac..fc52bf97811e9 100644 --- a/apps/ui/views/app_window_frame_view.h +++ b/apps/ui/views/app_window_frame_view.h @@ -64,10 +64,6 @@ class AppWindowFrameView : public views::NonClientFrameView { gfx::Rect GetWindowBoundsForClientBounds( const gfx::Rect& client_bounds) const override; int NonClientHitTest(const gfx::Point& point) override; - void GetWindowMask(const gfx::Size& size, SkPath* window_mask) override; - void ResetWindowControls() override {} - void UpdateWindowIcon() override {} - void UpdateWindowTitle() override {} void SizeConstraintsChanged() override; // views::View implementation.