chromium/src
0
Fork 0
Code Activity

Use the right wording in DCHECK_IS_ON() presubmit check.

Browse Source 
It was added in https://codereview.chromium.org/1407033004/ but
used the word braces for the parentheses.

NOTRY=True

Review-Url: https://codereview.chromium.org/2705303004
Cr-Commit-Position: refs/heads/master@{#452163}
This commit is contained in:
kjellander
2017-02-22 11:26:57 -08:00
committed by Commit bot
parent af9b038a6b
commit aee30663ac
1 changed files with 2 additions and 2 deletions

4
PRESUBMIT.py

@@ -431,7 +431,7 @@ def _CheckNoUNIT_TESTInSourceFiles(input_api, output_api):
def _CheckDCHECK_IS_ONHasBraces(input_api, output_api): def _CheckDCHECK_IS_ONHasBraces(input_api, output_api):
"""Checks to make sure DCHECK_IS_ON() does not skip the braces.""" """Checks to make sure DCHECK_IS_ON() does not skip the parentheses."""
errors = [] errors = []
pattern = input_api.re.compile(r'DCHECK_IS_ON(?!\(\))', pattern = input_api.re.compile(r'DCHECK_IS_ON(?!\(\))',
input_api.re.MULTILINE) input_api.re.MULTILINE)
@@ -442,7 +442,7 @@ def _CheckDCHECK_IS_ONHasBraces(input_api, output_api):
if input_api.re.search(pattern, line): if input_api.re.search(pattern, line):
errors.append(output_api.PresubmitError( errors.append(output_api.PresubmitError(
('%s:%d: Use of DCHECK_IS_ON() must be written as "#if ' + ('%s:%d: Use of DCHECK_IS_ON() must be written as "#if ' +
'DCHECK_IS_ON()", not forgetting the braces.') 'DCHECK_IS_ON()", not forgetting the parentheses.')
% (f.LocalPath(), lnum))) % (f.LocalPath(), lnum)))
return errors return errors