0

WebUI: Remove leftovers of long removed a11y axs_testing.js tests.

Bug: 807458
Change-Id: Iee6a15dde67eff2591276198cda2e0762b402bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489985
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975703}
This commit is contained in:
dpapad
2022-02-28 09:57:27 +00:00
committed by Chromium LUCI CQ
parent 1fd5fd3aea
commit b2e6580b84
19 changed files with 2 additions and 99 deletions
ash/webui
chrome
docs/testing
ui/accessibility/extensions/chromevoxclassic/testing

@@ -21,11 +21,6 @@ var ColorInternalsUIBrowserTest = class extends testing.Test {
return HOST_ORIGIN; return HOST_ORIGIN;
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get isAsync() { get isAsync() {
return true; return true;

@@ -15,11 +15,6 @@ var DemoModeAppUIBrowserTest = class extends testing.Test {
return HOST_ORIGIN; return HOST_ORIGIN;
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get featureList() { get featureList() {
return {enabled: ['ash::features::kDemoModeSWA']}; return {enabled: ['ash::features::kDemoModeSWA']};

@@ -20,11 +20,6 @@ var EcheAppUIBrowserTest = class extends testing.Test {
return HOST_ORIGIN; return HOST_ORIGIN;
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get featureList() { get featureList() {
return { return {

@@ -43,11 +43,6 @@ var HelpAppUIGtestBrowserTest = class extends testing.Test {
get typedefCppFixture() { get typedefCppFixture() {
return 'HelpAppUiBrowserTest'; return 'HelpAppUiBrowserTest';
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
}; };
// js2gtest fixtures require var here (https://crbug.com/1033337). // js2gtest fixtures require var here (https://crbug.com/1033337).

@@ -35,11 +35,6 @@ var MediaAppUIGtestBrowserTest = class extends testing.Test {
return {enabled: ['blink::features::kFileHandlingAPI']}; return {enabled: ['blink::features::kFileHandlingAPI']};
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get typedefCppFixture() { get typedefCppFixture() {
return 'MediaAppUiBrowserTest'; return 'MediaAppUiBrowserTest';

@@ -37,11 +37,6 @@ class PersonalizationAppBrowserTest extends testing.Test {
return true; return true;
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get typedefCppFixture() { get typedefCppFixture() {
return 'PersonalizationAppBrowserTestFixture'; return 'PersonalizationAppBrowserTestFixture';

@@ -21,11 +21,6 @@ var SampleSystemWebAppUIBrowserTest = class extends testing.Test {
return HOST_ORIGIN; return HOST_ORIGIN;
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get isAsync() { get isAsync() {
return true; return true;

@@ -50,11 +50,6 @@ var MessagePipeBrowserTest = class extends testing.Test {
return 'chrome://system-app-test/test_data/message_pipe_browsertest_trusted.html'; return 'chrome://system-app-test/test_data/message_pipe_browsertest_trusted.html';
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get typedefCppFixture() { get typedefCppFixture() {
return 'JsLibraryTest'; return 'JsLibraryTest';

@@ -30,11 +30,6 @@ var SystemExtensionsInternalsUIBrowserTest = class extends testing.Test {
}; };
} }
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */ /** @override */
get isAsync() { get isAsync() {
return true; return true;

@@ -30,7 +30,6 @@ const testing = {
get extraLibraries() {} get extraLibraries() {}
get isAsync() {} get isAsync() {}
get featureList() {} get featureList() {}
get runAccessibilityChecks() {}
get typedefCppFixture() {} get typedefCppFixture() {}
setUp() {} setUp() {}
} }

@@ -119,12 +119,5 @@ ChromeVoxWebUITestBase = class extends testing.Test {
/** @override */ /** @override */
ChromeVoxWebUITestBase.prototype.isAsync = false; ChromeVoxWebUITestBase.prototype.isAsync = false;
/**
* @override
* It doesn't make sense to run the accessibility audit on these tests,
* since many of them are deliberately testing inaccessible html.
*/
ChromeVoxWebUITestBase.prototype.runAccessibilityChecks = false;
/** @override */ /** @override */
ChromeVoxWebUITestBase.prototype.browsePreload = DUMMY_URL; ChromeVoxWebUITestBase.prototype.browsePreload = DUMMY_URL;

@@ -325,8 +325,3 @@ E2ETestBase = class extends testing.Test {
/** @override */ /** @override */
E2ETestBase.prototype.isAsync = true; E2ETestBase.prototype.isAsync = true;
/**
* @override
* No UI in the background context.
*/
E2ETestBase.prototype.runAccessibilityChecks = false;

@@ -26,11 +26,6 @@ PasswordChangeAuthenticatorUnitTest = class extends testing.Test {
return DUMMY_URL; return DUMMY_URL;
} }
// No need to run these checks - see comment in SamlPasswordAttributesTest.
get runAccessibilityChecks() {
return false;
}
get extraLibraries() { get extraLibraries() {
return [ return [
'//ui/webui/resources/js/cr/event_target.js', '//ui/webui/resources/js/cr/event_target.js',

@@ -13,12 +13,6 @@ function SamlPasswordAttributesUnitTest() {}
SamlPasswordAttributesUnitTest.prototype = { SamlPasswordAttributesUnitTest.prototype = {
__proto__: testing.Test.prototype, __proto__: testing.Test.prototype,
// WebUI tests run accessibility checks by default, but unit tests don't.
// Ideally this would be a unit test, but unit tests can't use the DOMParser.
// WebUI tests can, so this is a WebUI test. But, this test has no UI to run
// accessibility checks on, so we turn this off manually.
runAccessibilityChecks: false,
/** @override */ /** @override */
testGenCppIncludes() { testGenCppIncludes() {
GEN(`#include "base/files/file_util.h"`); GEN(`#include "base/files/file_util.h"`);

@@ -14,9 +14,6 @@ SamlTimestampsUnitTest.prototype = {
browsePreload: DUMMY_URL, browsePreload: DUMMY_URL,
// No need to run these checks - see comment in SamlPasswordAttributesTest.
runAccessibilityChecks: false,
/** @override */ /** @override */
testGenCppIncludes() { testGenCppIncludes() {
GEN(`#include "content/public/test/browser_test.h"`); GEN(`#include "content/public/test/browser_test.h"`);

@@ -22,12 +22,6 @@ SyncInternalsWebUITest.prototype = {
*/ */
browsePreload: 'chrome://sync-internals', browsePreload: 'chrome://sync-internals',
/**
* Disable accessibility testing for this page.
* @override
*/
runAccessibilityChecks: false,
/** /**
* Checks aboutInfo's details section for the specified field. * Checks aboutInfo's details section for the specified field.
* @param {boolean} isValid Whether the field is valid. * @param {boolean} isValid Whether the field is valid.

@@ -25,12 +25,6 @@ OobeWebUITest.prototype = {
/** @override */ /** @override */
browsePreload: 'chrome://oobe/oobe', browsePreload: 'chrome://oobe/oobe',
/** @override */
runAccessibilityChecks: true,
/** @override */
accessibilityIssuesAreErrors: true,
/** @override */ /** @override */
testGenPreamble: function() { testGenPreamble: function() {
// OobeWebUI should run in fullscreen. // OobeWebUI should run in fullscreen.

@@ -162,12 +162,6 @@ AwesomeUnitTest = class extends testing.Test {
get browsePreload() { get browsePreload() {
return DUMMY_URL; return DUMMY_URL;
} }
// No need to run these checks unless you are testing an actual user interface.
/** @override */
get runAccessibilityChecks() {
return false;
}
} }
``` ```

@@ -51,13 +51,6 @@ ChromeVoxUnitTestBase.prototype = {
/** @override */ /** @override */
browsePreload: DUMMY_URL, browsePreload: DUMMY_URL,
/**
* @override
* It doesn't make sense to run the accessibility audit on these tests,
* since many of them are deliberately testing inaccessible html.
*/
runAccessibilityChecks: false,
/** /**
* Loads some inlined html into the body of the current document, replacing * Loads some inlined html into the body of the current document, replacing
* whatever was there previously. * whatever was there previously.