Spanify //codelabs.

Remove the //codelabs directory from the exclusion list. Use
base::CommandLine to solve argv bound checking problems.

Bug: 40284755
Change-Id: I20021cba9039d436f798e60dd4db223d94b35b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806657
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354073}

build/config/unsafe_buffers_paths.txt

@@ -83,7 +83,6 @@
 -chromeos/ash/services/libassistant/
 -chromeos/components/kcer/kcer_nss
 -clank/
--codelabs/
 -components/allocation_recorder/
 -components/chromeos_camera
 -components/commerce/
@@ -146,3 +145,9 @@
 # Removing this directory may fail on the bot CI bot:
 # https://luci-milo.appspot.com/ui/p/chrome/builders/official/win-arm64-clang
 -chrome/installer/
+
+# //codelabs is a directory that contains examples for developers to modify as
+# they learn about chromium development. This is indefinitely opt-out because
+# it is not part of the main build, and we don't want developers to be blocked
+# by this check.
+-codelabs/

codelabs/cpp101/solutions/factor.cc

@@ -54,7 +54,7 @@ int main(int argc, char* argv[]) {
   base::test::TaskEnvironment task_environment{
       base::test::TaskEnvironment::TimeSource::SYSTEM_TIME};
 
-  if (argc <= 1) {
+  if (argc < 2) {
     LOG(INFO) << argv[0] << ": missing operand\n";
     return -1;
   }

codelabs/cpp101/solutions/fibonacci.cc

@@ -33,7 +33,7 @@ base::RepeatingCallback<int()> MakeFibonacciClosure() {
 }  // namespace
 
 int main(int argc, char* argv[]) {
-  if (argc <= 1) {
+  if (argc < 2) {
     LOG(INFO) << argv[0] << ": missing operand";
     return -1;
   }
@@ -59,4 +59,4 @@ int main(int argc, char* argv[]) {
   }
 
   return 0;
-}
+}

codelabs/cpp101/solutions/mojo.cc

@@ -24,7 +24,7 @@ int main(int argc, char* argv[]) {
       base::test::TaskEnvironment::TimeSource::SYSTEM_TIME};
   mojo::core::Init();
 
-  if (argc <= 2) {
+  if (argc < 3) {
     LOG(INFO) << argv[0] << ": missing operand";
     return -1;
   }

codelabs/cpp101/solutions/sleep.cc

@@ -20,7 +20,7 @@ int main(int argc, char* argv[]) {
   base::test::TaskEnvironment task_environment{
       base::test::TaskEnvironment::TimeSource::SYSTEM_TIME};
 
-  if (argc <= 1) {
+  if (argc < 2) {
     LOG(INFO) << argv[0] << ": missing operand";
     return -1;
   }