0

Update Chromium code review docs to reflect 2P review policy

R=jsca@google.com

Change-Id: Ic9b52969fb28cd87c6b0ae0fd2899a8977a5890e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954782
Reviewed-by: Joey Scarr <jsca@google.com>
Commit-Queue: Ramzi Nasnas <rnasnas@google.com>
Cr-Commit-Position: refs/heads/main@{#1218573}
This commit is contained in:
Ramzi N
2023-11-02 00:47:53 +00:00
committed by Chromium LUCI CQ
parent 05dcd13bd0
commit be25013d55
2 changed files with 26 additions and 12 deletions

@@ -10,15 +10,19 @@ and OWNERS policy changes launched on March 24, 2021, see
# Code review policies # Code review policies
Ideally the reviewer is someone who is familiar with the area of code you are Any [committer](https://www.chromium.org/getting-involved/become-a-committer/#what-is-a-committer) can review code, but
touching. Any committer can review code, but an owner must provide a review an owner must provide a review for each directory you are touching. Ideally you should choose
for each directory you are touching. If you have doubts, look at the `git blame` reviewers who are familiar with the area of code you are touching. If you have doubts, look
for the file and the `OWNERS` files ([more info](#owners-files)). at the `git blame` for the file and the `OWNERS` files ([more info](#owners-files)).
To indicate a positive review, the reviewer provides a `Code-Review +1` in To indicate a positive review, the reviewer provides a `Code-Review +1` in
Gerrit, also known as an LGTM ("Looks Good To Me"). A score of "-1" indicates Gerrit, also known as an LGTM ("Looks Good To Me"). A score of "-1" indicates
the change should not be submitted as-is. the change should not be submitted as-is.
Submissions to the chromium/src repository by a change contributor who is not a Chromium
committer require two committers to Code-Review+1 the submission. If the owner of the CL
is already a committer, then only one other committer is needed to review.
If you have multiple reviewers, provide a message indicating what you expect If you have multiple reviewers, provide a message indicating what you expect
from each reviewer. Otherwise people might assume their input is not required from each reviewer. Otherwise people might assume their input is not required
or waste time with redundant reviews. or waste time with redundant reviews.

@@ -233,15 +233,20 @@ policies][code-reviews] page.
### Finding a reviewer ### Finding a reviewer
Ideally, the reviewer is someone who is familiar with the area of code in Please note here that a "reviewer" in this context is someone that not
question. If you're not sure who that should be, check with anyone in the only provides comment on the CL but also someone who can approve the
nearest ancestor OWNERS file. submission by providing a CR+1.
- Anybody can review code, but there must be at least one owner for each Reviewers must be [committers](https://www.chromium.org/getting-involved/become-a-committer/).
affected directory. Ideally they should be committers who are familiar with the area of code
- If there are multiple reviewers, make it clear what each reviewer is expected in question. If you're not sure who these should be, check with anyone in
to review. the nearest ancestor OWNERS file.
- `git cl owners` automatically suggests reviewers based on the OWNERS files.
- There must be at least one owner for each affected directory.
- If there are multiple reviewers, make it clear what each reviewer is
expected to review.
- `git cl owners` automatically suggests reviewers based on the OWNERS
files.
_Note:_ By default, please only select one reviewer for each file (that is, a _Note:_ By default, please only select one reviewer for each file (that is, a
single reviewer may review multiple files, but typically each file only needs single reviewer may review multiple files, but typically each file only needs
@@ -257,6 +262,11 @@ desirable - such as when the code is particularly complicated, or when the file
uses multiple systems and a perspective from each is valuable. In this case, uses multiple systems and a perspective from each is valuable. In this case,
please make it explicit that you would like both reviewers to review. please make it explicit that you would like both reviewers to review.
Submissions to the chromium/src repository by a change contributor who is
not a Chromium committer will require two committers to Code-Review+1 the
submissions. If the owner of the CL is already a committer, then only one
other committer is needed to Code-Review+1.
### Requesting review ### Requesting review
Open the change on [the web][crrev]. If you can't find the link, running `git Open the change on [the web][crrev]. If you can't find the link, running `git