chromium/src
0
Fork 0
Code Activity

win: Enable -Wexit-time-destructors for content/.

Browse Source 
After this, for all targets where the warning is enabled on non-Win, it's now
enabled on Windows too.

Bug: 404525
Change-Id: I2518fe482e04ba3c4b9964c49ee3fc3c4217d170
Reviewed-on: https://chromium-review.googlesource.com/1231838
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592230}
This commit is contained in:
Nico Weber
2018-09-18 22:32:21 +00:00
committed by Commit Bot
parent e2ce2f84ea
commit c0356ab9dc
1 changed files with 4 additions and 5 deletions

9
content/BUILD.gn

@@ -9,11 +9,10 @@ import("//ppapi/buildflags/buildflags.gni")
# Applied by targets internal to content. # Applied by targets internal to content.
config("content_implementation") { config("content_implementation") {
defines = [ "CONTENT_IMPLEMENTATION" ] defines = [ "CONTENT_IMPLEMENTATION" ]
configs = [ "//build/config/compiler:noshadowing" ] configs = [
if (!is_win) { "//build/config/compiler:noshadowing",
# TODO(thakis): Enable on Windows too, http://crbug.com/404525 "//build/config/compiler:wexit_time_destructors",
configs += [ "//build/config/compiler:wexit_time_destructors" ] ]
}
} }
# When targets depend on, e.g. //content/public/browser, what happens? To # When targets depend on, e.g. //content/public/browser, what happens? To