chromium/src
0
Fork 0
Code Activity

Fixes screen saver preview aria labels

Browse Source 
- Label for preview button: Screen saver preview.
- Label for downloading button: Downloading the screen saver.
- Label when the screen saver starts: Displaying screen saver, press any key to exit

Bug: b:269146683
Bug: b:269150090
Change-Id: I7399398c35aef5705f22bd4bb510a4938357b868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4313069
Reviewed-by: Yuki Awano <yawano@google.com>
Commit-Queue: Ilkin Safarli <safarli@google.com>
Cr-Commit-Position: refs/heads/main@{#1114130}
This commit is contained in:
Ilkin Safarli
2023-03-07 20:10:52 +00:00
committed by Chromium LUCI CQ
parent 4e052e16ba
commit c3a70e3b22
7 changed files with 18 additions and 8 deletions

4
ash/ash_strings.grd

@@ -5175,8 +5175,8 @@ Here are some things you can try to get started.
<message name="IDS_ASH_AMBIENT_MODE_WEATHER_TEMPERATURE_IN_CELSIUS" desc="Text of the weather temperature in Celsius."> <message name="IDS_ASH_AMBIENT_MODE_WEATHER_TEMPERATURE_IN_CELSIUS" desc="Text of the weather temperature in Celsius.">
<ph name="TEMPERATURE_C">$1<ex>25</ex></ph>° C <ph name="TEMPERATURE_C">$1<ex>25</ex></ph>° C
</message> </message>
<message name="IDS_ASH_SCREENSAVER_STARTS" desc="Text to announce when screensaver starts."> <message name="IDS_ASH_SCREENSAVER_STARTS" desc="Text to announce when screensaver starts and how to exit.">
Screen saver starts Displaying screen saver, press any key to exit
</message> </message>
<!-- Capture Mode --> <!-- Capture Mode -->

2
ash/ash_strings_grd/IDS_ASH_SCREENSAVER_STARTS.png.sha1

@@ -1 +1 @@
5ca41d20b705a3aafba488c19f17f74a0496638c 9438e0de9a576722c8523a753881f362aa7a8c97

4
ash/webui/personalization_app/personalization_app_ui.cc

@@ -154,8 +154,12 @@ void AddStrings(content::WebUIDataSource* source) {
{"screensaverLabel", IDS_PERSONALIZATION_APP_SCREENSAVER_LABEL}, {"screensaverLabel", IDS_PERSONALIZATION_APP_SCREENSAVER_LABEL},
{"screenSaverPreviewButton", {"screenSaverPreviewButton",
IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON}, IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON},
{"screenSaverPreviewButtonAriaLabel",
IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON_ARIA_LABEL},
{"screenSaverPreviewDownloading", {"screenSaverPreviewDownloading",
IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING}, IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING},
{"screenSaverPreviewDownloadingAriaLabel",
IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING_ARIA_LABEL},
{"ambientModePageDescription", {"ambientModePageDescription",
IDS_PERSONALIZATION_APP_AMBIENT_MODE_PAGE_DESCRIPTION}, IDS_PERSONALIZATION_APP_AMBIENT_MODE_PAGE_DESCRIPTION},
{"ambientModeOn", IDS_PERSONALIZATION_APP_AMBIENT_MODE_ON}, {"ambientModeOn", IDS_PERSONALIZATION_APP_AMBIENT_MODE_ON},

8
ash/webui/personalization_app/resources/js/ambient/ambient_preview_small_element.ts

@@ -95,11 +95,9 @@ export class AmbientPreviewSmall extends AmbientPreviewBase {
} }
private getScreenSaverPreviewAriaLabel_(): string { private getScreenSaverPreviewAriaLabel_(): string {
if (!this.screenSaverPreviewActive_) { return this.screenSaverPreviewActive_ ?
return `${this.i18n('screensaverLabel')} ${ this.i18n('screenSaverPreviewDownloadingAriaLabel') :
this.i18n('screenSaverPreviewButton')}`; this.i18n('screenSaverPreviewButtonAriaLabel');
}
return this.i18n('screenSaverPreviewDownloading');
} }
} }

6
chromeos/chromeos_strings.grd

@@ -2414,9 +2414,15 @@
<message name="IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON" desc="Label for the button to preview screen saver."> <message name="IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON" desc="Label for the button to preview screen saver.">
Preview Preview
</message> </message>
<message name="IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON_ARIA_LABEL" desc="Aria label for the button to preview screen saver.">
Screen saver preview
</message>
<message name="IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING" desc="Label for the button while screen saver preview is loading."> <message name="IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING" desc="Label for the button while screen saver preview is loading.">
Downloading image Downloading image
</message> </message>
<message name="IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING_ARIA_LABEL" desc="Aria label for the button while screen saver preview is loading.">
Downloading the screen saver
</message>
<message name="IDS_PERSONALIZATION_APP_AMBIENT_MODE_PAGE_DESCRIPTION" desc="Description for the ambient mode settings page."> <message name="IDS_PERSONALIZATION_APP_AMBIENT_MODE_PAGE_DESCRIPTION" desc="Description for the ambient mode settings page.">
When your screen is idle, show photos, time, weather, and media info. When your screen is idle, show photos, time, weather, and media info.
</message> </message>

1
chromeos/chromeos_strings_grd/IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_BUTTON_ARIA_LABEL.png.sha1 Normal file

@@ -0,0 +1 @@
8c3faf674cb73bc9933af95dfe60b135bdc5bc8a

1
chromeos/chromeos_strings_grd/IDS_PERSONALIZATION_APP_SCREENSAVER_PREVIEW_DOWNLOADING_ARIA_LABEL.png.sha1 Normal file

@@ -0,0 +1 @@
8d11950388cb4c3dac3cd92e89218e0b9d6787df