0

Replace s/NULL/nullptr/ in field initializers used in constructors.

This change has been generated by a clang tool developed for the
go/miracleptr project.

Bug: 1080832
Change-Id: Ie7f428c8ad300db1df95d873668163d0ac719a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231843
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776343}
This commit is contained in:
Lukasz Anforowicz
2020-06-09 02:09:45 +00:00
committed by Commit Bot
parent ee4199af27
commit c695e53d88
143 changed files with 255 additions and 318 deletions
base
cc/trees
chrome
browser
apps
bookmarks
chrome_browser_main.cc
devtools
diagnostics
download
extensions
gcm
importer
media
media_galleries
net
policy
process_singleton_posix_unittest.cc
search_engines
sessions
ssl
themes
ui
common
renderer
service
test
utility
components/nacl
content/public/common
device/bluetooth/bluez
extensions
gin
headless/lib/browser
ipc
jingle
media
printing
remoting
services
third_party/blink/renderer/platform/wtf
tools
imagediff
xdisplaycheck
ui
url

@ -84,17 +84,15 @@ class StackAllocator : public std::allocator<T> {
// for Us. // for Us.
// TODO: If we were fancy pants, perhaps we could share storage // TODO: If we were fancy pants, perhaps we could share storage
// iff sizeof(T) == sizeof(U). // iff sizeof(T) == sizeof(U).
template<typename U, size_t other_capacity> template <typename U, size_t other_capacity>
StackAllocator(const StackAllocator<U, other_capacity>& other) StackAllocator(const StackAllocator<U, other_capacity>& other)
: source_(NULL) { : source_(nullptr) {}
}
// This constructor must exist. It creates a default allocator that doesn't // This constructor must exist. It creates a default allocator that doesn't
// actually have a stack buffer. glibc's std::string() will compare the // actually have a stack buffer. glibc's std::string() will compare the
// current allocator against the default-constructed allocator, so this // current allocator against the default-constructed allocator, so this
// should be fast. // should be fast.
StackAllocator() : source_(NULL) { StackAllocator() : source_(nullptr) {}
}
explicit StackAllocator(Source* source) : source_(source) { explicit StackAllocator(Source* source) : source_(source) {
} }

@ -163,7 +163,7 @@ template <typename STRING_TYPE> class BasicStringPiece {
// We provide non-explicit singleton constructors so users can pass // We provide non-explicit singleton constructors so users can pass
// in a "const char*" or a "string" wherever a "StringPiece" is // in a "const char*" or a "string" wherever a "StringPiece" is
// expected (likewise for char16, string16, StringPiece16). // expected (likewise for char16, string16, StringPiece16).
constexpr BasicStringPiece() : ptr_(NULL), length_(0) {} constexpr BasicStringPiece() : ptr_(nullptr), length_(0) {}
// TODO(crbug.com/1049498): Construction from nullptr is not allowed for // TODO(crbug.com/1049498): Construction from nullptr is not allowed for
// std::basic_string_view, so remove the special handling for it. // std::basic_string_view, so remove the special handling for it.
// Note: This doesn't just use STRING_TYPE::traits_type::length(), since that // Note: This doesn't just use STRING_TYPE::traits_type::length(), since that

@ -59,7 +59,7 @@ class CC_EXPORT OcclusionTracker {
protected: protected:
struct StackObject { struct StackObject {
StackObject() : target(0) {} StackObject() : target(nullptr) {}
explicit StackObject(const RenderSurfaceImpl* target) : target(target) {} explicit StackObject(const RenderSurfaceImpl* target) : target(target) {}
const RenderSurfaceImpl* target; const RenderSurfaceImpl* target;
SimpleEnclosedRegion occlusion_from_outside_target; SimpleEnclosedRegion occlusion_from_outside_target;

@ -153,8 +153,8 @@ class NewSubViewAddedObserver : content::RenderWidgetHostViewCocoaObserver {
class WebViewInteractiveTest : public extensions::PlatformAppBrowserTest { class WebViewInteractiveTest : public extensions::PlatformAppBrowserTest {
public: public:
WebViewInteractiveTest() WebViewInteractiveTest()
: guest_web_contents_(NULL), : guest_web_contents_(nullptr),
embedder_web_contents_(NULL), embedder_web_contents_(nullptr),
corner_(gfx::Point()), corner_(gfx::Point()),
mouse_click_result_(false), mouse_click_result_(false),
first_click_(true) { first_click_(true) {
@ -410,8 +410,7 @@ class WebViewInteractiveTest : public extensions::PlatformAppBrowserTest {
class PopupCreatedObserver { class PopupCreatedObserver {
public: public:
PopupCreatedObserver() PopupCreatedObserver()
: initial_widget_count_(0), : initial_widget_count_(0), last_render_widget_host_(nullptr) {}
last_render_widget_host_(NULL) {}
~PopupCreatedObserver() {} ~PopupCreatedObserver() {}

@ -74,7 +74,7 @@ const char kGalleryChangedEventReceived[] = "gallery_changed_event_received";
class MediaGalleriesGalleryWatchApiTest : public extensions::ExtensionApiTest { class MediaGalleriesGalleryWatchApiTest : public extensions::ExtensionApiTest {
public: public:
MediaGalleriesGalleryWatchApiTest() MediaGalleriesGalleryWatchApiTest()
: extension_(NULL), background_host_(NULL) {} : extension_(nullptr), background_host_(nullptr) {}
~MediaGalleriesGalleryWatchApiTest() override {} ~MediaGalleriesGalleryWatchApiTest() override {}
protected: protected:

@ -58,7 +58,7 @@ TEST(ManagedBookmarkServiceNoPolicyTest, EmptyManagedNode) {
class ManagedBookmarkServiceTest : public testing::Test { class ManagedBookmarkServiceTest : public testing::Test {
public: public:
ManagedBookmarkServiceTest() : managed_(NULL), model_(NULL) {} ManagedBookmarkServiceTest() : managed_(nullptr), model_(nullptr) {}
~ManagedBookmarkServiceTest() override {} ~ManagedBookmarkServiceTest() override {}
void SetUp() override { void SetUp() override {

@ -486,7 +486,7 @@ ChromeBrowserMainParts::ChromeBrowserMainParts(
result_code_(service_manager::RESULT_CODE_NORMAL_EXIT), result_code_(service_manager::RESULT_CODE_NORMAL_EXIT),
should_call_pre_main_loop_start_startup_on_variations_service_( should_call_pre_main_loop_start_startup_on_variations_service_(
!parameters.ui_task), !parameters.ui_task),
profile_(NULL), profile_(nullptr),
run_message_loop_(true), run_message_loop_(true),
startup_data_(startup_data) { startup_data_(startup_data) {
DCHECK(startup_data_); DCHECK(startup_data_);

@ -216,7 +216,7 @@ void SwitchToExtensionPanel(DevToolsWindow* window,
class DevToolsSanityTest : public InProcessBrowserTest { class DevToolsSanityTest : public InProcessBrowserTest {
public: public:
DevToolsSanityTest() : window_(NULL) {} DevToolsSanityTest() : window_(nullptr) {}
void SetUpOnMainThread() override { void SetUpOnMainThread() override {
host_resolver()->AddRule("*", "127.0.0.1"); host_resolver()->AddRule("*", "127.0.0.1");
@ -618,7 +618,7 @@ class DevToolsExperimentalExtensionTest : public DevToolsExtensionTest {
class WorkerDevToolsSanityTest : public InProcessBrowserTest { class WorkerDevToolsSanityTest : public InProcessBrowserTest {
public: public:
WorkerDevToolsSanityTest() : window_(NULL) {} WorkerDevToolsSanityTest() : window_(nullptr) {}
protected: protected:
class WorkerCreationObserver : public DevToolsAgentHostObserver { class WorkerCreationObserver : public DevToolsAgentHostObserver {

@ -26,7 +26,7 @@ DiagnosticsController* DiagnosticsController::GetInstance() {
return base::Singleton<DiagnosticsController>::get(); return base::Singleton<DiagnosticsController>::get();
} }
DiagnosticsController::DiagnosticsController() : writer_(NULL) {} DiagnosticsController::DiagnosticsController() : writer_(nullptr) {}
DiagnosticsController::~DiagnosticsController() {} DiagnosticsController::~DiagnosticsController() {}

@ -165,11 +165,10 @@ DownloadUIControllerTest::TestingDownloadCoreServiceFactory(
} }
DownloadUIControllerTest::DownloadUIControllerTest() DownloadUIControllerTest::DownloadUIControllerTest()
: download_history_manager_observer_(NULL), : download_history_manager_observer_(nullptr),
manager_observer_(NULL), manager_observer_(nullptr),
notified_item_(NULL), notified_item_(nullptr),
notified_item_receiver_factory_(&notified_item_) { notified_item_receiver_factory_(&notified_item_) {}
}
void DownloadUIControllerTest::SetUp() { void DownloadUIControllerTest::SetUp() {
ChromeRenderViewHostTestHarness::SetUp(); ChromeRenderViewHostTestHarness::SetUp();

@ -460,7 +460,7 @@ ActivityLog* ActivityLog::GetInstance(content::BrowserContext* context) {
// Use GetInstance instead of directly creating an ActivityLog. // Use GetInstance instead of directly creating an ActivityLog.
ActivityLog::ActivityLog(content::BrowserContext* context) ActivityLog::ActivityLog(content::BrowserContext* context)
: database_policy_(NULL), : database_policy_(nullptr),
database_policy_type_(ActivityLogPolicy::POLICY_INVALID), database_policy_type_(ActivityLogPolicy::POLICY_INVALID),
profile_(Profile::FromBrowserContext(context)), profile_(Profile::FromBrowserContext(context)),
extension_system_(ExtensionSystem::Get(context)), extension_system_(ExtensionSystem::Get(context)),

@ -35,11 +35,11 @@ namespace bookmark_api_helpers {
class ExtensionBookmarksTest : public testing::Test { class ExtensionBookmarksTest : public testing::Test {
public: public:
ExtensionBookmarksTest() ExtensionBookmarksTest()
: managed_(NULL), : managed_(nullptr),
model_(NULL), model_(nullptr),
node_(NULL), node_(nullptr),
node2_(NULL), node2_(nullptr),
folder_(NULL) {} folder_(nullptr) {}
void SetUp() override { void SetUp() override {
profile_.CreateBookmarkModel(false); profile_.CreateBookmarkModel(false);

@ -9,7 +9,7 @@ namespace api {
namespace braille_display_private { namespace braille_display_private {
MockBrailleController::MockBrailleController() MockBrailleController::MockBrailleController()
: available_(false), observer_(NULL) {} : available_(false), observer_(nullptr) {}
std::unique_ptr<DisplayState> MockBrailleController::GetDisplayState() { std::unique_ptr<DisplayState> MockBrailleController::GetDisplayState() {
std::unique_ptr<DisplayState> state(new DisplayState()); std::unique_ptr<DisplayState> state(new DisplayState());

@ -45,7 +45,7 @@ namespace extensions {
class ExtensionContentSettingsApiTest : public ExtensionApiTest { class ExtensionContentSettingsApiTest : public ExtensionApiTest {
public: public:
ExtensionContentSettingsApiTest() : profile_(NULL) {} ExtensionContentSettingsApiTest() : profile_(nullptr) {}
void SetUpOnMainThread() override { void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread(); ExtensionApiTest::SetUpOnMainThread();

@ -389,9 +389,7 @@ bool ExtensionDevToolsClientHost::MayWriteLocalFiles() {
// DebuggerFunction ----------------------------------------------------------- // DebuggerFunction -----------------------------------------------------------
DebuggerFunction::DebuggerFunction() DebuggerFunction::DebuggerFunction() : client_host_(nullptr) {}
: client_host_(NULL) {
}
DebuggerFunction::~DebuggerFunction() = default; DebuggerFunction::~DebuggerFunction() = default;

@ -113,7 +113,7 @@ class RequestContentScriptAPITest : public ExtensionBrowserTest {
}; };
RequestContentScriptAPITest::RequestContentScriptAPITest() RequestContentScriptAPITest::RequestContentScriptAPITest()
: extension_(NULL) {} : extension_(nullptr) {}
testing::AssertionResult RequestContentScriptAPITest::RunTest( testing::AssertionResult RequestContentScriptAPITest::RunTest(
PermissionOrMatcherType manifest_permission, PermissionOrMatcherType manifest_permission,

@ -320,10 +320,9 @@ class DownloadOpenObserver : public download::DownloadItem::Observer {
class DownloadExtensionTest : public ExtensionApiTest { class DownloadExtensionTest : public ExtensionApiTest {
public: public:
DownloadExtensionTest() DownloadExtensionTest()
: extension_(NULL), : extension_(nullptr),
incognito_browser_(NULL), incognito_browser_(nullptr),
current_browser_(NULL) { current_browser_(nullptr) {}
}
protected: protected:
// Used with CreateHistoryDownloads // Used with CreateHistoryDownloads

@ -240,11 +240,10 @@ void ExtensionActionAPI::Shutdown() {
// //
ExtensionActionFunction::ExtensionActionFunction() ExtensionActionFunction::ExtensionActionFunction()
: details_(NULL), : details_(nullptr),
tab_id_(ExtensionAction::kDefaultTabId), tab_id_(ExtensionAction::kDefaultTabId),
contents_(NULL), contents_(nullptr),
extension_action_(NULL) { extension_action_(nullptr) {}
}
ExtensionActionFunction::~ExtensionActionFunction() { ExtensionActionFunction::~ExtensionActionFunction() {
} }

@ -60,7 +60,7 @@ namespace extensions {
class GcmApiTest : public ExtensionApiTest { class GcmApiTest : public ExtensionApiTest {
public: public:
GcmApiTest() : fake_gcm_profile_service_(NULL) {} GcmApiTest() : fake_gcm_profile_service_(nullptr) {}
protected: protected:
void SetUpCommandLine(base::CommandLine* command_line) override; void SetUpCommandLine(base::CommandLine* command_line) override;

@ -59,7 +59,7 @@ NativeMessageProcessHost::NativeMessageProcessHost(
const std::string& source_extension_id, const std::string& source_extension_id,
const std::string& native_host_name, const std::string& native_host_name,
std::unique_ptr<NativeProcessLauncher> launcher) std::unique_ptr<NativeProcessLauncher> launcher)
: client_(NULL), : client_(nullptr),
source_extension_id_(source_extension_id), source_extension_id_(source_extension_id),
native_host_name_(native_host_name), native_host_name_(native_host_name),
launcher_(std::move(launcher)), launcher_(std::move(launcher)),

@ -42,7 +42,7 @@
class ExtensionPreferenceApiTest : public extensions::ExtensionApiTest { class ExtensionPreferenceApiTest : public extensions::ExtensionApiTest {
protected: protected:
ExtensionPreferenceApiTest() : profile_(NULL) {} ExtensionPreferenceApiTest() : profile_(nullptr) {}
void CheckPreferencesSet() { void CheckPreferencesSet() {
PrefService* prefs = profile_->GetPrefs(); PrefService* prefs = profile_->GetPrefs();

@ -1211,8 +1211,7 @@ bool TabsHighlightFunction::HighlightTab(TabStripModel* tabstrip,
return true; return true;
} }
TabsUpdateFunction::TabsUpdateFunction() : web_contents_(NULL) { TabsUpdateFunction::TabsUpdateFunction() : web_contents_(nullptr) {}
}
ExtensionFunction::ResponseAction TabsUpdateFunction::Run() { ExtensionFunction::ResponseAction TabsUpdateFunction::Run() {
std::unique_ptr<tabs::Update::Params> params( std::unique_ptr<tabs::Update::Params> params(

@ -145,8 +145,7 @@ namespace {
// Native Client embeds. // Native Client embeds.
class AppBackgroundPageNaClTest : public AppBackgroundPageApiTest { class AppBackgroundPageNaClTest : public AppBackgroundPageApiTest {
public: public:
AppBackgroundPageNaClTest() AppBackgroundPageNaClTest() : extension_(nullptr) {}
: extension_(NULL) {}
~AppBackgroundPageNaClTest() override {} ~AppBackgroundPageNaClTest() override {}
void SetUpOnMainThread() override { void SetUpOnMainThread() override {

@ -132,7 +132,7 @@ void CheckManifestError(const ExtensionError* error,
class ErrorConsoleBrowserTest : public ExtensionBrowserTest { class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
public: public:
ErrorConsoleBrowserTest() : error_console_(NULL) { } ErrorConsoleBrowserTest() : error_console_(nullptr) {}
~ErrorConsoleBrowserTest() override {} ~ErrorConsoleBrowserTest() override {}
protected: protected:

@ -128,7 +128,7 @@ ExtensionBrowserTest::ExtensionBrowserTest()
start_menu_override_(base::DIR_START_MENU), start_menu_override_(base::DIR_START_MENU),
common_start_menu_override_(base::DIR_COMMON_START_MENU), common_start_menu_override_(base::DIR_COMMON_START_MENU),
#endif #endif
profile_(NULL), profile_(nullptr),
verifier_format_override_(crx_file::VerifierFormat::CRX3) { verifier_format_override_(crx_file::VerifierFormat::CRX3) {
EXPECT_TRUE(temp_dir_.CreateUniqueTempDir()); EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());
} }

@ -15,9 +15,9 @@ ExtensionCommandsGlobalRegistry::ExtensionCommandsGlobalRegistry(
content::BrowserContext* context) content::BrowserContext* context)
: ExtensionKeybindingRegistry(context, : ExtensionKeybindingRegistry(context,
ExtensionKeybindingRegistry::ALL_EXTENSIONS, ExtensionKeybindingRegistry::ALL_EXTENSIONS,
NULL), nullptr),
browser_context_(context), browser_context_(context),
registry_for_active_window_(NULL) { registry_for_active_window_(nullptr) {
Init(); Init();
} }

@ -245,7 +245,7 @@ class ExtensionGCMAppHandlerTest : public testing::Test {
ExtensionGCMAppHandlerTest() ExtensionGCMAppHandlerTest()
: task_environment_(content::BrowserTaskEnvironment::REAL_IO_THREAD), : task_environment_(content::BrowserTaskEnvironment::REAL_IO_THREAD),
extension_service_(NULL), extension_service_(nullptr),
registration_result_(gcm::GCMClient::UNKNOWN_ERROR), registration_result_(gcm::GCMClient::UNKNOWN_ERROR),
unregistration_result_(gcm::GCMClient::UNKNOWN_ERROR) {} unregistration_result_(gcm::GCMClient::UNKNOWN_ERROR) {}

@ -43,7 +43,7 @@ namespace extensions {
class ExtensionUserScriptLoaderTest : public testing::Test, class ExtensionUserScriptLoaderTest : public testing::Test,
public content::NotificationObserver { public content::NotificationObserver {
public: public:
ExtensionUserScriptLoaderTest() : shared_memory_(NULL) {} ExtensionUserScriptLoaderTest() : shared_memory_(nullptr) {}
void SetUp() override { void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

@ -78,7 +78,7 @@ TabHelper::~TabHelper() = default;
TabHelper::TabHelper(content::WebContents* web_contents) TabHelper::TabHelper(content::WebContents* web_contents)
: content::WebContentsObserver(web_contents), : content::WebContentsObserver(web_contents),
profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())), profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
extension_app_(NULL), extension_app_(nullptr),
script_executor_(new ScriptExecutor(web_contents)), script_executor_(new ScriptExecutor(web_contents)),
extension_action_runner_(new ExtensionActionRunner(web_contents)), extension_action_runner_(new ExtensionActionRunner(web_contents)),
declarative_net_request_helper_(web_contents) { declarative_net_request_helper_(web_contents) {

@ -49,15 +49,13 @@ void BlacklistStateFetcherMock::Clear() {
states_.clear(); states_.clear();
} }
TestBlacklist::TestBlacklist() TestBlacklist::TestBlacklist()
: blacklist_(NULL), : blacklist_(nullptr),
blacklist_db_(new FakeSafeBrowsingDatabaseManager(true)), blacklist_db_(new FakeSafeBrowsingDatabaseManager(true)),
scoped_blacklist_db_(blacklist_db_) { scoped_blacklist_db_(blacklist_db_) {}
}
TestBlacklist::TestBlacklist(Blacklist* blacklist) TestBlacklist::TestBlacklist(Blacklist* blacklist)
: blacklist_(NULL), : blacklist_(nullptr),
blacklist_db_(new FakeSafeBrowsingDatabaseManager(true)), blacklist_db_(new FakeSafeBrowsingDatabaseManager(true)),
scoped_blacklist_db_(blacklist_db_) { scoped_blacklist_db_(blacklist_db_) {
Attach(blacklist); Attach(blacklist);

@ -143,11 +143,10 @@ class GCMProfileServiceTest : public testing::Test {
}; };
GCMProfileServiceTest::GCMProfileServiceTest() GCMProfileServiceTest::GCMProfileServiceTest()
: gcm_profile_service_(NULL), : gcm_profile_service_(nullptr),
gcm_app_handler_(new FakeGCMAppHandler), gcm_app_handler_(new FakeGCMAppHandler),
registration_result_(GCMClient::UNKNOWN_ERROR), registration_result_(GCMClient::UNKNOWN_ERROR),
send_result_(GCMClient::UNKNOWN_ERROR) { send_result_(GCMClient::UNKNOWN_ERROR) {}
}
GCMProfileServiceTest::~GCMProfileServiceTest() { GCMProfileServiceTest::~GCMProfileServiceTest() {
} }

@ -23,13 +23,13 @@ using content::BrowserThread;
ExternalProcessImporterHost::ExternalProcessImporterHost() ExternalProcessImporterHost::ExternalProcessImporterHost()
: headless_(false), : headless_(false),
parent_window_(NULL), parent_window_(nullptr),
observer_(NULL), observer_(nullptr),
profile_(NULL), profile_(nullptr),
waiting_for_bookmarkbar_model_(false), waiting_for_bookmarkbar_model_(false),
installed_bookmark_observer_(false), installed_bookmark_observer_(false),
is_source_readable_(true), is_source_readable_(true),
client_(NULL), client_(nullptr),
items_(0), items_(0),
cancelled_(false) {} cancelled_(false) {}

@ -14,7 +14,7 @@ namespace media_router {
class MockDnsSdDeviceLister : public DnsSdDeviceLister { class MockDnsSdDeviceLister : public DnsSdDeviceLister {
public: public:
MockDnsSdDeviceLister() : DnsSdDeviceLister(NULL, NULL, "") {} MockDnsSdDeviceLister() : DnsSdDeviceLister(nullptr, nullptr, "") {}
~MockDnsSdDeviceLister() override {} ~MockDnsSdDeviceLister() override {}
MOCK_METHOD0(Discover, void()); MOCK_METHOD0(Discover, void());
@ -22,7 +22,7 @@ class MockDnsSdDeviceLister : public DnsSdDeviceLister {
class TestDnsSdRegistry : public DnsSdRegistry { class TestDnsSdRegistry : public DnsSdRegistry {
public: public:
TestDnsSdRegistry() : DnsSdRegistry(NULL), delegate_(NULL) {} TestDnsSdRegistry() : DnsSdRegistry(nullptr), delegate_(nullptr) {}
~TestDnsSdRegistry() override {} ~TestDnsSdRegistry() override {}
MockDnsSdDeviceLister* GetListerForService(const std::string& service_type) { MockDnsSdDeviceLister* GetListerForService(const std::string& service_type) {

@ -14,7 +14,7 @@
using content::DesktopMediaID; using content::DesktopMediaID;
FakeDesktopMediaList::FakeDesktopMediaList(DesktopMediaID::Type type) FakeDesktopMediaList::FakeDesktopMediaList(DesktopMediaID::Type type)
: observer_(NULL), type_(type) {} : observer_(nullptr), type_(type) {}
FakeDesktopMediaList::~FakeDesktopMediaList() {} FakeDesktopMediaList::~FakeDesktopMediaList() {}
void FakeDesktopMediaList::AddSource(int id) { void FakeDesktopMediaList::AddSource(int id) {

@ -61,10 +61,10 @@ class GalleryWatchManagerTest : public GalleryWatchManagerObserver,
test_user_manager_(std::make_unique<chromeos::ScopedTestUserManager>()), test_user_manager_(std::make_unique<chromeos::ScopedTestUserManager>()),
#endif #endif
profile_(new TestingProfile()), profile_(new TestingProfile()),
gallery_prefs_(NULL), gallery_prefs_(nullptr),
expect_gallery_changed_(false), expect_gallery_changed_(false),
expect_gallery_watch_dropped_(false), expect_gallery_watch_dropped_(false),
pending_loop_(NULL) { pending_loop_(nullptr) {
} }
~GalleryWatchManagerTest() override {} ~GalleryWatchManagerTest() override {}

@ -100,7 +100,7 @@ MediaGalleriesPermissionController::MediaGalleriesPermissionController(
MediaGalleriesPreferences* preferences, MediaGalleriesPreferences* preferences,
const CreateDialogCallback& create_dialog_callback, const CreateDialogCallback& create_dialog_callback,
const base::Closure& on_finish) const base::Closure& on_finish)
: web_contents_(NULL), : web_contents_(nullptr),
extension_(&extension), extension_(&extension),
on_finish_(on_finish), on_finish_(on_finish),
preferences_(preferences), preferences_(preferences),

@ -44,9 +44,9 @@ std::string GalleryName(const MediaGalleryPrefInfo& gallery) {
class MediaGalleriesPermissionControllerTest : public ::testing::Test { class MediaGalleriesPermissionControllerTest : public ::testing::Test {
public: public:
MediaGalleriesPermissionControllerTest() MediaGalleriesPermissionControllerTest()
: dialog_(NULL), : dialog_(nullptr),
dialog_update_count_at_destruction_(0), dialog_update_count_at_destruction_(0),
controller_(NULL), controller_(nullptr),
profile_(new TestingProfile()) {} profile_(new TestingProfile()) {}
~MediaGalleriesPermissionControllerTest() override { ~MediaGalleriesPermissionControllerTest() override {

@ -423,8 +423,8 @@ class DnsProbeBrowserTest : public InProcessBrowserTest {
DnsProbeBrowserTest::DnsProbeBrowserTest() DnsProbeBrowserTest::DnsProbeBrowserTest()
: helper_(new DnsProbeBrowserTestIOThreadHelper()), : helper_(new DnsProbeBrowserTestIOThreadHelper()),
active_browser_(NULL), active_browser_(nullptr),
monitored_tab_helper_(NULL) { monitored_tab_helper_(nullptr) {
NavigationCorrectionTabObserver::SetAllowEnableCorrectionsForTesting(true); NavigationCorrectionTabObserver::SetAllowEnableCorrectionsForTesting(true);
} }

@ -403,7 +403,7 @@ class TestAddAppWindowObserver
TestAddAppWindowObserver::TestAddAppWindowObserver( TestAddAppWindowObserver::TestAddAppWindowObserver(
extensions::AppWindowRegistry* registry) extensions::AppWindowRegistry* registry)
: registry_(registry), window_(NULL) { : registry_(registry), window_(nullptr) {
registry_->AddObserver(this); registry_->AddObserver(this);
} }

@ -74,7 +74,7 @@ class ProcessSingletonPosixTest : public testing::Test {
base::WaitableEvent::InitialState::NOT_SIGNALED), base::WaitableEvent::InitialState::NOT_SIGNALED),
signal_event_(base::WaitableEvent::ResetPolicy::MANUAL, signal_event_(base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED), base::WaitableEvent::InitialState::NOT_SIGNALED),
process_singleton_on_thread_(NULL) {} process_singleton_on_thread_(nullptr) {}
void SetUp() override { void SetUp() override {
testing::Test::SetUp(); testing::Test::SetUp();

@ -8,8 +8,7 @@
ChromeTemplateURLServiceClient::ChromeTemplateURLServiceClient( ChromeTemplateURLServiceClient::ChromeTemplateURLServiceClient(
history::HistoryService* history_service) history::HistoryService* history_service)
: owner_(NULL), : owner_(nullptr), history_service_(history_service) {
history_service_(history_service) {
// TODO(sky): bug 1166191. The keywords should be moved into the history // TODO(sky): bug 1166191. The keywords should be moved into the history
// db, which will mean we no longer need this notification and the history // db, which will mean we no longer need this notification and the history
// backend can handle automatically adding the search terms as the user // backend can handle automatically adding the search terms as the user

@ -80,7 +80,7 @@ class TabRestoreServiceImplTest : public ChromeRenderViewHostTestHarness {
user_agent_override_(blink::UserAgentOverride::UserAgentOnly( user_agent_override_(blink::UserAgentOverride::UserAgentOnly(
"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19"
" (KHTML, like Gecko) Chrome/18.0.1025.45 Safari/535.19")), " (KHTML, like Gecko) Chrome/18.0.1025.45 Safari/535.19")),
time_factory_(NULL), time_factory_(nullptr),
window_id_(SessionID::FromSerializedValue(1)), window_id_(SessionID::FromSerializedValue(1)),
tab_id_(SessionID::FromSerializedValue(2)) { tab_id_(SessionID::FromSerializedValue(2)) {
user_agent_override_.ua_metadata_override.emplace(); user_agent_override_.ua_metadata_override.emplace();

@ -2097,7 +2097,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITestWithHttpDangerous, MarkBlobAsNonSecure) {
#if defined(USE_NSS_CERTS) #if defined(USE_NSS_CERTS)
class SSLUITestWithClientCert : public SSLUITestBase { class SSLUITestWithClientCert : public SSLUITestBase {
public: public:
SSLUITestWithClientCert() : cert_db_(NULL) {} SSLUITestWithClientCert() : cert_db_(nullptr) {}
void SetUpOnMainThread() override { void SetUpOnMainThread() override {
SSLUITestBase::SetUpOnMainThread(); SSLUITestBase::SetUpOnMainThread();

@ -176,7 +176,7 @@ scoped_refptr<extensions::Extension> MakeThemeExtension(
class ThemeSyncableServiceTest : public testing::Test { class ThemeSyncableServiceTest : public testing::Test {
protected: protected:
ThemeSyncableServiceTest() : fake_theme_service_(NULL) {} ThemeSyncableServiceTest() : fake_theme_service_(nullptr) {}
~ThemeSyncableServiceTest() override {} ~ThemeSyncableServiceTest() override {}

@ -15,9 +15,7 @@
using content::WebContents; using content::WebContents;
WebDragBookmarkHandlerAura::WebDragBookmarkHandlerAura() WebDragBookmarkHandlerAura::WebDragBookmarkHandlerAura()
: bookmark_tab_helper_(NULL), : bookmark_tab_helper_(nullptr), web_contents_(nullptr) {}
web_contents_(NULL) {
}
WebDragBookmarkHandlerAura::~WebDragBookmarkHandlerAura() { WebDragBookmarkHandlerAura::~WebDragBookmarkHandlerAura() {
} }

@ -227,7 +227,7 @@ class AutofillPopupControllerUnitTest : public ChromeRenderViewHostTestHarness {
public: public:
AutofillPopupControllerUnitTest() AutofillPopupControllerUnitTest()
: autofill_client_(new MockAutofillClient()), : autofill_client_(new MockAutofillClient()),
autofill_popup_controller_(NULL) {} autofill_popup_controller_(nullptr) {}
~AutofillPopupControllerUnitTest() override = default; ~AutofillPopupControllerUnitTest() override = default;
void SetUp() override { void SetUp() override {

@ -89,8 +89,8 @@ bool BookmarkTabHelper::HasObserver(BookmarkTabHelperObserver* observer) const {
BookmarkTabHelper::BookmarkTabHelper(content::WebContents* web_contents) BookmarkTabHelper::BookmarkTabHelper(content::WebContents* web_contents)
: content::WebContentsObserver(web_contents), : content::WebContentsObserver(web_contents),
is_starred_(false), is_starred_(false),
bookmark_model_(NULL), bookmark_model_(nullptr),
bookmark_drag_(NULL) { bookmark_drag_(nullptr) {
bookmark_model_ = BookmarkModelFactory::GetForBrowserContext( bookmark_model_ = BookmarkModelFactory::GetForBrowserContext(
web_contents->GetBrowserContext()); web_contents->GetBrowserContext());
if (bookmark_model_) if (bookmark_model_)

@ -333,7 +333,7 @@ class BrowserBookmarkBarTest : public BrowserWithTestWindowTest {
class BookmarkBarStateTestBrowserWindow : public TestBrowserWindow { class BookmarkBarStateTestBrowserWindow : public TestBrowserWindow {
public: public:
BookmarkBarStateTestBrowserWindow() BookmarkBarStateTestBrowserWindow()
: browser_(NULL), bookmark_bar_state_(BookmarkBar::HIDDEN) {} : browser_(nullptr), bookmark_bar_state_(BookmarkBar::HIDDEN) {}
~BookmarkBarStateTestBrowserWindow() override {} ~BookmarkBarStateTestBrowserWindow() override {}
void set_browser(Browser* browser) { browser_ = browser; } void set_browser(Browser* browser) { browser_ = browser; }

@ -84,9 +84,7 @@ class FullscreenControllerTestWindow : public TestBrowserWindow,
}; };
FullscreenControllerTestWindow::FullscreenControllerTestWindow() FullscreenControllerTestWindow::FullscreenControllerTestWindow()
: state_(NORMAL), : state_(NORMAL), browser_(nullptr) {}
browser_(NULL) {
}
void FullscreenControllerTestWindow::EnterFullscreen( void FullscreenControllerTestWindow::EnterFullscreen(
const GURL& url, const GURL& url,

@ -18,7 +18,7 @@
TemplateURLTableModel::TemplateURLTableModel( TemplateURLTableModel::TemplateURLTableModel(
TemplateURLService* template_url_service) TemplateURLService* template_url_service)
: observer_(NULL), template_url_service_(template_url_service) { : observer_(nullptr), template_url_service_(template_url_service) {
DCHECK(template_url_service); DCHECK(template_url_service);
template_url_service_->AddObserver(this); template_url_service_->AddObserver(this);
template_url_service_->Load(); template_url_service_->Load();

@ -347,8 +347,8 @@ StartupBrowserCreatorImpl::StartupBrowserCreatorImpl(
chrome::startup::IsFirstRun is_first_run) chrome::startup::IsFirstRun is_first_run)
: cur_dir_(cur_dir), : cur_dir_(cur_dir),
command_line_(command_line), command_line_(command_line),
profile_(NULL), profile_(nullptr),
browser_creator_(NULL), browser_creator_(nullptr),
is_first_run_(is_first_run == chrome::startup::IS_FIRST_RUN) {} is_first_run_(is_first_run == chrome::startup::IS_FIRST_RUN) {}
StartupBrowserCreatorImpl::StartupBrowserCreatorImpl( StartupBrowserCreatorImpl::StartupBrowserCreatorImpl(
@ -358,7 +358,7 @@ StartupBrowserCreatorImpl::StartupBrowserCreatorImpl(
chrome::startup::IsFirstRun is_first_run) chrome::startup::IsFirstRun is_first_run)
: cur_dir_(cur_dir), : cur_dir_(cur_dir),
command_line_(command_line), command_line_(command_line),
profile_(NULL), profile_(nullptr),
browser_creator_(browser_creator), browser_creator_(browser_creator),
is_first_run_(is_first_run == chrome::startup::IS_FIRST_RUN) {} is_first_run_(is_first_run == chrome::startup::IS_FIRST_RUN) {}

@ -127,9 +127,7 @@ static scoped_refptr<extensions::Extension> CreateExtension(
class ProfileSigninConfirmationHelperTest : public testing::Test { class ProfileSigninConfirmationHelperTest : public testing::Test {
public: public:
ProfileSigninConfirmationHelperTest() ProfileSigninConfirmationHelperTest()
: user_prefs_(NULL), : user_prefs_(nullptr), model_(nullptr) {}
model_(NULL) {
}
void SetUp() override { void SetUp() override {
ASSERT_TRUE(profile_dir_.CreateUniqueTempDir()); ASSERT_TRUE(profile_dir_.CreateUniqueTempDir());

@ -54,8 +54,8 @@ void MockTabModalConfirmDialogDelegate::OnClosed() {
} }
TabModalConfirmDialogTest::TabModalConfirmDialogTest() TabModalConfirmDialogTest::TabModalConfirmDialogTest()
: delegate_(NULL), : delegate_(nullptr),
dialog_(NULL), dialog_(nullptr),
accepted_count_(0), accepted_count_(0),
canceled_count_(0), canceled_count_(0),
closed_count_(0) {} closed_count_(0) {}

@ -35,7 +35,7 @@ PinnedTabService* BuildForProfile(Profile* profile) {
class PinnedTabServiceTest : public BrowserWithTestWindowTest { class PinnedTabServiceTest : public BrowserWithTestWindowTest {
public: public:
PinnedTabServiceTest() : pinned_tab_service_(NULL) {} PinnedTabServiceTest() : pinned_tab_service_(nullptr) {}
protected: protected:
TestingProfile* CreateProfile() override { TestingProfile* CreateProfile() override {

@ -61,7 +61,7 @@ BookmarkContextMenu::BookmarkContextMenu(
views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::HAS_MNEMONICS |
views::MenuRunner::IS_NESTED | views::MenuRunner::IS_NESTED |
views::MenuRunner::CONTEXT_MENU)), views::MenuRunner::CONTEXT_MENU)),
observer_(NULL), observer_(nullptr),
close_on_remove_(close_on_remove) { close_on_remove_(close_on_remove) {
ui::SimpleMenuModel* menu_model = controller_->menu_model(); ui::SimpleMenuModel* menu_model = controller_->menu_model();
for (int i = 0; i < menu_model->GetItemCount(); ++i) { for (int i = 0; i < menu_model->GetItemCount(); ++i) {

@ -75,13 +75,12 @@ BookmarkMenuDelegate::BookmarkMenuDelegate(Browser* browser,
profile_(browser->profile()), profile_(browser->profile()),
page_navigator_(navigator), page_navigator_(navigator),
parent_(parent), parent_(parent),
menu_(NULL), menu_(nullptr),
parent_menu_item_(NULL), parent_menu_item_(nullptr),
next_menu_id_(IDC_FIRST_BOOKMARK_MENU), next_menu_id_(IDC_FIRST_BOOKMARK_MENU),
real_delegate_(NULL), real_delegate_(nullptr),
is_mutating_model_(false), is_mutating_model_(false),
location_(BOOKMARK_LAUNCH_LOCATION_NONE) { location_(BOOKMARK_LAUNCH_LOCATION_NONE) {}
}
BookmarkMenuDelegate::~BookmarkMenuDelegate() { BookmarkMenuDelegate::~BookmarkMenuDelegate() {
GetBookmarkModel()->RemoveObserver(this); GetBookmarkModel()->RemoveObserver(this);

@ -23,7 +23,7 @@ using bookmarks::BookmarkNode;
class BookmarkMenuDelegateTest : public BrowserWithTestWindowTest { class BookmarkMenuDelegateTest : public BrowserWithTestWindowTest {
public: public:
BookmarkMenuDelegateTest() : model_(NULL) {} BookmarkMenuDelegateTest() : model_(nullptr) {}
void SetUp() override { void SetUp() override {
BrowserWithTestWindowTest::SetUp(); BrowserWithTestWindowTest::SetUp();

@ -60,7 +60,7 @@ class DownloadStartedAnimationViews : public gfx::LinearAnimation,
DownloadStartedAnimationViews::DownloadStartedAnimationViews( DownloadStartedAnimationViews::DownloadStartedAnimationViews(
content::WebContents* web_contents) content::WebContents* web_contents)
: gfx::LinearAnimation(kMoveTime, kFrameRateHz, NULL), popup_(NULL) { : gfx::LinearAnimation(kMoveTime, kFrameRateHz, nullptr), popup_(nullptr) {
gfx::ImageSkia download_image = gfx::ImageSkia download_image =
gfx::CreateVectorIcon(kFileDownloadShelfIcon, 72, gfx::kGoogleBlue500); gfx::CreateVectorIcon(kFileDownloadShelfIcon, 72, gfx::kGoogleBlue500);

@ -21,13 +21,10 @@ const char kClipboardFormatString[] = "chromium/x-browser-actions";
} }
BrowserActionDragData::BrowserActionDragData() BrowserActionDragData::BrowserActionDragData()
: profile_(NULL), index_(static_cast<size_t>(-1)) { : profile_(nullptr), index_(static_cast<size_t>(-1)) {}
}
BrowserActionDragData::BrowserActionDragData( BrowserActionDragData::BrowserActionDragData(const std::string& id, int index)
const std::string& id, int index) : profile_(nullptr), id_(id), index_(index) {}
: profile_(NULL), id_(id), index_(index) {
}
bool BrowserActionDragData::GetDropFormats( bool BrowserActionDragData::GetDropFormats(
std::set<ui::ClipboardFormatType>* format_types) { std::set<ui::ClipboardFormatType>* format_types) {

@ -25,8 +25,7 @@ aura::Window* GetTopmostTransientParent(aura::Window* window) {
JavascriptAppModalEventBlockerX11::JavascriptAppModalEventBlockerX11( JavascriptAppModalEventBlockerX11::JavascriptAppModalEventBlockerX11(
aura::Window* modal_window) aura::Window* modal_window)
: modal_window_(modal_window), : modal_window_(modal_window), browser_view_with_modal_dialog_(nullptr) {
browser_view_with_modal_dialog_(NULL) {
aura::Window* topmost_transient_parent = aura::Window* topmost_transient_parent =
GetTopmostTransientParent(modal_window); GetTopmostTransientParent(modal_window);
browser_view_with_modal_dialog_ = browser_view_with_modal_dialog_ =

@ -46,7 +46,7 @@ class SSLClientCertificateSelectorTest : public InProcessBrowserTest {
: io_loop_finished_event_( : io_loop_finished_event_(
base::WaitableEvent::ResetPolicy::AUTOMATIC, base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED), base::WaitableEvent::InitialState::NOT_SIGNALED),
selector_(NULL) {} selector_(nullptr) {}
void SetUpInProcessBrowserTestFixture() override { void SetUpInProcessBrowserTestFixture() override {
base::FilePath certs_dir = net::GetTestCertsDirectory(); base::FilePath certs_dir = net::GetTestCertsDirectory();

@ -398,8 +398,8 @@ TabDragController::TabDragController()
was_source_maximized_(false), was_source_maximized_(false),
was_source_fullscreen_(false), was_source_fullscreen_(false),
did_restore_window_(false), did_restore_window_(false),
tab_strip_to_attach_to_after_exit_(NULL), tab_strip_to_attach_to_after_exit_(nullptr),
move_loop_widget_(NULL), move_loop_widget_(nullptr),
is_mutating_(false), is_mutating_(false),
attach_x_(-1), attach_x_(-1),
attach_index_(-1) { attach_index_(-1) {

@ -45,9 +45,8 @@ struct CustomHomePagesTableModel::Entry {
CustomHomePagesTableModel::CustomHomePagesTableModel(Profile* profile) CustomHomePagesTableModel::CustomHomePagesTableModel(Profile* profile)
: profile_(profile), : profile_(profile),
observer_(NULL), observer_(nullptr),
num_outstanding_title_lookups_(0) { num_outstanding_title_lookups_(0) {}
}
CustomHomePagesTableModel::~CustomHomePagesTableModel() { CustomHomePagesTableModel::~CustomHomePagesTableModel() {
} }

@ -153,7 +153,7 @@ std::unique_ptr<base::CommandLine> CreateServiceProcessCommandLine() {
return command_line; return command_line;
} }
ServiceProcessState::ServiceProcessState() : state_(NULL) { ServiceProcessState::ServiceProcessState() : state_(nullptr) {
autorun_command_line_ = CreateServiceProcessCommandLine(); autorun_command_line_ = CreateServiceProcessCommandLine();
CreateState(); CreateState();
} }

@ -171,7 +171,7 @@ class NetErrorHelperCoreTest : public testing::Test,
public NetErrorHelperCore::Delegate { public NetErrorHelperCore::Delegate {
public: public:
NetErrorHelperCoreTest() NetErrorHelperCoreTest()
: timer_(NULL), : timer_(nullptr),
update_count_(0), update_count_(0),
error_html_update_count_(0), error_html_update_count_(0),
reload_count_(0), reload_count_(0),

@ -129,7 +129,7 @@ CloudPrintURLFetcher::Delegate::HandleJSONData(const net::URLFetcher* source,
CloudPrintURLFetcher::CloudPrintURLFetcher( CloudPrintURLFetcher::CloudPrintURLFetcher(
const net::PartialNetworkTrafficAnnotationTag& partial_traffic_annotation) const net::PartialNetworkTrafficAnnotationTag& partial_traffic_annotation)
: delegate_(NULL), : delegate_(nullptr),
num_retries_(0), num_retries_(0),
type_(REQUEST_MAX), type_(REQUEST_MAX),
partial_traffic_annotation_(partial_traffic_annotation) {} partial_traffic_annotation_(partial_traffic_annotation) {}

@ -630,20 +630,19 @@ void PrinterJobHandlerTest::TearDown() {
CloudPrintURLFetcher::set_test_factory(nullptr); CloudPrintURLFetcher::set_test_factory(nullptr);
} }
MockPrintServerWatcher::MockPrintServerWatcher() : delegate_(NULL) { MockPrintServerWatcher::MockPrintServerWatcher() : delegate_(nullptr) {
ON_CALL(*this, StartWatching(_)) ON_CALL(*this, StartWatching(_))
.WillByDefault(DoAll(SaveArg<0>(&delegate_), Return(true))); .WillByDefault(DoAll(SaveArg<0>(&delegate_), Return(true)));
ON_CALL(*this, StopWatching()).WillByDefault(Return(true)); ON_CALL(*this, StopWatching()).WillByDefault(Return(true));
} }
MockPrinterWatcher::MockPrinterWatcher() : delegate_(nullptr) {
MockPrinterWatcher::MockPrinterWatcher() : delegate_(NULL) {
ON_CALL(*this, StartWatching(_)) ON_CALL(*this, StartWatching(_))
.WillByDefault(DoAll(SaveArg<0>(&delegate_), Return(true))); .WillByDefault(DoAll(SaveArg<0>(&delegate_), Return(true)));
ON_CALL(*this, StopWatching()).WillByDefault(Return(true)); ON_CALL(*this, StopWatching()).WillByDefault(Return(true));
} }
MockJobSpooler::MockJobSpooler() : delegate_(NULL) { MockJobSpooler::MockJobSpooler() : delegate_(nullptr) {
ON_CALL(*this, Spool(_, _, _, _, _, _, _, _)) ON_CALL(*this, Spool(_, _, _, _, _, _, _, _))
.WillByDefault(DoAll(SaveArg<7>(&delegate_), Return(true))); .WillByDefault(DoAll(SaveArg<7>(&delegate_), Return(true)));
} }

@ -86,7 +86,7 @@ DevToolsClientImpl::DevToolsClientImpl(const SyncWebSocketFactory& factory,
id_(id), id_(id),
frontend_closer_func_(base::Bind(&FakeCloseFrontends)), frontend_closer_func_(base::Bind(&FakeCloseFrontends)),
parser_func_(base::Bind(&internal::ParseInspectorMessage)), parser_func_(base::Bind(&internal::ParseInspectorMessage)),
unnotified_event_(NULL), unnotified_event_(nullptr),
next_id_(1), next_id_(1),
stack_count_(0) { stack_count_(0) {
socket_->SetId(id_); socket_->SetId(id_);
@ -106,7 +106,7 @@ DevToolsClientImpl::DevToolsClientImpl(
id_(id), id_(id),
frontend_closer_func_(frontend_closer_func), frontend_closer_func_(frontend_closer_func),
parser_func_(base::Bind(&internal::ParseInspectorMessage)), parser_func_(base::Bind(&internal::ParseInspectorMessage)),
unnotified_event_(NULL), unnotified_event_(nullptr),
next_id_(1), next_id_(1),
stack_count_(0) { stack_count_(0) {
socket_->SetId(id_); socket_->SetId(id_);
@ -122,7 +122,7 @@ DevToolsClientImpl::DevToolsClientImpl(DevToolsClientImpl* parent,
id_(session_id), id_(session_id),
frontend_closer_func_(base::BindRepeating(&FakeCloseFrontends)), frontend_closer_func_(base::BindRepeating(&FakeCloseFrontends)),
parser_func_(base::BindRepeating(&internal::ParseInspectorMessage)), parser_func_(base::BindRepeating(&internal::ParseInspectorMessage)),
unnotified_event_(NULL), unnotified_event_(nullptr),
next_id_(1), next_id_(1),
stack_count_(0) { stack_count_(0) {
parent->children_[session_id] = this; parent->children_[session_id] = this;
@ -143,7 +143,7 @@ DevToolsClientImpl::DevToolsClientImpl(
id_(id), id_(id),
frontend_closer_func_(frontend_closer_func), frontend_closer_func_(frontend_closer_func),
parser_func_(parser_func), parser_func_(parser_func),
unnotified_event_(NULL), unnotified_event_(nullptr),
next_id_(1), next_id_(1),
stack_count_(0) { stack_count_(0) {
socket_->SetId(id_); socket_->SetId(id_);

@ -86,7 +86,7 @@ namespace {
class FakeDevToolsClient : public StubDevToolsClient { class FakeDevToolsClient : public StubDevToolsClient {
public: public:
FakeDevToolsClient() : listener_(NULL), closing_count_(0) {} FakeDevToolsClient() : listener_(nullptr), closing_count_(0) {}
~FakeDevToolsClient() override {} ~FakeDevToolsClient() override {}
void set_closing_count(int closing_count) { void set_closing_count(int closing_count) {

@ -11,8 +11,7 @@
NetworkConditionsOverrideManager::NetworkConditionsOverrideManager( NetworkConditionsOverrideManager::NetworkConditionsOverrideManager(
DevToolsClient* client) DevToolsClient* client)
: client_(client), : client_(client), overridden_network_conditions_(nullptr) {
overridden_network_conditions_(NULL) {
client_->AddListener(this); client_->AddListener(this);
} }

@ -70,7 +70,7 @@ class MockHandler : public ImageWriterHandler {
// the write completes. // the write completes.
class VerifyingHandler : public MockHandler { class VerifyingHandler : public MockHandler {
public: public:
VerifyingHandler() : image_writer_(NULL), verified_(false) {} VerifyingHandler() : image_writer_(nullptr), verified_(false) {}
void SendSucceeded() override { void SendSucceeded() override {
MockHandler::SendSucceeded(); MockHandler::SendSucceeded();

@ -14,7 +14,7 @@
#include "base/strings/sys_string_conversions.h" #include "base/strings/sys_string_conversions.h"
#include "crypto/nss_util.h" #include "crypto/nss_util.h"
NSSDecryptor::NSSDecryptor() : is_nss_initialized_(false), db_slot_(NULL) {} NSSDecryptor::NSSDecryptor() : is_nss_initialized_(false), db_slot_(nullptr) {}
NSSDecryptor::~NSSDecryptor() { NSSDecryptor::~NSSDecryptor() {
if (db_slot_) { if (db_slot_) {
// Deliberately leave the user db open, just in case we need to open more // Deliberately leave the user db open, just in case we need to open more

@ -58,7 +58,7 @@ class NaClFileHostTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(NaClFileHostTest); DISALLOW_COPY_AND_ASSIGN(NaClFileHostTest);
}; };
NaClFileHostTest::NaClFileHostTest() : nacl_browser_delegate_(NULL) {} NaClFileHostTest::NaClFileHostTest() : nacl_browser_delegate_(nullptr) {}
NaClFileHostTest::~NaClFileHostTest() { NaClFileHostTest::~NaClFileHostTest() {
} }

@ -222,7 +222,7 @@ NaClProcessHost::NaClProcessHost(
#if defined(OS_WIN) #if defined(OS_WIN)
process_launched_by_broker_(false), process_launched_by_broker_(false),
#endif #endif
reply_msg_(NULL), reply_msg_(nullptr),
#if defined(OS_WIN) #if defined(OS_WIN)
debug_exception_handler_requested_(false), debug_exception_handler_requested_(false),
#endif #endif

@ -81,14 +81,13 @@ PnaclHost* PnaclHost::GetInstance() {
PnaclHost::PendingTranslation::PendingTranslation() PnaclHost::PendingTranslation::PendingTranslation()
: process_handle(base::kNullProcessHandle), : process_handle(base::kNullProcessHandle),
render_view_id(0), render_view_id(0),
nexe_fd(NULL), nexe_fd(nullptr),
got_nexe_fd(false), got_nexe_fd(false),
got_cache_reply(false), got_cache_reply(false),
got_cache_hit(false), got_cache_hit(false),
is_incognito(false), is_incognito(false),
callback(NexeFdCallback()), callback(NexeFdCallback()),
cache_info(nacl::PnaclCacheInfo()) { cache_info(nacl::PnaclCacheInfo()) {}
}
PnaclHost::PendingTranslation::PendingTranslation( PnaclHost::PendingTranslation::PendingTranslation(
const PendingTranslation& other) = default; const PendingTranslation& other) = default;

@ -36,7 +36,7 @@ const size_t kBufferSize = 16u;
class PnaclHostTest : public testing::Test { class PnaclHostTest : public testing::Test {
protected: protected:
PnaclHostTest() PnaclHostTest()
: host_(NULL), : host_(nullptr),
temp_callback_count_(0), temp_callback_count_(0),
write_callback_count_(0), write_callback_count_(0),
task_environment_(content::BrowserTaskEnvironment::IO_MAINLOOP) {} task_environment_(content::BrowserTaskEnvironment::IO_MAINLOOP) {}

@ -145,7 +145,7 @@ PnaclTranslationCacheEntry::PnaclTranslationCacheEntry(
bool is_read) bool is_read)
: cache_(cache), : cache_(cache),
key_(key), key_(key),
entry_(NULL), entry_(nullptr),
step_(UNINITIALIZED), step_(UNINITIALIZED),
is_read_(is_read) {} is_read_(is_read) {}

@ -59,18 +59,18 @@ void GetSubzeroCommandLine(std::vector<std::string>* args,
} // namespace } // namespace
PnaclTranslateThread::PnaclTranslateThread() PnaclTranslateThread::PnaclTranslateThread()
: compiler_subprocess_(NULL), : compiler_subprocess_(nullptr),
ld_subprocess_(NULL), ld_subprocess_(nullptr),
compiler_subprocess_active_(false), compiler_subprocess_active_(false),
ld_subprocess_active_(false), ld_subprocess_active_(false),
buffer_cond_(&cond_mu_), buffer_cond_(&cond_mu_),
done_(false), done_(false),
compile_time_(0), compile_time_(0),
obj_files_(NULL), obj_files_(nullptr),
num_threads_(0), num_threads_(0),
nexe_file_(NULL), nexe_file_(nullptr),
coordinator_error_info_(NULL), coordinator_error_info_(nullptr),
coordinator_(NULL) {} coordinator_(nullptr) {}
void PnaclTranslateThread::SetupState( void PnaclTranslateThread::SetupState(
const pp::CompletionCallback& finish_callback, const pp::CompletionCallback& finish_callback,

@ -14,8 +14,7 @@ using ppapi::PpapiGlobals;
PnaclTranslationResourceHost::PnaclTranslationResourceHost( PnaclTranslationResourceHost::PnaclTranslationResourceHost(
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner) scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
: io_task_runner_(io_task_runner), sender_(NULL) { : io_task_runner_(io_task_runner), sender_(nullptr) {}
}
PnaclTranslationResourceHost::~PnaclTranslationResourceHost() { PnaclTranslationResourceHost::~PnaclTranslationResourceHost() {
DCHECK(io_task_runner_->BelongsToCurrentThread()); DCHECK(io_task_runner_->BelongsToCurrentThread());

@ -71,7 +71,7 @@ void FlushProfilingData(base::Thread* thread) {
class ProfilingThreadControl { class ProfilingThreadControl {
public: public:
ProfilingThreadControl() : thread_(NULL) {} ProfilingThreadControl() : thread_(nullptr) {}
void Start() { void Start() {
base::AutoLock locked(lock_); base::AutoLock locked(lock_);

@ -97,7 +97,7 @@ void AddDeviceFilterWithUUID(BluetoothDiscoveryFilter* filter,
class BluetoothGattBlueZTest : public testing::Test { class BluetoothGattBlueZTest : public testing::Test {
public: public:
BluetoothGattBlueZTest() BluetoothGattBlueZTest()
: fake_bluetooth_gatt_service_client_(NULL), : fake_bluetooth_gatt_service_client_(nullptr),
success_callback_count_(0), success_callback_count_(0),
error_callback_count_(0) {} error_callback_count_(0) {}

@ -42,7 +42,7 @@ const int RulesRegistryService::kInvalidRulesRegistryID = -1;
RulesRegistryService::RulesRegistryService(content::BrowserContext* context) RulesRegistryService::RulesRegistryService(content::BrowserContext* context)
: current_rules_registry_id_(kDefaultRulesRegistryID), : current_rules_registry_id_(kDefaultRulesRegistryID),
content_rules_registry_(NULL), content_rules_registry_(nullptr),
browser_context_(context) { browser_context_(context) {
if (browser_context_) { if (browser_context_) {
extension_registry_observer_.Add(ExtensionRegistry::Get(browser_context_)); extension_registry_observer_.Add(ExtensionRegistry::Get(browser_context_));

@ -135,7 +135,7 @@ void GetCachedNetworkPropertiesCallback(
} // namespace } // namespace
NetworkingPrivateLinux::NetworkingPrivateLinux() NetworkingPrivateLinux::NetworkingPrivateLinux()
: dbus_thread_("Networking Private DBus"), network_manager_proxy_(NULL) { : dbus_thread_("Networking Private DBus"), network_manager_proxy_(nullptr) {
base::Thread::Options thread_options(base::MessagePumpType::IO, 0); base::Thread::Options thread_options(base::MessagePumpType::IO, 0);
dbus_thread_.StartWithOptions(thread_options); dbus_thread_.StartWithOptions(thread_options);

@ -34,7 +34,7 @@ using storage_monitor::TestStorageMonitor;
class SystemStorageEjectApiTest : public extensions::ShellApiTest { class SystemStorageEjectApiTest : public extensions::ShellApiTest {
public: public:
SystemStorageEjectApiTest() : monitor_(NULL) {} SystemStorageEjectApiTest() : monitor_(nullptr) {}
~SystemStorageEjectApiTest() override {} ~SystemStorageEjectApiTest() override {}
protected: protected:

@ -129,7 +129,7 @@ void TestGetConfigFunction::set_test_config_state(
} }
TestGetConfigFunction::TestConfigState::TestConfigState() TestGetConfigFunction::TestConfigState::TestConfigState()
: config_state_(NULL) {} : config_state_(nullptr) {}
// static // static
TestGetConfigFunction::TestConfigState* TestGetConfigFunction::TestConfigState*

@ -11,8 +11,7 @@
namespace extensions { namespace extensions {
ResultCatcher::ResultCatcher() ResultCatcher::ResultCatcher() : browser_context_restriction_(nullptr) {
: browser_context_restriction_(NULL) {
registrar_.Add(this, registrar_.Add(this,
extensions::NOTIFICATION_EXTENSION_TEST_PASSED, extensions::NOTIFICATION_EXTENSION_TEST_PASSED,
content::NotificationService::AllSources()); content::NotificationService::AllSources());

@ -151,10 +151,7 @@ void ArrayBuffer::Private::SecondWeakCallback(
// ArrayBuffer ---------------------------------------------------------------- // ArrayBuffer ----------------------------------------------------------------
ArrayBuffer::ArrayBuffer() ArrayBuffer::ArrayBuffer() : bytes_(nullptr), num_bytes_(0) {}
: bytes_(0),
num_bytes_(0) {
}
ArrayBuffer::ArrayBuffer(v8::Isolate* isolate, ArrayBuffer::ArrayBuffer(v8::Isolate* isolate,
v8::Local<v8::ArrayBuffer> array) { v8::Local<v8::ArrayBuffer> array) {

@ -16,7 +16,7 @@ namespace gin {
template<typename T> template<typename T>
class Handle { class Handle {
public: public:
Handle() : object_(NULL) {} Handle() : object_(nullptr) {}
Handle(v8::Local<v8::Value> wrapper, T* object) Handle(v8::Local<v8::Value> wrapper, T* object)
: wrapper_(wrapper), : wrapper_(wrapper),

@ -11,8 +11,7 @@ namespace gin {
PerContextData::PerContextData(ContextHolder* context_holder, PerContextData::PerContextData(ContextHolder* context_holder,
v8::Local<v8::Context> context) v8::Local<v8::Context> context)
: context_holder_(context_holder), : context_holder_(context_holder), runner_(nullptr) {
runner_(NULL) {
context->SetAlignedPointerInEmbedderData( context->SetAlignedPointerInEmbedderData(
kPerContextDataStartIndex + kEmbedderNativeGin, this); kPerContextDataStartIndex + kEmbedderNativeGin, this);
} }

@ -10,7 +10,7 @@
namespace headless { namespace headless {
HeadlessFocusClient::HeadlessFocusClient() HeadlessFocusClient::HeadlessFocusClient()
: focused_window_(NULL), observer_manager_(this) {} : focused_window_(nullptr), observer_manager_(this) {}
HeadlessFocusClient::~HeadlessFocusClient() = default; HeadlessFocusClient::~HeadlessFocusClient() = default;

@ -141,8 +141,7 @@ TEST(IPCMessageIntegrity, DISABLED_ReadVectorTooLarge3) {
class SimpleListener : public IPC::Listener { class SimpleListener : public IPC::Listener {
public: public:
SimpleListener() : other_(NULL) { SimpleListener() : other_(nullptr) {}
}
void Init(IPC::Sender* s) { void Init(IPC::Sender* s) {
other_ = s; other_ = s;
} }
@ -223,8 +222,7 @@ class FuzzerServerListener : public SimpleListener {
class FuzzerClientListener : public SimpleListener { class FuzzerClientListener : public SimpleListener {
public: public:
FuzzerClientListener() : last_msg_(NULL) { FuzzerClientListener() : last_msg_(nullptr) {}
}
bool OnMessageReceived(const IPC::Message& msg) override { bool OnMessageReceived(const IPC::Message& msg) override {
last_msg_ = new IPC::Message(msg); last_msg_ = new IPC::Message(msg);

@ -48,9 +48,9 @@ Logging::Logging()
enabled_on_stderr_(false), enabled_on_stderr_(false),
enabled_color_(false), enabled_color_(false),
queue_invoke_later_pending_(false), queue_invoke_later_pending_(false),
sender_(NULL), sender_(nullptr),
main_thread_(base::ThreadTaskRunnerHandle::Get()), main_thread_(base::ThreadTaskRunnerHandle::Get()),
consumer_(NULL) { consumer_(nullptr) {
#if defined(OS_WIN) #if defined(OS_WIN)
// getenv triggers an unsafe warning. Simply check how big of a buffer // getenv triggers an unsafe warning. Simply check how big of a buffer
// would be needed to fetch the value to see if the enviornment variable is // would be needed to fetch the value to see if the enviornment variable is

@ -42,7 +42,7 @@ class PerformanceChannelListener : public Listener {
public: public:
explicit PerformanceChannelListener(const std::string& label) explicit PerformanceChannelListener(const std::string& label)
: label_(label), : label_(label),
sender_(NULL), sender_(nullptr),
msg_count_(0), msg_count_(0),
msg_size_(0), msg_size_(0),
sync_(false), sync_(false),

@ -19,7 +19,7 @@ scoped_refptr<base::SingleThreadTaskRunner> GetIOThreadTaskRunner() {
static_cast<base::SingleThreadTaskRunner*>(runner.get())); static_cast<base::SingleThreadTaskRunner*>(runner.get()));
} }
ChannelReflectorListener::ChannelReflectorListener() : channel_(NULL) { ChannelReflectorListener::ChannelReflectorListener() : channel_(nullptr) {
VLOG(1) << "Client listener up"; VLOG(1) << "Client listener up";
} }

@ -56,7 +56,7 @@ class Worker : public Listener, public Sender {
mode_(mode), mode_(mode),
ipc_thread_((thread_name + "_ipc").c_str()), ipc_thread_((thread_name + "_ipc").c_str()),
listener_thread_((thread_name + "_listener").c_str()), listener_thread_((thread_name + "_listener").c_str()),
overrided_thread_(NULL), overrided_thread_(nullptr),
shutdown_event_(base::WaitableEvent::ResetPolicy::MANUAL, shutdown_event_(base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED), base::WaitableEvent::InitialState::NOT_SIGNALED),
is_shutdown_(false) {} is_shutdown_(false) {}
@ -73,7 +73,7 @@ class Worker : public Listener, public Sender {
mode_(mode), mode_(mode),
ipc_thread_("ipc thread"), ipc_thread_("ipc thread"),
listener_thread_("listener thread"), listener_thread_("listener thread"),
overrided_thread_(NULL), overrided_thread_(nullptr),
shutdown_event_(base::WaitableEvent::ResetPolicy::MANUAL, shutdown_event_(base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED), base::WaitableEvent::InitialState::NOT_SIGNALED),
is_shutdown_(false) {} is_shutdown_(false) {}
@ -1770,7 +1770,8 @@ class ReentrantReplyServer1 : public Worker {
class ReentrantReplyServer2 : public Worker { class ReentrantReplyServer2 : public Worker {
public: public:
ReentrantReplyServer2(mojo::ScopedMessagePipeHandle channel_handle) ReentrantReplyServer2(mojo::ScopedMessagePipeHandle channel_handle)
: Worker(std::move(channel_handle), Channel::MODE_SERVER), reply_(NULL) {} : Worker(std::move(channel_handle), Channel::MODE_SERVER),
reply_(nullptr) {}
private: private:
bool OnMessageReceived(const Message& message) override { bool OnMessageReceived(const Message& message) override {

@ -21,7 +21,7 @@ class TestChannelListener : public Listener {
static const size_t kLongMessageStringNumBytes = 50000; static const size_t kLongMessageStringNumBytes = 50000;
static void SendOneMessage(Sender* sender, const char* text); static void SendOneMessage(Sender* sender, const char* text);
TestChannelListener() : sender_(NULL), messages_left_(50) {} TestChannelListener() : sender_(nullptr), messages_left_(50) {}
~TestChannelListener() override {} ~TestChannelListener() override {}
bool OnMessageReceived(const Message& message) override; bool OnMessageReceived(const Message& message) override;

@ -57,8 +57,7 @@ const size_t kHelloStringLength = base::size(kHelloString);
// messages from the client. // messages from the client.
class SyncSocketServerListener : public IPC::Listener { class SyncSocketServerListener : public IPC::Listener {
public: public:
SyncSocketServerListener() : chan_(NULL) { SyncSocketServerListener() : chan_(nullptr) {}
}
void Init(IPC::Channel* chan) { void Init(IPC::Channel* chan) {
chan_ = chan; chan_ = chan;

@ -80,9 +80,7 @@ class ThreadWrapperTest : public testing::Test {
} }
protected: protected:
ThreadWrapperTest() ThreadWrapperTest() : thread_(nullptr) {}
: thread_(NULL) {
}
void SetUp() override { void SetUp() override {
JingleThreadWrapper::EnsureForCurrentMessageLoop(); JingleThreadWrapper::EnsureForCurrentMessageLoop();

@ -26,7 +26,7 @@ namespace {
class NonBlockingPushClientTest : public testing::Test { class NonBlockingPushClientTest : public testing::Test {
protected: protected:
NonBlockingPushClientTest() : fake_push_client_(NULL) {} NonBlockingPushClientTest() : fake_push_client_(nullptr) {}
~NonBlockingPushClientTest() override {} ~NonBlockingPushClientTest() override {}

@ -33,7 +33,7 @@ AudioOutputDevice::AudioOutputDevice(
const AudioSinkParameters& sink_params, const AudioSinkParameters& sink_params,
base::TimeDelta authorization_timeout) base::TimeDelta authorization_timeout)
: io_task_runner_(io_task_runner), : io_task_runner_(io_task_runner),
callback_(NULL), callback_(nullptr),
ipc_(std::move(ipc)), ipc_(std::move(ipc)),
state_(IDLE), state_(IDLE),
session_id_(sink_params.session_id), session_id_(sink_params.session_id),

Some files were not shown because too many files have changed in this diff Show More