0

[Credentialless] Fix flakes about iframeTest.js

In the various tests, there are up to 8 <iframe> navigating concurrently.

There are no ways to detect an <iframe> fails to load other than using
a timeout. See https://github.com/whatwg/html/issues/125.

The 3000ms timeout was sometimes too short. This cause flakes.
To reduce the rate of false positive, the timeout has been increased to
6000ms.

R: titouan@chromium.org
CC: lyf@chromium.org
Fixed: 1215956
Bug: 1175099
Change-Id: I7bedccb351ff62d55b6020403aac5457608e5497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944929
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890171}
This commit is contained in:
arthursonzogni
2021-06-08 09:32:09 +00:00
committed by Chromium LUCI CQ
parent 06a906eed5
commit cad80cd16f
2 changed files with 1 additions and 4 deletions
third_party/blink/web_tests
TestExpectations
external
wpt
html
cross-origin-embedder-policy
credentialless
resources

@@ -3547,9 +3547,6 @@ crbug.com/626703 external/wpt/css/vendor-imports/mozilla/mozilla-central-reftest
crbug.com/626703 external/wpt/encoding/eof-utf-8-three.html [ Failure ]
crbug.com/626703 external/wpt/encoding/eof-utf-8-two.html [ Failure ]
crbug.com/626703 external/wpt/html/browsers/windows/noreferrer-window-name.html [ Timeout ]
crbug.com/1215956 [ Linux ] external/wpt/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.tentative.https.html [ Pass Failure ]
crbug.com/1215956 [ Linux ] external/wpt/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.html [ Pass Failure ]
crbug.com/1215956 [ Linux ] external/wpt/html/cross-origin-embedder-policy/credentialless/iframe-coep-none.tentative.https.html [ Pass Failure ]
crbug.com/626703 external/wpt/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-04.html [ Failure ]
crbug.com/626703 external/wpt/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ Failure ]
crbug.com/626703 external/wpt/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-menu.html [ Failure ]

@@ -61,7 +61,7 @@ const iframeTest = function(
// There are no interoperable ways to check an iframe failed to load. So a
// timeout is being used.
// See https://github.com/whatwg/html/issues/125
step_timeout(()=>send(test_token, "block"), 3000);
step_timeout(()=>send(test_token, "block"), 6000);
assert_equals(await receive(test_token), expectation);
}, description);