0

Fix 'gn check' errors in //ui/* targets.

Tested with the following configs:

Linux:
$ gn gen out_gn/Debug
$ gn check out_gn/Debug

Android:
$ gn gen --args='os="android" cpu_arch="arm"' out_gn_android/Debug
$ gn check out_gn_android/Debug

Chromeos:
$ gn gen --args='os="chromeos"' out_gn_chromeos/Debug
$ gn check out_gn_chromeos/Debug

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/872243004

Cr-Commit-Position: refs/heads/master@{#314102}
This commit is contained in:
tfarina
2015-02-01 18:55:42 -08:00
committed by Commit bot
parent db8a11edfe
commit cb1ffc60dc
13 changed files with 34 additions and 7 deletions
.gn
ui
app_list
base
chromeos
compositor
display
gfx
snapshot
views_content_client
web_dialogs

2
.gn

@@ -14,4 +14,4 @@ secondary_source = "//build/secondary/"
# matching these patterns (see "gn help label_pattern" for format) will have # matching these patterns (see "gn help label_pattern" for format) will have
# their includes checked for proper dependencies when you run either # their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check". # "gn check" or "gn gen --check".
check_targets = [ "//cc" ] check_targets = [ "//cc/*" ]

@@ -243,6 +243,7 @@ test("app_list_unittests") {
"//ui/base", "//ui/base",
"//ui/compositor", "//ui/compositor",
"//ui/events", "//ui/events",
"//ui/events:test_support",
"//ui/gl", "//ui/gl",
"//ui/resources", "//ui/resources",
"//ui/resources:ui_test_pak", "//ui/resources:ui_test_pak",

@@ -19,7 +19,6 @@
#include "ui/app_list/views/contents_view.h" #include "ui/app_list/views/contents_view.h"
#include "ui/app_list/views/search_box_view.h" #include "ui/app_list/views/search_box_view.h"
#include "ui/app_list/views/test/apps_grid_view_test_api.h" #include "ui/app_list/views/test/apps_grid_view_test_api.h"
#include "ui/aura/window.h"
#include "ui/events/test/event_generator.h" #include "ui/events/test/event_generator.h"
#include "ui/views/test/views_test_base.h" #include "ui/views/test/views_test_base.h"
#include "ui/views/view_model.h" #include "ui/views/view_model.h"

@@ -26,7 +26,6 @@ component("base") {
"accelerators/platform_accelerator.h", "accelerators/platform_accelerator.h",
"accelerators/platform_accelerator_cocoa.h", "accelerators/platform_accelerator_cocoa.h",
"accelerators/platform_accelerator_cocoa.mm", "accelerators/platform_accelerator_cocoa.mm",
"android/system_ui_resource_type.h",
"android/ui_base_jni_registrar.cc", "android/ui_base_jni_registrar.cc",
"android/ui_base_jni_registrar.h", "android/ui_base_jni_registrar.h",
"android/view_android.cc", "android/view_android.cc",
@@ -307,6 +306,7 @@ component("base") {
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
"//base:base_static", "//base:base_static",
"//base:i18n", "//base:i18n",
"//cc",
"//net", "//net",
"//third_party/icu", "//third_party/icu",
"//ui/events", "//ui/events",
@@ -425,7 +425,10 @@ component("base") {
} }
if (is_chromeos) { if (is_chromeos) {
deps += [ "//chromeos" ] deps += [
"//chromeos",
"//chromeos/ime:gencode",
]
if (!use_ozone) { if (!use_ozone) {
sources -= [ sources -= [
"ime/chromeos/ime_keyboard_ozone.cc", "ime/chromeos/ime_keyboard_ozone.cc",
@@ -925,7 +928,10 @@ test("ui_base_unittests") {
} }
if (is_chromeos) { if (is_chromeos) {
deps += [ "//chromeos" ] deps += [
"//chromeos",
"//ui/events:dom4_keycode_converter",
]
} }
} }
# TODO(GYP) Mac (ui_base_tests_bundle) # TODO(GYP) Mac (ui_base_tests_bundle)

@@ -50,7 +50,6 @@
'accelerators/platform_accelerator.h', 'accelerators/platform_accelerator.h',
'accelerators/platform_accelerator_cocoa.h', 'accelerators/platform_accelerator_cocoa.h',
'accelerators/platform_accelerator_cocoa.mm', 'accelerators/platform_accelerator_cocoa.mm',
'android/system_ui_resource_type.h',
'android/ui_base_jni_registrar.cc', 'android/ui_base_jni_registrar.cc',
'android/ui_base_jni_registrar.h', 'android/ui_base_jni_registrar.h',
'android/view_android.cc', 'android/view_android.cc',

@@ -38,6 +38,7 @@ component("ui_chromeos") {
"user_activity_power_manager_notifier.cc", "user_activity_power_manager_notifier.cc",
"user_activity_power_manager_notifier.h", "user_activity_power_manager_notifier.h",
] ]
defines = [ "UI_CHROMEOS_IMPLEMENTATION" ]
deps = [ deps = [
"//base", "//base",
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
@@ -53,10 +54,10 @@ component("ui_chromeos") {
"//ui/gfx", "//ui/gfx",
"//ui/gfx/geometry", "//ui/gfx/geometry",
"//ui/message_center", "//ui/message_center",
"//ui/native_theme",
"//ui/views", "//ui/views",
"//ui/wm", "//ui/wm",
] ]
defines = [ "UI_CHROMEOS_IMPLEMENTATION" ]
} }
test("ui_chromeos_unittests") { test("ui_chromeos_unittests") {
@@ -77,6 +78,8 @@ test("ui_chromeos_unittests") {
"//testing/gtest", "//testing/gtest",
"//ui/aura:test_support", "//ui/aura:test_support",
"//ui/compositor", "//ui/compositor",
"//ui/events:test_support",
"//ui/gl",
"//ui/message_center", "//ui/message_center",
"//ui/resources:ui_test_pak", "//ui/resources:ui_test_pak",
"//ui/views", "//ui/views",

@@ -115,6 +115,11 @@ source_set("test_support") {
"//cc", "//cc",
"//cc/surfaces", "//cc/surfaces",
"//cc:test_support", "//cc:test_support",
"//gpu/command_buffer/client:gl_in_process_context",
"//gpu/command_buffer/client:gles2_c_lib",
"//gpu/command_buffer/client:gles2_implementation",
"//gpu/command_buffer/common:gles2_utils",
"//gpu/skia_bindings",
"//skia", "//skia",
"//testing/gtest", "//testing/gtest",
"//third_party/WebKit/public:blink_minimal", "//third_party/WebKit/public:blink_minimal",

@@ -120,6 +120,7 @@ source_set("test_support") {
] ]
deps = [ deps = [
"//base", "//base",
"//ui/display/types",
"//ui/gfx", "//ui/gfx",
"//ui/gfx/geometry", "//ui/gfx/geometry",
] ]
@@ -149,6 +150,7 @@ test("display_unittests") {
deps += [ deps += [
":display", ":display",
":test_support", ":test_support",
"//base/test:test_support",
"//ui/display/types", "//ui/display/types",
] ]
} }

@@ -222,6 +222,7 @@ component("gfx") {
deps = [ deps = [
":gfx_export", ":gfx_export",
"//base",
"//base:i18n", "//base:i18n",
"//base:base_static", "//base:base_static",
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",

@@ -17,5 +17,6 @@ component("ipc") {
"//ipc", "//ipc",
"//skia", "//skia",
"//ui/gfx", "//ui/gfx",
"//ui/gfx/geometry",
] ]
} }

@@ -67,6 +67,7 @@ test("snapshot_unittests") {
"//skia", "//skia",
"//testing/gtest", "//testing/gtest",
"//ui/base", "//ui/base",
"//ui/compositor:test_support",
"//ui/gfx", "//ui/gfx",
"//ui/gfx/geometry", "//ui/gfx/geometry",
"//ui/gl", "//ui/gl",

@@ -50,4 +50,11 @@ component("views_content_client") {
deps += [ "//ui/aura" ] deps += [ "//ui/aura" ]
} }
if (is_chromeos) {
deps += [
"//ui/aura:test_support",
"//ui/wm:test_support",
]
}
} }

@@ -23,6 +23,7 @@ component("web_dialogs") {
"//skia", "//skia",
"//ui/base", "//ui/base",
"//url", "//url",
"//third_party/WebKit/public:blink_minimal",
] ]
} }
@@ -41,6 +42,7 @@ static_library("test_support") {
"//base", "//base",
"//content/public/browser", "//content/public/browser",
"//skia", "//skia",
"//ui/gfx/geometry",
"//url", "//url",
] ]
} }