chromium/src
0
Fork 0
Code Activity

Support html translate=no on iOS

Browse Source 
Bug: 414508113
Change-Id: Ie0b462fbd202ce6537e6c475a3f7262701b741b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513508
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1456978}
This commit is contained in:
Olivier ROBIN
2025-05-07 07:15:31 -07:00
committed by Chromium LUCI CQ
parent b4b19378dc
commit cfc38c0f57
2 changed files with 45 additions and 1 deletions

37
components/language/ios/browser/language_detection_javascript_unittest.mm

@@ -209,6 +209,43 @@ TEST_F(LanguageDetectionJavascriptTest, DetectLanguageWithNoTranslateMeta) {
[handler().lastReceivedMessage.body[@"hasNoTranslate"] boolValue]); [handler().lastReceivedMessage.body[@"hasNoTranslate"] boolValue]);
} }
// Tests if `__gCrWeb.languageDetection.detectLanguage` correctly informs the
// native side when the notranslate html attribute is specified
TEST_F(LanguageDetectionJavascriptTest, DetectLanguageWithHTMLNoTranslate) {
// A simple page using the notranslate meta tag.
NSString* html = @"<html translate='no'><head>"
@"<meta http-equiv='content-language' content='foo'>"
@"</head></html>";
LoadHtml(html);
ASSERT_TRUE(TriggerLanguageDetection());
ASSERT_TRUE(handler().lastReceivedMessage.body[@"httpContentLanguage"]);
EXPECT_NSEQ(@"foo",
handler().lastReceivedMessage.body[@"httpContentLanguage"]);
ASSERT_TRUE(handler().lastReceivedMessage.body[@"hasNoTranslate"]);
EXPECT_TRUE(
[handler().lastReceivedMessage.body[@"hasNoTranslate"] boolValue]);
}
// Tests if `__gCrWeb.languageDetection.detectLanguage` does not confuse a body
// or div language='no' for a page wide translate disabling.
TEST_F(LanguageDetectionJavascriptTest, DetectLanguageWithDIVNoTranslate) {
// A simple page using the notranslate meta tag.
NSString* html = @"<html><head>"
@"<meta http-equiv='content-language' content='foo'>"
@"</head><body translate='no'>"
@"<div translate='no'>test</div></html>";
LoadHtml(html);
ASSERT_TRUE(TriggerLanguageDetection());
ASSERT_TRUE(handler().lastReceivedMessage.body[@"httpContentLanguage"]);
EXPECT_NSEQ(@"foo",
handler().lastReceivedMessage.body[@"httpContentLanguage"]);
ASSERT_TRUE(handler().lastReceivedMessage.body[@"hasNoTranslate"]);
EXPECT_FALSE(
[handler().lastReceivedMessage.body[@"hasNoTranslate"] boolValue]);
}
// Tests if `__gCrWeb.languageDetection.detectLanguage` correctly informs the // Tests if `__gCrWeb.languageDetection.detectLanguage` correctly informs the
// native side when no notranslate meta tag is specified. // native side when no notranslate meta tag is specified.
TEST_F(LanguageDetectionJavascriptTest, DetectLanguageWithoutNoTranslateMeta) { TEST_F(LanguageDetectionJavascriptTest, DetectLanguageWithoutNoTranslateMeta) {

9
components/language/ios/browser/resources/language_detection.ts

@@ -22,9 +22,16 @@ let activeRequests = 0;
/** /**
* Searches page elements for "notranslate" meta tag. * Searches page elements for "notranslate" meta tag.
* @return true if "notranslate" meta tag is defined. * @return true if "notranslate" meta tag is defined or the translate attribute
* equal to no on html document.
*/ */
function hasNoTranslate(): boolean { function hasNoTranslate(): boolean {
if (document.documentElement.hasAttribute('translate')) {
if (document.documentElement.getAttribute('translate')!.toLowerCase() ===
'no') {
return true;
}
}
for (const metaTag of document.getElementsByTagName('meta')) { for (const metaTag of document.getElementsByTagName('meta')) {
if (metaTag.name === 'google') { if (metaTag.name === 'google') {
if (metaTag.content === 'notranslate' || if (metaTag.content === 'notranslate' ||