chromium/src
0
Fork 0
Code Activity

Disable TwoSubframesCreatePopupMenuWidgetsSimultaneously

Browse Source 
Disable SitePerProcessBrowserTest.
TwoSubframesCreatePopupMenuWidgetsSimultaneously on Linux and Chrome OS
due to flaky.

Bug: 1126165
Change-Id: I56b956c03578a1ecf55e79cead3a6f1b676a379f
Tbr: kenrb@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399307
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805077}
This commit is contained in:
Owen Min
2020-09-08 21:09:29 +00:00
committed by Commit Bot
parent 3fc5c74f81
commit d28a686fdf
1 changed files with 9 additions and 1 deletions

10
content/browser/site_per_process_browsertest.cc

@@ -8189,8 +8189,16 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessBrowserTest,
// a FrameHostMsg_ShowPopup to ask the browser to build and display the actual // a FrameHostMsg_ShowPopup to ask the browser to build and display the actual
// popup using native controls. // popup using native controls.
#if !defined(OS_MAC) && !defined(OS_ANDROID) #if !defined(OS_MAC) && !defined(OS_ANDROID)
// Disable the test due to flaky: https://crbug.com/1126165
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
#define MAYBE_TwoSubframesCreatePopupMenuWidgetsSimultaneously \
DISABLED_TwoSubframesCreatePopupMenuWidgetsSimultaneously
#else
#define MAYBE_TwoSubframesCreatePopupMenuWidgetsSimultaneously \
TwoSubframesCreatePopupMenuWidgetsSimultaneously
#endif
IN_PROC_BROWSER_TEST_P(SitePerProcessBrowserTest, IN_PROC_BROWSER_TEST_P(SitePerProcessBrowserTest,
TwoSubframesCreatePopupMenuWidgetsSimultaneously) { MAYBE_TwoSubframesCreatePopupMenuWidgetsSimultaneously) {
GURL main_url(embedded_test_server()->GetURL( GURL main_url(embedded_test_server()->GetURL(
"a.com", "/cross_site_iframe_factory.html?a(b,c)")); "a.com", "/cross_site_iframe_factory.html?a(b,c)"));
EXPECT_TRUE(NavigateToURL(shell(), main_url)); EXPECT_TRUE(NavigateToURL(shell(), main_url));