[Fontations] Re-enable on Android

Browse Source

Friendly gardeners: if you see pixel failures in
content/test/data/forms/*, please consider assigning those to me instead
of a revert. I'll provide a rebaseline quickly.

Reland and reactivate Fontations after https://crrev.com/c/6378864 got
reverted, initially for pixel differences, but also, a performance
regression was measured.

The performance regression is thought to be addressed by Skia change
https://crrev.com/665a9d27ba558d9306dec8fb5bccd8f0c2cdd7a9, rolled in
https://crrev.com/6e1e89f42a39dfff07a3e4998d42ec3a2c74a3e1 - autohinting
GlyphStyles are now pre-computed at the font level, instead of redundant
computation at the Fontations ScalerContext level.

https://crrev.com/c/6382313 re-introduced the flag but kept it
deactivated, activate it here.

Bug: chromium:405247133, chromium:370816214
Change-Id: I97cfa36d345232c688b0a6c8694692bdaafe2912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6381604
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438020}

...

This commit is contained in:

Dominik Röttsches

2025-03-26 03:29:01 -07:00

committed by Chromium LUCI CQ

parent 5544337ed2

commit d578d31086

3 changed files with 1 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

content/test/data/forms

form_controls_browsertest_button_android.pngform_controls_browsertest_dark_mode_text_selection_android.png

skia

fontations_feature.cc

BIN

content/test/data/forms/form_controls_browsertest_button_android.png

Binary file not shown.

Side by Side Swipe Overlay Before (image error) Size: 8.8 KiB After (image error) Size: 7.0 KiB

BIN

content/test/data/forms/form_controls_browsertest_dark_mode_text_selection_android.png

Binary file not shown.

Side by Side Swipe Overlay Before (image error) Size: 6.0 KiB After (image error) Size: 4.9 KiB