Add exceptions to max_cols rule.
Review URL: http://codereview.chromium.org/42019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11340 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
10
PRESUBMIT.py
10
PRESUBMIT.py
@ -64,6 +64,7 @@ def LocalChecks(input_api, output_api, max_cols=80):
|
|||||||
|
|
||||||
Note that the whole file is checked, not only the changes.
|
Note that the whole file is checked, not only the changes.
|
||||||
"""
|
"""
|
||||||
|
C_SOURCE_FILE_EXTENSIONS = ('.c', '.cc', '.cpp', '.h', '.inl')
|
||||||
cr_files = []
|
cr_files = []
|
||||||
eof_files = []
|
eof_files = []
|
||||||
results = []
|
results = []
|
||||||
@ -103,8 +104,13 @@ def LocalChecks(input_api, output_api, max_cols=80):
|
|||||||
local_errors.append(output_api.PresubmitError(
|
local_errors.append(output_api.PresubmitError(
|
||||||
'%s, line %s ends with whitespaces.' %
|
'%s, line %s ends with whitespaces.' %
|
||||||
(path, line_num)))
|
(path, line_num)))
|
||||||
# Accept lines with http:// to exceed the max_cols rule.
|
# Accept lines with http://, https:// and C #define/#pragma/#include to
|
||||||
if max_cols and len(line) > max_cols and not 'http://' in line:
|
# exceed the max_cols rule.
|
||||||
|
if (max_cols and
|
||||||
|
len(line) > max_cols and
|
||||||
|
not 'http://' in line and
|
||||||
|
not 'https://' in line and
|
||||||
|
not (line[0] == '#' and ext in C_SOURCE_FILE_EXTENSIONS)):
|
||||||
local_errors.append(output_api.PresubmitError(
|
local_errors.append(output_api.PresubmitError(
|
||||||
'%s, line %s has %s chars, please reduce to %d chars.' %
|
'%s, line %s has %s chars, please reduce to %d chars.' %
|
||||||
(path, line_num, len(line), max_cols)))
|
(path, line_num, len(line), max_cols)))
|
||||||
|
Reference in New Issue
Block a user