chromium/src
0
Fork 0
Code Activity

Try FROM_HERE without function names

Browse Source 
Looks like this saves ~140k on android-binary-size. Let's give it a go
on official builds?

Bug: 41342136
Change-Id: Ia565619b91fff9e8fdd3efdf376dbb0cdd236b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099092
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Owners-Override: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399770}
This commit is contained in:
Peter Boström
2024-12-23 05:57:14 -08:00
committed by Chromium LUCI CQ
parent a52e9bebc6
commit db43379c0d
6 changed files with 45 additions and 30 deletions

16
content/browser/web_contents/web_contents_impl.cc

@ -1167,18 +1167,10 @@ class WebContentsOfBrowserContext : public base::SupportsUserData::Data {
const std::optional<base::Location>& ownership_location =
web_contents_with_dangling_ptr_to_browser_context->ownership_location();
std::string owner;
if (ownership_location) {
if (ownership_location->has_source_info()) {
owner = std::string(ownership_location->function_name()) + "@" +
ownership_location->file_name();
} else {
owner = "no_source_info";
}
} else {
owner = "unknown";
}
SCOPED_CRASH_KEY_STRING256("shutdown", "web_contents/owner", owner);
SCOPED_CRASH_KEY_STRING256("shutdown", "web_contents/owner",
ownership_location
? ownership_location->ToString()
: std::string("unknown"));
#if BUILDFLAG(IS_ANDROID)
// On Android, also report the Java stack trace from WebContents's