fixes two restore bugs with windows with titles
1. If a window with a single tab has a user supplied title, when closing we shouldn't add the tab. Instead we should add the window. Adding the tab means we lose the title. 2. SessionService::WindowOpened should set the user title. Otherwise it won't be saved. Bug: None Test: None Change-Id: Ia2bef8a6a655eeffe5f417f5366d2a29975d8ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5763166 Reviewed-by: Elly FJ <ellyjones@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#1338487}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
f7992b62bf
commit
db85e2b6ff
@ -233,7 +233,8 @@ void TabRestoreServiceHelper::BrowserClosing(LiveTabContext* context) {
|
||||
window->tabs.push_back(std::move(tab));
|
||||
}
|
||||
|
||||
if (window->tabs.size() == 1 && window->app_name.empty()) {
|
||||
if (window->tabs.size() == 1 && window->app_name.empty() &&
|
||||
window->user_title.empty()) {
|
||||
// Short-circuit creating a Window if only 1 tab was present. This fixes
|
||||
// http://crbug.com/56744.
|
||||
AddEntry(std::move(window->tabs[0]), true, true);
|
||||
|
Reference in New Issue
Block a user