0

[//cc] Rename VizLayers base::Feature to TreesInViz

Provide added clarity as to what this base::Feature is controlling.

Bug: 369883417
Change-Id: I605ef6a2eeed289a8c0009e7c536c733e8734e37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087932
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395970}
This commit is contained in:
Colin Blundell
2024-12-13 07:57:05 -08:00
committed by Chromium LUCI CQ
parent f1b732b243
commit dc35b9ce37
5 changed files with 6 additions and 6 deletions

@@ -155,7 +155,7 @@ const base::FeatureParam<std::string> kScrollEventDispatchMode(
"mode", "mode",
kScrollEventDispatchModeDispatchScrollEventsImmediately); kScrollEventDispatchModeDispatchScrollEventsImmediately);
BASE_FEATURE(kVizLayers, "VizLayers", base::FEATURE_DISABLED_BY_DEFAULT); BASE_FEATURE(kTreesInViz, "TreesInViz", base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kSendExplicitDecodeRequestsImmediately, BASE_FEATURE(kSendExplicitDecodeRequestsImmediately,
"SendExplicitDecodeRequestsImmediately", "SendExplicitDecodeRequestsImmediately",

@@ -165,8 +165,8 @@ CC_BASE_EXPORT extern const char
CC_BASE_EXPORT extern const char CC_BASE_EXPORT extern const char
kScrollEventDispatchModeDispatchScrollEventsUntilDeadline[]; kScrollEventDispatchModeDispatchScrollEventsUntilDeadline[];
// Enables GPU-side layer trees for content rendering. // Enables Viz service-side layer trees for content rendering.
CC_BASE_EXPORT BASE_DECLARE_FEATURE(kVizLayers); CC_BASE_EXPORT BASE_DECLARE_FEATURE(kTreesInViz);
// When enabled HTMLImageElement::decode() will initiate the decode task right // When enabled HTMLImageElement::decode() will initiate the decode task right
// away rather than piggy-backing on the next BeginMainFrame. // away rather than piggy-backing on the next BeginMainFrame.

@@ -26,7 +26,7 @@
namespace cc { namespace cc {
// Viz-side counterpart to a client-side PictureLayerImpl when VizLayers is // Viz-side counterpart to a client-side PictureLayerImpl when TreesInViz is
// enabled. Clients push tiling information and tile contents from a picture // enabled. Clients push tiling information and tile contents from a picture
// layer down to Viz, and this layer uses that information to draw tile quads. // layer down to Viz, and this layer uses that information to draw tile quads.
class CC_EXPORT TileDisplayLayerImpl : public LayerImpl { class CC_EXPORT TileDisplayLayerImpl : public LayerImpl {

@@ -26,7 +26,7 @@ LayerTreeSettings::~LayerTreeSettings() = default;
bool LayerTreeSettings::UseLayerContextForDisplay() const { bool LayerTreeSettings::UseLayerContextForDisplay() const {
return use_layer_lists && !is_display_tree && return use_layer_lists && !is_display_tree &&
base::FeatureList::IsEnabled(features::kVizLayers); base::FeatureList::IsEnabled(features::kTreesInViz);
} }
SchedulerSettings LayerTreeSettings::ToSchedulerSettings() const { SchedulerSettings LayerTreeSettings::ToSchedulerSettings() const {

@@ -582,7 +582,7 @@ class VIZ_SERVICE_EXPORT CompositorFrameSinkSupport
// Region capture bounds associated with the last surface that was aggregated. // Region capture bounds associated with the last surface that was aggregated.
RegionCaptureBounds current_capture_bounds_; RegionCaptureBounds current_capture_bounds_;
// When VizLayers is enabled, this owns the display tree and forwards its // When TreesInViz is enabled, this owns the display tree and forwards its
// submitted compositor frames directly to `this`. // submitted compositor frames directly to `this`.
std::unique_ptr<LayerContextImpl> layer_context_; std::unique_ptr<LayerContextImpl> layer_context_;
bool layer_context_wants_begin_frames_ = false; bool layer_context_wants_begin_frames_ = false;