chromium/src
0
Fork 0
Code Activity

[Files app] Add Inline Sync Status feature flag

Browse Source 
Bug: b:246474388
Test: None
Change-Id: I02c3182efa117f9a2f68aa18ba54f0abcd3fd43b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3893609
Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Marcello Salomao <msalomao@google.com>
Cr-Commit-Position: refs/heads/main@{#1046664}
This commit is contained in:
Marcello Salomao
2022-09-14 00:28:47 +00:00
committed by Chromium LUCI CQ
parent 9813742203
commit dd0e6de1b9
7 changed files with 25 additions and 0 deletions

4
ash/constants/ash_features.cc

@ -757,6 +757,10 @@ const base::Feature kFilesAppExperimental{"FilesAppExperimental",
const base::Feature kFilesExtractArchive{"FilesExtractArchive",
base::FEATURE_ENABLED_BY_DEFAULT};
// Enable inline sync status in Files app.
const base::Feature kFilesInlineSyncStatus{"FilesInlineSyncStatus",
base::FEATURE_DISABLED_BY_DEFAULT};
// Enables partitioning of removable disks in file manager.
const base::Feature kFilesSinglePartitionFormat{
"FilesSinglePartitionFormat", base::FEATURE_DISABLED_BY_DEFAULT};

2
ash/constants/ash_features.h

@ -325,6 +325,8 @@ COMPONENT_EXPORT(ASH_CONSTANTS)
extern const base::Feature kFilesAppExperimental;
COMPONENT_EXPORT(ASH_CONSTANTS) extern const base::Feature kFilesExtractArchive;
COMPONENT_EXPORT(ASH_CONSTANTS)
extern const base::Feature kFilesInlineSyncStatus;
COMPONENT_EXPORT(ASH_CONSTANTS)
extern const base::Feature kFilesSinglePartitionFormat;
COMPONENT_EXPORT(ASH_CONSTANTS) extern const base::Feature kFilesTrash;
COMPONENT_EXPORT(ASH_CONSTANTS) extern const base::Feature kFilesWebDriveOffice;

3
chrome/browser/about_flags.cc

@ -5186,6 +5186,9 @@ const FeatureEntry kFeatureEntries[] = {
{"files-extract-archive", flag_descriptions::kFilesExtractArchiveName,
flag_descriptions::kFilesExtractArchiveDescription, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::features::kFilesExtractArchive)},
{"files-inline-sync-status", flag_descriptions::kFilesInlineSyncStatusName,
flag_descriptions::kFilesInlineSyncStatusDescription, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::features::kFilesInlineSyncStatus)},
{"files-filters-in-recents-v2", flag_descriptions::kFiltersInRecentsV2Name,
flag_descriptions::kFiltersInRecentsV2Description, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::features::kFiltersInRecentsV2)},

5
chrome/browser/flag-metadata.json

@ -3548,6 +3548,11 @@
"owners": [ "simmonsjosh@google.com", "benhartney@google.com", "wenbojie" ],
"expiry_milestone": 110
},
{
"name": "files-inline-sync-status",
"owners": [ "simmonsjosh@google.com", "benhartney@google.com", "msalomao" ],
"expiry_milestone": 110
},
{
"name": "files-single-partition-format",
"owners": [ "austinct", "petermarshall" ],

6
chrome/browser/flag_descriptions.cc

@ -5427,6 +5427,12 @@ const char kFilesExtractArchiveName[] = "Extract archive in Files app";
const char kFilesExtractArchiveDescription[] =
"Enable the simplified archive extraction feature in Files app";
const char kFilesInlineSyncStatusName[] =
"Enable inline sync status in Files app.";
const char kFilesInlineSyncStatusDescription[] =
"Enable displaying the sync status of each file next to its name in Files "
"app.";
const char kFilesSinglePartitionFormatName[] =
"Enable Partitioning of Removable Disks.";
const char kFilesSinglePartitionFormatDescription[] =

3
chrome/browser/flag_descriptions.h

@ -3094,6 +3094,9 @@ extern const char kFilesAppExperimentalDescription[];
extern const char kFilesExtractArchiveName[];
extern const char kFilesExtractArchiveDescription[];
extern const char kFilesInlineSyncStatusName[];
extern const char kFilesInlineSyncStatusDescription[];
extern const char kFilesSinglePartitionFormatName[];
extern const char kFilesSinglePartitionFormatDescription[];

2
tools/metrics/histograms/enums.xml

@ -59030,6 +59030,7 @@ from previous Chrome versions.
<int value="-430360431" label="disable-password-generation"/>
<int value="-428599163" label="NTPDownloadSuggestions:enabled"/>
<int value="-428556995" label="DesktopPWAsTabStripSettings:enabled"/>
<int value="-428111342" label="FilesInlineSyncStatus:enabled"/>
<int value="-428082036" label="AnimatedImageResume:disabled"/>
<int value="-427163069" label="isolation-by-default"/>
<int value="-426815606" label="HomepageTile:enabled"/>
@ -60488,6 +60489,7 @@ from previous Chrome versions.
<int value="478380451" label="BlockMigratedDefaultChromeAppSync:disabled"/>
<int value="479906041" label="RunAllFlashInAllowMode:disabled"/>
<int value="480386627" label="OmniboxPedalsBatch3:enabled"/>
<int value="480481070" label="FilesInlineSyncStatus:disabled"/>
<int value="480544447" label="NonValidatingReloadOnRefreshContentV2:enabled"/>
<int value="480677983" label="WebXRARDOMOverlay:disabled"/>
<int value="481506759" label="ServiceWorkerScriptStreaming:enabled"/>