Fix typos in mojo public bindings. s/params/writer/ All other BufferWriters in the same directory are writer. Name a BufferWriter to `params' confuse user learning mojo.
Change-Id: I2d6a9bd629d296767977574efc029e979d2c6bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097505 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#750370}
This commit is contained in:
AUTHORS
mojo/public/cpp/bindings/lib
1
AUTHORS
1
AUTHORS
@ -491,6 +491,7 @@ Joshua Lock <joshua.lock@intel.com>
|
|||||||
Joshua Roesslein <jroesslein@gmail.com>
|
Joshua Roesslein <jroesslein@gmail.com>
|
||||||
Josué Ratelle <jorat1346@gmail.com>
|
Josué Ratelle <jorat1346@gmail.com>
|
||||||
Josyula Venkat Narasimham <venkat.nj@samsung.com>
|
Josyula Venkat Narasimham <venkat.nj@samsung.com>
|
||||||
|
Joyer Huang <collger@gmail.com>
|
||||||
Juan Jose Lopez Jaimez <jj.lopezjaimez@gmail.com>
|
Juan Jose Lopez Jaimez <jj.lopezjaimez@gmail.com>
|
||||||
Juhui Lee <juhui24.lee@samsung.com>
|
Juhui Lee <juhui24.lee@samsung.com>
|
||||||
Julien Brianceau <jbriance@cisco.com>
|
Julien Brianceau <jbriance@cisco.com>
|
||||||
|
@ -120,9 +120,9 @@ bool ControlMessageHandler::Run(
|
|||||||
Message::kFlagIsResponse, 0, 0, nullptr);
|
Message::kFlagIsResponse, 0, 0, nullptr);
|
||||||
response_message.set_request_id(message->request_id());
|
response_message.set_request_id(message->request_id());
|
||||||
interface_control::internal::RunResponseMessageParams_Data::BufferWriter
|
interface_control::internal::RunResponseMessageParams_Data::BufferWriter
|
||||||
response_params;
|
response_writer;
|
||||||
Serialize<interface_control::RunResponseMessageParamsDataView>(
|
Serialize<interface_control::RunResponseMessageParamsDataView>(
|
||||||
response_params_ptr, response_message.payload_buffer(), &response_params,
|
response_params_ptr, response_message.payload_buffer(), &response_writer,
|
||||||
&context_);
|
&context_);
|
||||||
ignore_result(responder->Accept(&response_message));
|
ignore_result(responder->Accept(&response_message));
|
||||||
return true;
|
return true;
|
||||||
|
@ -82,9 +82,9 @@ void SendRunMessage(InterfaceEndpointClient* endpoint,
|
|||||||
Message::kFlagExpectsResponse, 0, 0, nullptr);
|
Message::kFlagExpectsResponse, 0, 0, nullptr);
|
||||||
message.set_heap_profiler_tag(kMessageTag);
|
message.set_heap_profiler_tag(kMessageTag);
|
||||||
SerializationContext context;
|
SerializationContext context;
|
||||||
interface_control::internal::RunMessageParams_Data::BufferWriter params;
|
interface_control::internal::RunMessageParams_Data::BufferWriter writer;
|
||||||
Serialize<interface_control::RunMessageParamsDataView>(
|
Serialize<interface_control::RunMessageParamsDataView>(
|
||||||
params_ptr, message.payload_buffer(), ¶ms, &context);
|
params_ptr, message.payload_buffer(), &writer, &context);
|
||||||
std::unique_ptr<MessageReceiver> responder =
|
std::unique_ptr<MessageReceiver> responder =
|
||||||
std::make_unique<RunResponseForwardToCallback>(std::move(callback));
|
std::make_unique<RunResponseForwardToCallback>(std::move(callback));
|
||||||
endpoint->SendControlMessageWithResponder(&message, std::move(responder));
|
endpoint->SendControlMessageWithResponder(&message, std::move(responder));
|
||||||
@ -99,9 +99,9 @@ Message ConstructRunOrClosePipeMessage(
|
|||||||
message.set_heap_profiler_tag(kMessageTag);
|
message.set_heap_profiler_tag(kMessageTag);
|
||||||
SerializationContext context;
|
SerializationContext context;
|
||||||
interface_control::internal::RunOrClosePipeMessageParams_Data::BufferWriter
|
interface_control::internal::RunOrClosePipeMessageParams_Data::BufferWriter
|
||||||
params;
|
writer;
|
||||||
Serialize<interface_control::RunOrClosePipeMessageParamsDataView>(
|
Serialize<interface_control::RunOrClosePipeMessageParamsDataView>(
|
||||||
params_ptr, message.payload_buffer(), ¶ms, &context);
|
params_ptr, message.payload_buffer(), &writer, &context);
|
||||||
return message;
|
return message;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -25,9 +25,9 @@ Message ConstructRunOrClosePipeMessage(
|
|||||||
|
|
||||||
Message message(pipe_control::kRunOrClosePipeMessageId, 0, 0, 0, nullptr);
|
Message message(pipe_control::kRunOrClosePipeMessageId, 0, 0, 0, nullptr);
|
||||||
internal::SerializationContext context;
|
internal::SerializationContext context;
|
||||||
pipe_control::internal::RunOrClosePipeMessageParams_Data::BufferWriter params;
|
pipe_control::internal::RunOrClosePipeMessageParams_Data::BufferWriter writer;
|
||||||
internal::Serialize<pipe_control::RunOrClosePipeMessageParamsDataView>(
|
internal::Serialize<pipe_control::RunOrClosePipeMessageParamsDataView>(
|
||||||
params_ptr, message.payload_buffer(), ¶ms, &context);
|
params_ptr, message.payload_buffer(), &writer, &context);
|
||||||
message.set_interface_id(kInvalidInterfaceId);
|
message.set_interface_id(kInvalidInterfaceId);
|
||||||
message.set_heap_profiler_tag(kMessageTag);
|
message.set_heap_profiler_tag(kMessageTag);
|
||||||
message.AttachHandlesFromSerializationContext(&context);
|
message.AttachHandlesFromSerializationContext(&context);
|
||||||
|
Reference in New Issue
Block a user