chromium/src
0
Fork 0
Code Activity

[unseasoned-pdf] Remove DocumentLoader::Client::GetPluginInstance()

Browse Source 
The method isn't used anywhere.

Change-Id: Iac924adb4d57f64b81b14d3386e63014f45a20fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2949958
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892250}
This commit is contained in:
Daniel Hosseinian
2021-06-14 20:31:02 +00:00
committed by Chromium LUCI CQ
parent 03a6955844
commit e24dab686b
4 changed files with 0 additions and 12 deletions

6
pdf/document_loader.h

@@ -11,10 +11,6 @@
#include <memory> #include <memory>
#include <string> #include <string>
namespace pp {
class Instance;
}
namespace chrome_pdf { namespace chrome_pdf {
class URLLoaderWrapper; class URLLoaderWrapper;
@@ -25,8 +21,6 @@ class DocumentLoader {
public: public:
virtual ~Client() = default; virtual ~Client() = default;
// Gets the pp::Instance object.
virtual pp::Instance* GetPluginInstance() = 0;
// Creates new URLLoader based on client settings. // Creates new URLLoader based on client settings.
virtual std::unique_ptr<URLLoaderWrapper> CreateURLLoader() = 0; virtual std::unique_ptr<URLLoaderWrapper> CreateURLLoader() = 0;
// Notification called when all outstanding pending requests are complete. // Notification called when all outstanding pending requests are complete.

1
pdf/document_loader_impl_unittest.cc

@@ -200,7 +200,6 @@ class TestClient : public DocumentLoader::Client {
~TestClient() override = default; ~TestClient() override = default;
// DocumentLoader::Client overrides: // DocumentLoader::Client overrides:
pp::Instance* GetPluginInstance() override { return nullptr; }
std::unique_ptr<URLLoaderWrapper> CreateURLLoader() override { std::unique_ptr<URLLoaderWrapper> CreateURLLoader() override {
return std::unique_ptr<URLLoaderWrapper>( return std::unique_ptr<URLLoaderWrapper>(
new TestURLLoader(partial_loader_data())); new TestURLLoader(partial_loader_data()));

4
pdf/pdfium/pdfium_engine.cc

@@ -728,10 +728,6 @@ bool PDFiumEngine::HandleDocumentLoad(std::unique_ptr<UrlLoader> loader) {
return true; return true;
} }
pp::Instance* PDFiumEngine::GetPluginInstance() {
return client_->GetPluginInstance();
}
std::unique_ptr<URLLoaderWrapper> PDFiumEngine::CreateURLLoader() { std::unique_ptr<URLLoaderWrapper> PDFiumEngine::CreateURLLoader() {
return std::make_unique<URLLoaderWrapperImpl>(client_->CreateUrlLoader()); return std::make_unique<URLLoaderWrapperImpl>(client_->CreateUrlLoader());
} }

1
pdf/pdfium/pdfium_engine.h

@@ -183,7 +183,6 @@ class PDFiumEngine : public PDFEngine,
SendThumbnailCallback send_callback) override; SendThumbnailCallback send_callback) override;
// DocumentLoader::Client: // DocumentLoader::Client:
pp::Instance* GetPluginInstance() override;
std::unique_ptr<URLLoaderWrapper> CreateURLLoader() override; std::unique_ptr<URLLoaderWrapper> CreateURLLoader() override;
void OnPendingRequestComplete() override; void OnPendingRequestComplete() override;
void OnNewDataReceived() override; void OnNewDataReceived() override;