[OOPIF PDF] Create feature and flag for PDF OOPIF

Add PDF feature "PdfOopif" and flag "pdf-oopif". The intended use is to
be able to switch between using a MimeHandlerViewGuest or an OOPIF to
launch the PDF Viewer.

Bug: 1445746
Change-Id: Ifeaf2bcc66ecf6ac112aa46d97b6237fcd7e4f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4666784
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171407}

chrome/browser/about_flags.cc

@@ -6782,6 +6782,10 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kAccessiblePDFFormDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(chrome_pdf::features::kAccessiblePDFForm)},
 
+    {"pdf-oopif", flag_descriptions::kPdfOopifName,
+     flag_descriptions::kPdfOopifDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfOopif)},
+
     {"pdf-portfolio", flag_descriptions::kPdfPortfolioName,
      flag_descriptions::kPdfPortfolioDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfPortfolio)},

chrome/browser/flag-metadata.json

@@ -6370,6 +6370,11 @@
     "owners": [ "rhalavati", "//ui/accessibility/OWNERS" ],
     "expiry_milestone": 120
   },
+  {
+    "name": "pdf-oopif",
+    "owners": [ "andyphan", "//pdf/OWNERS" ],
+    "expiry_milestone": 124
+  },
   {
     "name": "pdf-portfolio",
     "owners": [ "nigi", "//pdf/OWNERS" ],

chrome/browser/flag_descriptions.cc

@@ -40,6 +40,10 @@ const char kAccessiblePDFFormName[] = "Accessible PDF Forms";
 const char kAccessiblePDFFormDescription[] =
     "Enables accessibility support for PDF forms.";
 
+const char kPdfOopifName[] = "OOPIF for PDF Viewer";
+const char kPdfOopifDescription[] =
+    "Use an OOPIF for the PDF Viewer, instead of a GuestView.";
+
 const char kPdfPortfolioName[] = "PDF portfolio";
 const char kPdfPortfolioDescription[] = "Enable PDF portfolio feature.";
 

chrome/browser/flag_descriptions.h

@@ -55,6 +55,9 @@ extern const char kAcceleratedVideoEncodeDescription[];
 extern const char kAccessiblePDFFormName[];
 extern const char kAccessiblePDFFormDescription[];
 
+extern const char kPdfOopifName[];
+extern const char kPdfOopifDescription[];
+
 extern const char kPdfPortfolioName[];
 extern const char kPdfPortfolioDescription[];
 

pdf/pdf_features.cc

@@ -17,6 +17,8 @@ BASE_FEATURE(kPdfIncrementalLoading,
              "PdfIncrementalLoading",
              base::FEATURE_DISABLED_BY_DEFAULT);
 
+BASE_FEATURE(kPdfOopif, "PdfOopif", base::FEATURE_DISABLED_BY_DEFAULT);
+
 // "Partial loading" refers to loading only specific parts of the PDF.
 // TODO(crbug.com/1064175): Remove this once partial loading is fixed.
 BASE_FEATURE(kPdfPartialLoading,

pdf/pdf_features.h

@@ -15,6 +15,7 @@ namespace features {
 
 BASE_DECLARE_FEATURE(kAccessiblePDFForm);
 BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
+BASE_DECLARE_FEATURE(kPdfOopif);
 BASE_DECLARE_FEATURE(kPdfPartialLoading);
 BASE_DECLARE_FEATURE(kPdfPortfolio);
 BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer);

tools/metrics/histograms/enums.xml

@@ -65606,6 +65606,7 @@ from previous Chrome versions.
       label="ThreadedScrollPreventRenderingStarvation:enabled"/>
   <int value="896506516"
       label="enable-canvas-context-lost-in-background (obsolete)"/>
+  <int value="896603699" label="PdfOopif:enabled"/>
   <int value="897179602" label="OmniboxSquareIcons:disabled"/>
   <int value="897457037" label="AutocorrectByDefault:enabled"/>
   <int value="897695337" label="TabStripRedesign:enabled"/>
@@ -67072,6 +67073,7 @@ from previous Chrome versions.
   <int value="1661965147" label="NtpWideModules:disabled"/>
   <int value="1662277267" label="DecodeScriptSourceOffThread:disabled"/>
   <int value="1662466302" label="NtpRealboxUseGoogleGIcon:enabled"/>
+  <int value="1662543761" label="PdfOopif:disabled"/>
   <int value="1663574600" label="WebViewDisplayCutout:enabled"/>
   <int value="1664401033" label="ColorCorrectRendering:enabled"/>
   <int value="1664463407" label="FirstPartySets:enabled"/>