chromium/src
0
Fork 0
Code Activity

Update docs/clang.md

Browse Source 
This CL updates commands listed in the docs/clang.md file to match
what's currently needed.

Bug: 1275317
Change-Id: I3fe39171d42086b1e44fb914e6f4d316b8517f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311508
Reviewed-by: danakj chromium <danakj@chromium.org>
Commit-Queue: Will Cassella <cassew@chromium.org>
Cr-Commit-Position: refs/heads/main@{#948065}
This commit is contained in:
Will Cassella
2021-12-03 18:16:21 +00:00
committed by Chromium LUCI CQ
parent e783f744ef
commit ee180278e5
1 changed files with 2 additions and 3 deletions

5
docs/clang.md

@ -26,7 +26,7 @@ is used by default when clang is used.
If you're working on the plugin, you can build it locally like so: If you're working on the plugin, you can build it locally like so:
1. Run `./tools/clang/scripts/build.py --without-android` 1. Run `./tools/clang/scripts/build.py --without-android --without-fuchsia`
to build the plugin. to build the plugin.
1. Run `ninja -C third_party/llvm-build/Release+Asserts/` to build incrementally. 1. Run `ninja -C third_party/llvm-build/Release+Asserts/` to build incrementally.
1. Build with clang like described above, but, if you use goma, disable it. 1. Build with clang like described above, but, if you use goma, disable it.
@ -34,8 +34,7 @@ If you're working on the plugin, you can build it locally like so:
To test the FindBadConstructs plugin, run: To test the FindBadConstructs plugin, run:
(cd tools/clang/plugins/tests && \ (cd tools/clang/plugins/tests && \
./test.py ../../../../third_party/llvm-build/Release+Asserts/bin/clang \ ./test.py ../../../../third_party/llvm-build/Release+Asserts/bin/clang)
../../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so)
Since the plugin is rolled with clang changes, behavior changes to the plugin Since the plugin is rolled with clang changes, behavior changes to the plugin
should be guarded by flags to make it easy to roll clang. A general outline: should be guarded by flags to make it easy to roll clang. A general outline: