chromium/src
0
Fork 0
Code Activity

Extensions: CodeHealth: Dedupe "pinned" and add space beneath TODO

Browse Source 
Any TODO's above a comment blur the line between where a TODO ends.

Bug: chromium:346952289
Change-Id: I4f57dc2e51e786775a4ea6d870e218b84bd4d425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6492290
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1452038}
This commit is contained in:
Solomon Kinard
2025-04-25 13:58:03 -07:00
committed by Chromium LUCI CQ
parent 6e38b10c93
commit f561bd9088
1 changed files with 4 additions and 3 deletions

7
chrome/browser/ui/views/extensions/extensions_toolbar_container.h

@@ -326,13 +326,14 @@ class ExtensionsToolbarContainer : public ToolbarIconContainerView,
std::unique_ptr<ToolbarActionHoverCardController> std::unique_ptr<ToolbarActionHoverCardController>
action_hover_card_controller_; action_hover_card_controller_;
// TODO(pbos): Create actions and icons only for pinned pinned / popped out // TODO(pbos): Create actions and icons only for pinned / popped out actions
// actions (lazily). Currently code expects GetActionForId() to return // (lazily). Currently code expects GetActionForId() to return actions for
// actions for extensions that aren't visible. // extensions that aren't visible.
// Actions for all extensions. // Actions for all extensions.
std::vector<std::unique_ptr<ToolbarActionViewController>> actions_; std::vector<std::unique_ptr<ToolbarActionViewController>> actions_;
// View for every action, does not imply pinned or currently shown. // View for every action, does not imply pinned or currently shown.
ToolbarIcons icons_; ToolbarIcons icons_;
// Popped-out extension, if any. // Popped-out extension, if any.
std::optional<extensions::ExtensionId> popped_out_action_; std::optional<extensions::ExtensionId> popped_out_action_;
// The action that triggered the current popup, if any. // The action that triggered the current popup, if any.