chromium/src
0
Fork 0
Code Activity

Fix SandboxBPF tests under -fsanitize=vptr

Browse Source 
The new Ubuntu picked up a newer glibc, which included this change:
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=efc6b2dbc47231dee7a7ac39beec808deb4e4d1f

Now the pipe() function is implemented in terms of the pipe2 syscall, so
we need to allow it on all architectures, not just aarch64.

Bug: 40248746
Change-Id: I01e6ca1e6e48b71d818e994ad192e55f6d4484df
Fixed: 40273116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5856940
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354745}
This commit is contained in:
David Benjamin
2024-09-12 19:30:16 +00:00
committed by Chromium LUCI CQ
parent e866fa2f94
commit f68d83037d
3 changed files with 1 additions and 14 deletions

4
sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc

@ -194,10 +194,8 @@ bool IsSyscallForTestHarness(int sysno) {
if (sysno == kMMapNr || sysno == __NR_munmap || if (sysno == kMMapNr || sysno == __NR_munmap ||
#if !defined(__aarch64__) #if !defined(__aarch64__)
sysno == __NR_pipe || sysno == __NR_pipe ||
#else
sysno == __NR_pipe2 ||
#endif #endif
sysno == __NR_sigaltstack) { sysno == __NR_pipe2 || sysno == __NR_sigaltstack) {
return true; return true;
} }
#endif #endif

3
testing/buildbot/chromium.memory.json

@ -16009,9 +16009,6 @@
"test_id_prefix": "ninja://remoting:remoting_unittests/" "test_id_prefix": "ninja://remoting:remoting_unittests/"
}, },
{ {
"args": [
"--gtest_filter=-SandboxBPF.ApplyBasicAllowlistPolicy:SandboxBPF.SyntheticPolicy:SandboxBPF.UnsafeTrapWithCond"
],
"merge": { "merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py" "script": "//testing/merge_scripts/standard_gtest_merge.py"
}, },

8
testing/buildbot/test_suite_exceptions.pyl

@ -3828,14 +3828,6 @@
'remove_from': [ 'remove_from': [
'android-asan', # https://crbug.com/962650 'android-asan', # https://crbug.com/962650
], ],
'modifications': {
'linux-ubsan-vptr': {
'args': [
# TODO(crbug.com/40273116): Remove this.
'--gtest_filter=-SandboxBPF.ApplyBasicAllowlistPolicy:SandboxBPF.SyntheticPolicy:SandboxBPF.UnsafeTrapWithCond',
],
},
},
}, },
'screenshot_sync_metal_passthrough_ganesh_tests': { 'screenshot_sync_metal_passthrough_ganesh_tests': {
'remove_from': [ 'remove_from': [