chromium/src
0
Fork 0
Code Activity

Remove DumpWithoutCrashing from SkiaFontMapper

Browse Source 
Remove DumpWithoutCrashing from SkiaFontMapper::MapFont() as we
have gathered enough detailed debug data on Canary/Dev.

No functional changes.

Bug: 344643689, 349439677
Change-Id: I029ca92893bbe639a882bd0a0159aa56a68661db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5684006
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1324369}
This commit is contained in:
Alex Gough
2024-07-08 18:16:38 +00:00
committed by Chromium LUCI CQ
parent 235c22e7de
commit f706ade43b
1 changed files with 0 additions and 13 deletions

13
pdf/pdfium/pdfium_font_win.cc

@@ -13,9 +13,6 @@
#include "base/containers/contains.h" #include "base/containers/contains.h"
#include "base/containers/fixed_flat_map.h" #include "base/containers/fixed_flat_map.h"
#include "base/containers/flat_map.h" #include "base/containers/flat_map.h"
#include "base/debug/alias.h"
#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
#include "base/sequence_checker.h" #include "base/sequence_checker.h"
@@ -95,16 +92,6 @@ class SkiaFontMapper {
return id; return id;
} }
// TODO(crbug.com/344643689) Gather failure information during transition.
static bool is_first_missing_face = true;
if (is_first_missing_face) {
is_first_missing_face = false;
base::debug::Alias(&charset);
DEBUG_ALIAS_FOR_CSTR(aliased_face, face, 32);
SCOPED_CRASH_KEY_NUMBER("crbug.com/344643689", "charset", charset);
SCOPED_CRASH_KEY_STRING32("crbug.com/344643689", "face", face);
base::debug::DumpWithoutCrashing();
}
LOG(WARNING) << "Failed to lookup face `" << base::HexEncode(face) LOG(WARNING) << "Failed to lookup face `" << base::HexEncode(face)
<< "` for charset " << charset << ", weight " << weight; << "` for charset " << charset << ", weight " << weight;
return nullptr; return nullptr;