[High5] Update pin keyboard button color
- Update button color to the latest High5 spec - Fix digit numbers accessibility labels Bug: b:349942666, b:348326316 Change-Id: Ic7faca8a796a7c2ad73649995de97f63062ab8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5666494 Reviewed-by: Hardik Goyal <hardikgoyal@chromium.org> Commit-Queue: Istvan Nagy <iscsi@google.com> Reviewed-by: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/main@{#1320913}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
8e2554d7c3
commit
fb8edc2a94
ash/auth/views
@ -76,14 +76,14 @@ TEST_F(PinKeyboardPixelTest, DayMode) {
|
|||||||
DarkLightModeControllerImpl::Get()->SetDarkModeEnabledForTest(false);
|
DarkLightModeControllerImpl::Get()->SetDarkModeEnabledForTest(false);
|
||||||
// Verify the UI.
|
// Verify the UI.
|
||||||
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
|
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
|
||||||
"DayMode", /*revision_number=*/2, view_));
|
"DayMode", /*revision_number=*/3, view_));
|
||||||
}
|
}
|
||||||
|
|
||||||
// Verify the pin keyboard component look like in DayMode
|
// Verify the pin keyboard component look like in DayMode
|
||||||
TEST_F(PinKeyboardPixelTest, NightMode) {
|
TEST_F(PinKeyboardPixelTest, NightMode) {
|
||||||
// Verify the UI.
|
// Verify the UI.
|
||||||
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
|
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
|
||||||
"NightMode", /*revision_number=*/2, view_));
|
"NightMode", /*revision_number=*/3, view_));
|
||||||
}
|
}
|
||||||
|
|
||||||
} // namespace
|
} // namespace
|
||||||
|
@ -43,7 +43,7 @@ constexpr int kPinKeyboardWidthDp =
|
|||||||
3 * kButtonSize + 2 * kButtonsHorizontalPadding;
|
3 * kButtonSize + 2 * kButtonsHorizontalPadding;
|
||||||
|
|
||||||
constexpr ui::ColorId kButtonBackgroundColorId =
|
constexpr ui::ColorId kButtonBackgroundColorId =
|
||||||
cros_tokens::kCrosSysBaseElevated;
|
cros_tokens::kCrosSysSystemBaseElevated;
|
||||||
constexpr ui::ColorId kButtonContentColorId = cros_tokens::kCrosSysOnSurface;
|
constexpr ui::ColorId kButtonContentColorId = cros_tokens::kCrosSysOnSurface;
|
||||||
|
|
||||||
void StyleButton(IconButton* button_ptr) {
|
void StyleButton(IconButton* button_ptr) {
|
||||||
@ -192,7 +192,7 @@ void PinKeyboardView::AddDigitButton(int digit) {
|
|||||||
|
|
||||||
IconButton::Builder builder;
|
IconButton::Builder builder;
|
||||||
builder.SetType(IconButton::Type::kXLarge)
|
builder.SetType(IconButton::Type::kXLarge)
|
||||||
.SetAccessibleNameId(IDS_ASH_PIN_KEYBOARD_DELETE_ACCESSIBLE_NAME)
|
.SetAccessibleName(base::NumberToString16(digit))
|
||||||
.SetCallback(base::BindRepeating(&PinKeyboardView::OnDigitButtonPressed,
|
.SetCallback(base::BindRepeating(&PinKeyboardView::OnDigitButtonPressed,
|
||||||
weak_ptr_factory_.GetWeakPtr(), digit))
|
weak_ptr_factory_.GetWeakPtr(), digit))
|
||||||
.SetTogglable(false)
|
.SetTogglable(false)
|
||||||
|
Reference in New Issue
Block a user