This CL updates the multiple overlay processor to handle candidates
with rounded-display mask textures.
Currently the overlay processor will reject the candidates with
rounded-display masks as these textures have no damage over consecutive
frames therefore it is less power efficient to promote these textures.
Candidates with rounded-display masks are given a special priority in
the system that promote them for correctness rather than efficient.
This CL also adds fallback strategies in case candidates with
rounded-display mask textures fail DRM page-flip test.
Bug: 1262970
Test: Covered by unittests
Change-Id: Ia99fec6932b2f639fc3c13b5df30d7d6d63fb5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4285130
Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
Reviewed-by: Kevin Haslett <khaslett@chromium.org>
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132281}
Instead, let tests pass the LocalState instance to its ctor.
By default BrowserProcess's LocalState is used for ChromeUserManager
and its subclasses.
BUG=b:278643115
TEST=Ran tryjob.
Change-Id: Idc742af199c41a33ae34ad25358d39081015743f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4441786
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132273}
Rather than storing a WeakPtr reference and setting it to nullptr,
calls WeakPtrFactory::InvalidateWeakPtrs() to invalidate all existing
weak pointers. In local tests, this seems to avoid the DCHECK where
the scoring model callback is called after the result has been updated.
Also moves refactors the logic to cancel pending requests to the model
and to invalidate the WeakPtr into a function and moves it closer to
places in which the AutocompleteResult is updated.
Also updates some comments.
Bug: 1405555, 1434477
Change-Id: Iaa70292210df37573daa6517f7ab9e6f83ca73a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4442946
Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132270}
`base::GUID` has been renamed, and is set to be removed. This CL is
part of a batch of changes replacing all uses of `base::GUID`, with
`base::Uuid`, and its associated counterparts.
Additionally, deprecated functions in `base/uuid.h` are also also having
their uses removed wherever they occur.
Changes for path: /components/dom_distiller
This CL was uploaded by git cl split.
R=nyquist@chromium.org
Bug: 1428566
Change-Id: Ib90dfc2cb9e660e7a34d976106337cefaeefba7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429679
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Claudio DeSouza <cdesouza@igalia.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132251}
The new UX specs diverge enough to the point where a new row needs to be
added. This row handles both the compact/visual case along with
supporting accessory views which will be used for each power. Added
an accessory view to support the existing price-track case.
Bug: 1431609
Change-Id: I1290f79cf920383c5bd6a4a9171a06d525501b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4409714
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132241}
Previously we included C1 virtual card art image in the metadata metrics
logging, and included this in the experiment group during evaluating
the suggestion selection conversion rate. However, since this static
image is still not rich card art, we should exclude it.
After the change, the metadata metrics logging considers only product
name and art image sourced from direct issuer metadata integration.
Bug: 1313616, b/277602105
Change-Id: Ife84697a1c3fe54519834ed8e05a53e6fb9a72fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420532
Reviewed-by: Vishwas Uppoor <vishwasuppoor@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132211}
This reverts commit b70273ba79.
Reason for revert: Crashing non-en-US testers.
Original change's description:
> Update product info API check to be its own flag
>
> This patch separates enabling the product info api from the features
> using it. By default, the api is enabled in the US since we have at
> least one real feature enabled by default. New features will no longer
> need to modify the shopping service to ensure their feature is in the
> list allowed for the api to be enabled. The only changes as a result
> of this will need to be on the experiment config side where we need
> to specify the new flag.
>
> Bug: b:266449217
> Change-Id: I5c581d8924ea57211a2dbb246b959534c30e298e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415676
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1129270}
Bug: b:266449217, 1434421
Change-Id: I3586d5951643de47195442dc2cedabea3c558072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4443747
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132209}
Some changes to viz::TestInProcessContextProvider so it can handle
everything ui::InProcessContextProvider does.
1. Early return if BindToCurrentSequence() is called more than once.
2. Support GLES2Interface+RasterInterface using
RasterImplementationGLES.
3. Don't duplicate GpuFeatureInfo.
Bug: 1292507
Change-Id: Ifa7dd761d480cd21b5294fda586498bbdd9aaae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4443406
Reviewed-by: vikas soni <vikassoni@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132196}
With absl::string_view turned into std::string_view,
abseil_string_conversions.h is now misnamed. However, those conversions
themselves are only needed because Chromium has forked a fundamental C++
vocabulary type.
As an intermediate state, until we make base::StringPiece into
std::string_view itself, add implicit conversions from/to the standard
type. This simplifies boundaries between external code, where the safe
pattern is currently tedious and the unsafe pattern (decomposing into
ptr/len) is much shorter.
However, this is imperfect. You may still need std::string_view in
places. E.g. implementing std::string_view-based interfaces, APIs that
take or return pointers, or cases when multiple implicit conversions are
chained together.
To that end, this reshuffles PRESUBMITs and guidelines:
- In Chromium, absl::string_view is now always std::string_view.
Whenever you would have said absl::string_view, say
std::string_view instead.
- However, for now, base::StringPiece is still distinct from
std::string_view and the guidelines still prefer base::StringPiece
over it. So, when you need std::string_view to deal with an
external API, use std::string_view. Otherwise, use
base::StringPiece.
(This is the same as the status quo, except absl::string_view is
replaced with std::string_view, and using the more standard spelling
when needed for 3p APIs is spelled out more explicitly. In other
cases, our non-standard spelling remains the preference.)
Existing uses of absl::string_view are left alone, but as they're the
exact same type, references can be freely and incrementally converted
to std::string_view.
Having two vocabulary types is still costly as developers must keep
track of the two, but it's better than three. The only way to truly
remove this cost is to merge base::StringPiece into std::string_view,
now that they are at parity in safety checks. This CL leaves that
decision for later, though its author is strongly of the opinion that we
should do it. :-)
As part of this, this removes the existing uses of
abseil_string_conversions.h, and cleans up some conversions and base
dependencies in the to-be-extracted net/der and net/cert/pki that are
no longer necessary.
Bug: 691162, 1370553
Change-Id: I0629029c157819ce673598caeb0f106917244f6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427593
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132183}
It's possible that callback tasks don't get cancelled when the
AC Result changes, which will result in re-scoring the wrong
matches when the callback runs. This CL passes along the
match's destination_url at the time scoring is called, and then
checks to make sure the url at that index is still the same.
If the destination url doesn't match, the result has changed and
the entire set of model outputs are discarded.
Bug: 1405555, 1431981
Change-Id: I121be081cf67802204e31f8aa001b6fd1661450c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437551
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132145}
https://crrev.com/1131474 landed yesterday to add clientDataJson to
CredMan requests, but it was not properly merged with
https://crrev.com/1129907 which landed earlier yesterday, causing
CredMan getAssertion requests to fail.
This fixes the problem and also adds the clientDataHash to conditional
requests sent to CredMan.
Bug: 1427843
Change-Id: Iee476916d01be829e6cf996d1ef9d1fd75f4bc6f
Low-Coverage-Reason: This is behind a flag, test infrastructure is in progress.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4442086
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132117}
We're failing to create this directory sometimes. Adding a crash key
will distinguish whether we're creating the wrong directory or whether
we can't create the directory for some reason.
Bug: 1434333
Change-Id: I8110f2d480625658a248e12000df753ed8de7b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4443251
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132114}
This CL updates the policy::DeveloperToolsPolicyHandler::Availability
enum value of kDisallowedForForceInstalledExtensions to
kDisallowedForSensitiveExtensions to better reflect the changes in
crrev.com/c/4412168, which expanded this value to also include component
extensions with the management permission. It also updates some of the
test names that were referencing the old name and the name given to the
setting in the related yaml policy definition.
No behavior change is expected.
Bug: b/274599835
Change-Id: I0abeace145c6e94aee5ba3908e6bc129e3e032d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437309
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Tim <tjudkins@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132084}
The new switch safe-browsing-skip-high-confidence-allowlist is added in
this CL for debugging purposes. When present, checks to the high-
confidence allowlist will return that the allowlist is not matched.
This currently applies only to the V4LocalDatabaseManager allowlist, not
the RemoteSafeBrowsingDatabaseManager allowlist.
Change-Id: I916cdb2c22ceb895d78440c8e1d9211e8e83e447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4442366
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132070}
This message will be translated but the previous wording assumed that
the reader understood the details of what the policy was controlling.
Change-Id: I677011b28b478128a26f1a3d15520f95a2f6288b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430415
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132016}
This util only supports the page content world which is less widely used
now than it was when the utility was created. Additionally, it can hide
this fact from the caller and lead to bugs where the expected frames are
not returned (because the associated features live in an isolated
world).
Bug: 1427327
Change-Id: I231b3f122aa92a350ee9d174eebabbcf8bc242bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437732
Reviewed-by: David Roger <droger@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132008}
This CL removes expired histograms:
- PageLoad.Experimental.Bytes.Total2
- PageLoad.Experimental.Bytes.Total2.LoadType.ForwardBackNavigation
- PageLoad.Experimental.Bytes.Total2.LoadType.Reload
- PageLoad.Experimental.Bytes.Total2.LoadType.NewNavigation
- PageLoad.Experimental.Bytes.Network
- PageLoad.Experimental.Bytes.Network.LoadType.ForwardBackNavigation
- PageLoad.Experimental.Bytes.Network.LoadType.Reload
- PageLoad.Experimental.Bytes.Network.LoadType.NewNavigation
- PageLoad.Experimental.Bytes.NetworkIncludingHeaders
PageLoad.Experimental.Bytes.NetworkIncludingHeaders was used in
tools/perf/contrib/cluster_telemetry/ad_tagging_ct.py and it is also
removed by this CL. json files are generated by the following command:
$ tools/perf/generate_perf_sharding.py update-timing --filter-only
Bug: 976125, 1343448, 1357698, 1384561
Change-Id: I711e34fe78e8346946f3ba0e3882df9c64e49784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4432195
Auto-Submit: Asami Doi <asamidoi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1131992}
This is one of the first steps to move attribution reporting request
and response logic to network service. It also makes it easier to
enforce the properties that the header is set if and only if the
corresponding feature is enabled and when the
Attribution-Reporting-Eligible is also present.
The feature flag and the mojom type are moved to
//services/network/public to be used by //services/network, blink and
browser. We will investigate removing all knowledge of the OS support
value from the renderer in the future.
The OS support enum is added to the resource request types to be
populated to the network service layer.
We will likewise move setting the Attribution-Reporting-Eligible header
to the network service in a future CL.
Bug: 1375791, 1425083
Change-Id: I6d0dc6154230963b376477a74239115b64c6ffae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426530
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Brendon Tiszka <tiszka@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1131961}
ClearBrowsingDataOnExitList and BrowsingDataLifetime currently require SyncDisabled to be set to allow applying them. This CL relaxes the condition to disable the sync types for the respective browsing data types that need to be cleared by policy if sync and browser sign in are not disabled by policy.
This will be the new flow for applying the data retention policy:
1- If the SyncDisabled or BrowserSignin policy is set as true, then there is no need to check anything after this point as this means that all sync types are disabled, and the old logic can be followed.
2- If SyncDisabled policy and BrowserSignin are not set or set as false, then we can set the policy normally and automatically disable the sync types we need.
This change will be extended to IdleTimeoutActions policy which requires sync to be disabled as well. Thus, a shared browsing_data_policies_utils file is added to share the code for this change.
Bug: b/272025211
Change-Id: Ic935f2f3ce54692c1809641b77831d2cfe4e3756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351191
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Salma Elmahallawy <esalma@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1131925}
raw_ptr was meant to be used in member variables only.
Some developers are using them in return values and arguments. This
isn't really a problem, but not very useful.
In most cases, developers are copy-pasting nearby code, causing this
pattern to propagate further away. So it is better to stop this early.
**Hidden motivation**: I am playing with an idea about automatically
finding every pre-existing dangling pointers:
https://godbolt.org/z/o8adYnc7a
It almost compiles, but this causes declaration and implementation
signature to differ in those locations. If we could get rid of them
here, my life would be slightly easier.
Bug: 1430482
Change-Id: I566cc956bbbce77a7275c0d0eb9116b4c6fa558c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433430
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Owners-Override: Bartek Nowierski <bartekn@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1131881}
`base::GUID` has been renamed, and is set to be removed. This CL is
part of a batch of changes replacing all uses of `base::GUID`, with
`base::Uuid`, and its associated counterparts.
Additionally, deprecated functions in `base/uuid.h` are also also having
their uses removed wherever they occur.
Changes for path: /components/omnibox/browser
This CL was uploaded by git cl split.
R=yoangela@chromium.org
Bug: 1428566
Change-Id: Iabc5f242165f5f362f9dccc178ebf7a45c9553d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429896
Auto-Submit: Claudio DeSouza <cdesouza@igalia.com>
Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Commit-Queue: Claudio DeSouza <cdesouza@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1131874}
