This removes the DownloadToFile option from ResourceRequest, as well
as URLLoaderClient.OnDataDownloaded and the downloaded_file argument
to OnReceiveResponse, as nothing is using this anymore.
Also removes the actual implementation of the feature, as well as all
the bits of plumbing that are now no longer needed.
Note that there is still a blink::Resource::DidDownloadData,
blink::RawResourceClient::DataDownloaded etc, as from that layer down
these callbacks are also used by the download-to-blob functionality that
replaced download-to-file.
Bug: 791702
Change-Id: I616a829630a285bbfc580d62f7b8de7ed3b406ea
Reviewed-on: https://chromium-review.googlesource.com/1064798
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566193}
There have been multiple test failures among users of the CRX filesystem, which
is not adequately tested by existing tests. I'm not sure at all what's broken,
but I guess I'll have to do manual testing to sort it out.
> Pepper: Move FileRef to the "new" resource proxy.
>
> This change moves the FileRef implementation from the previous one in the "old"
> resource model (ppb_file_ref_impl.cc) to the "new" resource model
> (pepper_file_ref_host.cc), and from the renderer to the browser.
>
> As many as possible of the supporting changes were split off to other changes
> to minimize the size of this change. Unfortunately, a lot of changes for
> URLLoader had to be rolled into this change.
>
> The data structures for CreateInfo have changed, and all users of FileRef have
> to be moved over, which is what causes this change to be so large.
>
> TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
> BUG=225441
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216744
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218305
>
> Review URL: https://chromiumcodereview.appspot.com/21966004TBR=teravest@chromium.org
Review URL: https://codereview.chromium.org/23462016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220165 0039d316-1c4b-4281-b951-d872f2087c98
This change is being reverted because it was causing some crashes for an
application that I haven't been able to debug yet.
> Pepper: Move FileRef to the "new" resource proxy.
>
> This change moves the FileRef implementation from the previous one in the "old"
> resource model (ppb_file_ref_impl.cc) to the "new" resource model
> (pepper_file_ref_host.cc), and from the renderer to the browser.
>
> As many as possible of the supporting changes were split off to other changes
> to minimize the size of this change. Unfortunately, a lot of changes for
> URLLoader had to be rolled into this change.
>
> The data structures for CreateInfo have changed, and all users of FileRef have
> to be moved over, which is what causes this change to be so large.
>
> TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
> BUG=225441
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216744
>
> Review URL: https://chromiumcodereview.appspot.com/21966004TBR=teravest@chromium.org
Review URL: https://codereview.chromium.org/22901012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218544 0039d316-1c4b-4281-b951-d872f2087c98
This change moves the FileRef implementation from the previous one in the "old"
resource model (ppb_file_ref_impl.cc) to the "new" resource model
(pepper_file_ref_host.cc), and from the renderer to the browser.
As many as possible of the supporting changes were split off to other changes
to minimize the size of this change. Unfortunately, a lot of changes for
URLLoader had to be rolled into this change.
The data structures for CreateInfo have changed, and all users of FileRef have
to be moved over, which is what causes this change to be so large.
TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
BUG=225441
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216744
Review URL: https://chromiumcodereview.appspot.com/21966004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218305 0039d316-1c4b-4281-b951-d872f2087c98
> Pepper: Move FileRef to the "new" resource proxy.
>
> This change moves the FileRef implementation from the previous one in the "old"
> resource model (ppb_file_ref_impl.cc) to the "new" resource model
> (pepper_file_ref_host.cc), and from the renderer to the browser.
>
> As many as possible of the supporting changes were split off to other changes
> to minimize the size of this change. Unfortunately, a lot of changes for
> URLLoader had to be rolled into this change.
>
> The data structures for CreateInfo have changed, and all users of FileRef have
> to be moved over, which is what causes this change to be so large.
>
> TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
> BUG=225441
>
> Review URL: https://codereview.chromium.org/21966004TBR=teravest@google.com
Review URL: https://codereview.chromium.org/22903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217036 0039d316-1c4b-4281-b951-d872f2087c98
This change moves the FileRef implementation from the previous one in the "old"
resource model (ppb_file_ref_impl.cc) to the "new" resource model
(pepper_file_ref_host.cc), and from the renderer to the browser.
As many as possible of the supporting changes were split off to other changes
to minimize the size of this change. Unfortunately, a lot of changes for
URLLoader had to be rolled into this change.
The data structures for CreateInfo have changed, and all users of FileRef have
to be moved over, which is what causes this change to be so large.
TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
BUG=225441
Review URL: https://codereview.chromium.org/21966004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216744 0039d316-1c4b-4281-b951-d872f2087c98
This function is unused. Found while refactoring FileRef to the "new" resource
proxy model.
Tested:
Built chrome
BUG=
Review URL: https://chromiumcodereview.appspot.com/15018015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198962 0039d316-1c4b-4281-b951-d872f2087c98
This puts all of the URLResponseInfo attributes in a struct so it can be sent over IPC in one message rather than requiring one sync IPC per attribute access.
This includes a new example of streaming to a file that I used to do some manual tests of this change.
I added and improved some documentation that I noticed when trying to write the example.
Review URL: https://codereview.chromium.org/10993031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168273 0039d316-1c4b-4281-b951-d872f2087c98
