Upgrades content::PepperVpnProviderMessageFilter (chromeos only)
and the ppapi:: side VpnProviderSharedBuffer and
VpnProviderResource to the new shared memory api.
In the current implementation, both send and receive buffers are
mapped writable, so uses of SharedMemory are replaced with
UnsafeSharedMemoryRegions. There is no functional change.
Bug: 795291
Change-Id: I19153a6d59d0ad6385423a495d736a92b4642c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649325
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668333}
If updated files don't use base::WrapUnique, base/memory/ptr_util.h includes are changed to
<memory>.
Bug: 755727
Change-Id: Ifb9ad8d3ee41130ac5c159cf084c979a304b80ed
Reviewed-on: https://chromium-review.googlesource.com/885383
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532173}
A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.
To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.
Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.
The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
correctly)
3) Add base:: namespace qualifier where missing.
WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.
git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.
BUG=637812
Review-Url: https://codereview.chromium.org/2254973004
Cr-Commit-Position: refs/heads/master@{#413394}
Reason for revert:
Speculative revert to try to fix failing Android tests.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/28629
android_webview_test_apk on Android android_webview_test_apk on Android failed 22
failures:
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDouble with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextForward with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearMatches with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllFinds
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearFindNext
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllEmptyNext
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDoubleNext with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextForward
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBig
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBig with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDouble
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBackward
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearFindNext with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDoubleNext
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllEmptyNext with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextFirst
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindEmptyNext
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextFirst with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBackward with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindEmptyNext with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllFinds with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearMatches
Original issue's description:
> ppapi: PPB_VpnProvider: Implement Resource Host
>
> BUG=506490
>
> Committed: https://crrev.com/8a1558d86fa478c65aba0b268129a9d8f2d3a7af
> Cr-Commit-Position: refs/heads/master@{#403909}
TBR=dcheng@chromium.org,bartfab@chromium.org,bbudge@chromium.org,dskaram@chromium.org,robert.bradford@intel.com,cernekee@chromium.org,emaxx@chromium.org,adrian.belgun@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=506490
Review-Url: https://codereview.chromium.org/2129653002
Cr-Commit-Position: refs/heads/master@{#403931}
