@QA: This CL is a no-op.
Caused by incorrectly covering base::Thread when using regex
"base::(Time|Thread)(Ticks|Delta)?\b"
This script removed base/time/time.h if:
1) "base::Thread" is present
2) There is no (Time|ThreadTicks|Days|Hours|Minutes|Seconds|
Milliseconds|Microseconds|Nanoseconds|Hertz)
string in the file (no base:: prefix required to skip removal)
Bug: 1026641
Change-Id: I9df5e8beccc74054bf9bfff12320a1d4e0295b62
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3563202
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988045}
This CL is a no-op.
Only fixing instances where base::Time (and Ticks/Delta) is used in
a statement (i.e. not as a parameter to avoid adding includes in mere
overrides). Skipping pointer and reference qualified instances.
i.e. matches this regex:
'(\n *[^/\n][^/\n][^/\n]*base::(Time|Thread)(Ticks|Delta)?\b[^*&][^)]*;)'
and skipping files that have any existing fwd-decl for any of the
variants.
This is a prereq to remove unused base/task/post_task.h includes in
https://chromium-review.googlesource.com/c/chromium/src/+/3555247
Bug: 1026641
Change-Id: I87b43a8dc92bdceb67f4bd59b327b54813aa72a6
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557354
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#987283}
Building the target required various minor IWYU and build flag fixes
as well as including more files in the Fuchsia build.
More work is needed to be able to run the tests successfully.
Bug: 1290940, 1310537
Test: autoninja -C out/fuchsia/ interactive_ui_tests
Change-Id: I78a1b0473a36f8ad75f91aaf4a823ff8d5a1e756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553821
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#986359}
This is an initial step to enable NaCl to work in ARM64 Chromium using
ARM32 NaCl. This disables building the parts of NaCl that would need
to be built as ARM32 (including nacl_helper and various untrusted
nexes). It enables building NaCl support into the ARM64 chrome
executable.
With this change, various NaCl tests pass when run on ARM64 Ubuntu
(20.04), including this test:
xvfb-run -a ./out/default/browser_tests --gtest_filter=PPAPINaClNewlibTest.PostMessage
That requires that the following files are copied from an ARM32 build
of Chromium:
nacl_helper
nacl_helper_bootstrap
nacl_irt_arm.nexe
ppapi_nacl_tests_newlib.nmf
ppapi_nacl_tests_newlib_arm.nexe
Two changes will be needed after this:
* Building NaCl trusted code as ARM32 in an ARM64 build
* Building NaCl untrusted code (nexes) as ARM32 in an ARM64 build
Landing this change first allows those to be more easily implemented
and tested in either order.
Bug: 1299021
Change-Id: Ib25ebbe56c91ed735beb87b0b3479b8b7621b389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430407
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#984490}
These private interfaces no longer have any users, now that the PDF
Viewer stopped using PPAPI. Prior CLs deleted most of the related code,
leaving only a minimal implementation. Delete that along with stragglers
that still reference the PDF headers.
Bug: 1302684
Change-Id: I9c2b5e81d8a919f32b069c68ae053d58a02e2710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3502892
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979393}
This change is for “Enable Warnings for Implicit Conversions” project.
There are four steps to complete the project. Step 1. and step 3. are
required to split the change for step 2. into several CLs.
1. Disable prevent_unsafe_narrowing config
2. Add prevent_unsafe_narrowing to default_compiler_configs and remove
the config (`configs -= ...`) only where it is necessary
3. Enable prevent_unsafe_narrowing config again
4. Remove each `configs -= ...` added in step 2. and fix warnings
This is the first CL for step 2, which adds prevent_unsafe_narrowing to
default_compiler_configs and `configs -= ...` to some templates.
It is safe to merge this change with all the CQ bots green because there
should be some error when `configs -= ...` is added in a wrong place.
See the public one-pager for more details of this project:
go/enable-warnings-for-implicit-conversions (https://docs.google.com/document/d/1CTbQ-5cQjnjU8aCOtLiA7G6P0i5C6HpSDNlSNq6nl5E/edit?usp=sharing)
Bug: 1292951
Change-Id: I841517691b31d0d8e54965268a177c46e0ff7f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3488757
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976177}
GetList() will be reimplemented in a future CL with an updated
signature, so existing uses need to be renamed out of the way.
Unlike TakeList() and TakeDict(), GetList() is used quite widely. This
CL migrates a number of uses using the following set of automated steps:
sed -i "s|\.GetList()|.GetListDeprecated()|g" \
$(git gs "GetList()" --name-only)
git checkout -- base/values.cc base/values.h
git checkout -- base/values_unittest.cc third_party/dom_distiller_js
git checkout -- tools/clang
git cl format
Bug: 1291666
Change-Id: I0413b4857cbf38943333988e36da53f44aab7a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435727
Reviewed-by: danakj chromium <danakj@chromium.org>
Commit-Queue: danakj chromium <danakj@chromium.org>
Owners-Override: danakj chromium <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966793}
This is dead code, so the change itself hasn't been exercised.
This CL is simply removing the reference to a soon to be
deprecated flag.
Bug: chromium:1060139
Change-Id: I07fddec29404c3e366d57f1e2a9fb4c23a23bc5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3383879
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#959412}
This removes NonSFI support from ppapi/nacl_irt.
Specifically, this directory is built with OS_NACL_SFI only now,
so the build conditions are redundant.
BUG=b/200965779,1273132
TEST=Ran tryjob.
Change-Id: I003d52d77a25611ddceacb3962cbf5a01fc36504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330445
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951333}
This change is to remove the dependency of the PPAPI test
(which is compiled with old NaCl compilers) on Chrome/IPC code
(which will soon be C++17).
It is intended to test use of many file descriptors for DSOs in
manifests, which is used for ARC in particular (see rev
eaa3c5bf9a).
It tests a number of file descriptors larger than the limit
for a single IPC message, but that limit was reduced to 7
a long time ago; also ARC is being turned down, so performance
of loading huge numbers of DSOs is no longer important. But there
are still apps with DSOs, so rather than removing the test entirely,
reduce the test to cover a smaller set of descriptors.
Removes a little over 3000 build actions from the build.
Bug: 812058,1106311,1269607
Change-Id: Iec5168f57046d38c7f5528fb1fea600e160e1460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299468
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945246}
Removes `#include "base/macros.h"` from remaining .cc, .h and .mm files
that do not contain `ignore_result(` and do not trigger pre-commit or
pre-upload errors.
Bug: 1010217
No-Try: true
Change-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941054}
This replaces all remaining DISALLOW_COPY_AND_ASSIGN() instances with
their expanded counterparts.
The macro definitions and IWYU are left as a separate change. The former
to prevent unintended large reverts and the latter is easier once all
DISALLOW_ macros are gone.
Bug: 1010217
Change-Id: I0e2fd43f4060628c09420709010aab2c84b87148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259964
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#938612}
This removes the macro definition and presubmit checks and all existing
instances are inlined.
IWYU is left as a separate step until all DISALLOW_* macros are removed.
Bug: 1010217
Change-Id: Ibc4d90d6a1f244a01e65cd3c5a9c50e5419ea5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3257088
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937250}
ppapi::kPluginPrivateRootName -> storage::kPluginPrivateRootName
This constant is still used, but has been moved to further decouple
the Plugin Private File System from PPAPI. When the PPFS backend code
is removed, this constant will naturally be removed with it.
Bug: 1231162
Change-Id: If59c1ea252a67d85e6e0edd935f272200180e71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243122
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937137}
This correction is needed for ICU70 which lazy build the
internal break iterator instead of during constructor therefore
shift the return of U_USING_DEFAULT_WARNING in status
from usearch_open() to usearch_next(). Instead of explicitly
check different possible status code the DCHECK should just
use ICU macro U_SUCCESS() instead.
This change is needed to land to unblock the landing of ICU70
which have https://github.com/unicode-org/icu/pull/1473
that shift the returning of U_USING_DEFAULT_WARNING in status.
Bug: 1260116
Change-Id: Id78dae09d64d19d0c7840287033da75d93f7845a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225780
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932111}
This patch renames `GURL::GetOrigin()` to
`GURL::DeprecatedGetOriginAsURL()`. A subsequent patch will
reintroduce a `GURL::GetOrigin()` that returns a `url::Origin`
rather than a `GURL`.
This patch was brought to you by sed, followed by a little manual
work to deal with look-alike methods (most notably
`CascadePriority::GetOrigin()` and `NudgeTracker::GetOrigin()`) and
two or three spots that held pointers to GURLs:
```
git grep -n -l ".GetOrigin(" | \
xargs -L1 sed -i '' \
-e 's/\.GetOrigin(/.DeprecatedGetOriginAsURL(/g'
```
Bug: 512374
Change-Id: I03fb290650b8759d9849af0911cad9bdc92a5132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220292
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931431}
This CL was generated by using tools/git/move_source_file.py to change
the includes for those files:
base/bind_post_task.h
base/deferred_sequenced_task_runner.h
base/post_task_and_reply_with_result_internal.h
base/sequenced_task_runner.h
base/sequenced_task_runner_helpers.h
base/single_thread_task_runner.h
base/task_runner.h
base/task_runner_util.h
base/updateable_sequenced_task_runner.h
Then formatted using "git cl format". DEPS files were fixed with a
simple search and replace script.
Bug: 1255932
Change-Id: I0d9b5ddd9260fde5e4581e6c6e0080bdb0ed2c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209175
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929867}
