0
Commit Graph

4146 Commits

Author SHA1 Message Date
6a0dd3fdc5 Fix V8 shepherd link.
Change-Id: Idbe2b43c44a14521ab5977f24ca277a3bd456363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624582
Auto-Submit: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1160076}
2023-06-20 16:22:23 +00:00
2154274a2a Clarify fsmonitor instructions
This change removes references to git versions since Chromium developers
should be using git from depot_tools, and since it isn't completely
clear whether 2.39 is greater or lower than 2.8.

This change also makes it clear that fsmonitor should be enabled on a
per-repo basis rather than globally, for the best cost/benefit ratio.

This change was inspired by the realization that enabling fsmonitor
globally on Windows caused 179 fsmonitor process to be spawned when
"gclient sync" was run. These processes commit an average of 86 MB
on Windows leading to 15 GB of commit (only a few hundred MB of
physical memory is used, but the commit usage is large enough to
matter).

Change-Id: I21c042462022088e11883bbf827276ee585fdaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622567
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1159338}
2023-06-17 22:24:29 +00:00
5c08d795fd docs: webui_build_configuration: add missing option
Other sections in here refer to this one for the meaning of
resource_path_prefix, but never actually documents it.

Bug: b/284974354

Change-Id: I4b880f3ac698e38953b62b28c432e22cdee02c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605236
Reviewed-by: Cole Horvitz <colehorvitz@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1159007}
2023-06-16 19:20:58 +00:00
4637eec444 Update the link to the internal Blink.UseCounter doc
Bug: b/276918116
Change-Id: Ib5230133a1384e7e572bb0164ec98d2f23e81de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618191
Commit-Queue: Sun Yueru <yrsun@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158872}
2023-06-16 16:02:01 +00:00
add4d331c5 Document ClusterFuzz gesture language.
Bug: 1361342
Change-Id: Ib8a2c489767ca3354478d550f14f8cc0b1470e68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597282
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Auto-Submit: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158867}
2023-06-16 15:47:14 +00:00
c7d10e6cd0 Add motionmark and jetstream2 tests to pgo.md
Bug: 1455237
Change-Id: I7fe3f043f36f5fc023773329fbcc47ef1a00a500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615349
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158473}
2023-06-15 22:33:00 +00:00
5fa3548794 Updater: Adjust modecheck & overinstall logic.
This should help prevent cases where updaters that are too broken to
answer GetVersion but still working enough to run ModeCheck race against
a new install and take over as active.

Bug: 1369264
Change-Id: I39dcc1c6ce2266a6d22075faad7eac0377ddf48e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615181
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158352}
2023-06-15 19:20:57 +00:00
2fba525ab5 Update VS Code Java formatter instructions
Turns out that `git cl format` uses clang-format to format Java code,
and the current instructions using JDT would produce formatting that can
be quite different. Fix the instructions to make VS Code format Java
files in the exact same way `git cl format` does.

Change-Id: I7d0476bf9c2d84d2c9dfe3ca13be4811079d45b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614846
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Auto-Submit: Etienne Dechamps <edechamps@google.com>
Cr-Commit-Position: refs/heads/main@{#1158331}
2023-06-15 18:39:45 +00:00
59edafe2ab [a11y] Add a Feature for the UIA provider on Windows
Replace the `enable-experimental-ui-automation` switch with a
disabled-by-default `UiaProvider` feature. Users must now start the
browser with `--enable-features=UiaProvider` rather than
`--enable-experimental-ui-automation` if they wish to manually enable
the provider.

As a consequence, tests that added the old switch to the process command
line to enable the provider now use a ScopedFeatureList.

Bug: 845471,1453247
Change-Id: I92cd8248486b29aad8c887a0dd141da8b546d6b8
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604052
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158014}
2023-06-15 08:05:16 +00:00
761687acc3 Remove references to Gnome Keyring in //docs
R=thestig

Change-Id: I4bda56ba4328a590e06e43fadbc3c461eec1407f
Bug: 355223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607551
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1157637}
2023-06-14 17:27:39 +00:00
15dff9ddd4 Doc: add instructions to run code coverage locally.
Bug: 1327486
Change-Id: Iffbf168f72c7a58adfe2ecd172f569120622fe78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609459
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156590}
2023-06-13 00:38:45 +00:00
68e0fd009e Update the ARC documentation to point out a danger
Bug: 1280317
Change-Id: I4869af5a89e177f71d012c68c604e63ffe4f8a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604441
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156389}
2023-06-12 20:11:39 +00:00
e5812599b0 Updater: Periodically check the server for idleness and shut down if so.
Fixed: 1451862
Change-Id: I3e81ea30fd8be791fc220ae6c6269f2f7274d980
Low-Coverage-Reason: Covered by IT.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602269
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156269}
2023-06-12 17:24:54 +00:00
2d40c5554e Improve Visual Studio Code Java setup
This CL introduces a new way to set up VS Code to edit Java code in
Chromium. It makes it possible for the Java language server to
successfully build .java files in a way that is (mostly) identical to
the way the Chromium build system builds them, and without relying on a
manually curated Eclipse classpath file. This makes it possible to use
the full potential of the VS Code Java extension including full semantic
analysis, real-time reporting of build errors, etc.

Change-Id: I3a8e7260216a029936b9a684d64814da43dfb307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604730
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Etienne Dechamps <edechamps@google.com>
Auto-Submit: Etienne Dechamps <edechamps@google.com>
Cr-Commit-Position: refs/heads/main@{#1156225}
2023-06-12 15:52:24 +00:00
a9bbed86ff Recognize un-sandboxed nature of GPU process.
The GPU process is not sandboxed on some platforms (specifically, it has
the same sandbox as the browser process on Android). It's not correct,
and has never been correct, to treat GPU process bugs as if they are
fully sandboxed.

Change-Id: If1241f38c1a4db1a381e994bdc359a930427c9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604071
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156160}
2023-06-12 13:35:43 +00:00
650834a3d6 Fixup typo in add_new_policy.md
Change-Id: Ia1992a47cdd9693e12d6dadec8fd5290b61b4c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606173
Auto-Submit: Owen Min <zmin@chromium.org>
Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org>
Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156151}
2023-06-12 13:08:37 +00:00
cc6e22796c [docs] Update broken buildbot link in win_cross.md
Bug: none
Change-Id: Ia87c5f7359722583b4f7e8ef6d2164af71fcc93b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604230
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1155476}
2023-06-09 12:52:30 +00:00
fa3a0c98ab docs: webui_build_configuration: improve readability
Fix a typo, improve local link to OWNERS file, and change the desc
text from code literal to normal readable text so it renders better.

Bug: b/284974354
Change-Id: I3413991f601d4c8a7ae4c7b760eefa42333c194c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598188
Reviewed-by: Cole Horvitz <colehorvitz@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1154732}
2023-06-08 02:33:01 +00:00
c2e7afa50a Move NDK to CIPD-based //third_party/android_toolchain
Move all references from //third_party/android_ndk to the new
CIPD-based //third_party/android_toolchain.

Bug: 1448383
Test: CQ
Change-Id: I83e085035c4eb71229e69ebe29de7f0598606c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575445
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Prashanth Swaminathan <prashanthsw@google.com>
Cr-Commit-Position: refs/heads/main@{#1154515}
2023-06-07 18:12:33 +00:00
c2fedad34b android_binary_size_trybot.md: Add note about failing autorollers
Bug: None
Change-Id: I68e70f215de13c3a264420fc4117d402e528e91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594538
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1154383}
2023-06-07 13:46:20 +00:00
519e669f8b Rewrite V8 shepherding instructions.
As discussed and agreed with V8 security team.

Change-Id: I4edde2f1cd04191c97b37f34a972483543bf276a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4517525
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153826}
2023-06-06 14:11:03 +00:00
5350ed11c9 Update all sensitive policies descriptions
Make all sensitive policies have same descriptions except two for
extension force installed which only covered non-CWS extensions.

The statement is also added into `description_guidelines.md` for
future usage.

Remove sensitive policies description for the `URLAllowlist` policy
because there is no such check for it.

Also
 * Create default value field for some policies.
 * Fix indent for all policies that are modified here.

Bug: 1446691
Change-Id: Iee4d73c7b84d36813e186d85cadf4b4adb24fea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585045
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153815}
2023-06-06 13:53:15 +00:00
9d31eda35a Update mac_lld.md with current status
* We've been shipping with lld for a while now
* ICF works
* LTO works
* Call-graph sorting exists and works
* ld64 got faster in Xcode 14.1

Change-Id: I9d0b4172a5062c2b2ce6320310d61b711f8295ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4097505
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153334}
2023-06-05 17:54:06 +00:00
9f4dc0676b Added the Event Timing Key_interaction_state_machine
The current Key_interaction_state_machine focuses only on the SetKeyIdAndRecordLatency algorithm.

The key events state diagram illustrates how the interaction ID is
calculated for keyboard events. It provides a visual explanation of grouping EventTiming keyboard events.

Bug: 1449265
Change-Id: I64173b874a023af610dccc7cc56372d059aec1c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573349
Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org>
Commit-Queue: Aoyuan Zuo <zuoaoyuan@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153202}
2023-06-05 14:07:49 +00:00
3fe4b9c0ac [Doc] Define "dangling" pointer.
I got the feedback we do not define what is a dangling pointer. This
patch addresses it.

Bug: None
Change-Id: I8566018ade7311c1ebc34246a8122639bcf92b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4454582
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152454}
2023-06-02 11:50:38 +00:00
40def48455 PRESUBMIT.py: remove USE_PYTHON3 = True
presubmit now uses python3 only.

This is generated by
$ rg -l '^USE_PYTHON3 = True' | \
  xargs sed -z -i "s/\n*USE_PYTHON3 = True\n*/\n\n/"
with some more modifications.

This also removes run_on_python2, run_on_python3, and skip_shebang_check
args.

Bug: 1207012
Change-Id: I8c842d0a9ac485a27399d704a17b755f58a64db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573952
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152319}
2023-06-02 02:23:49 +00:00
d764384fa7 Add standalone offline install support to the meta-installer
Offline installers are currently possible but only if the
`--offlinedir={GUID}` switch is provided. To be able to support
standlone offline installers, it must be possible to run an offline
installer with no switches.

To support this, the meta-installer now searches for an offline install
directory at `bin\Offline\{GUID}` in the directory the embedded
`updater.7z` is extracted to. If it finds one it appends an
`--offlinedir={GUID}` switch to the command line used to run
`updater.exe` indicating an offline install should be performed using
the directory it found.

Bug: 1281688
Change-Id: Idd1e085a781ba248321acd4b15bfbcfa7f257f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573758
Commit-Queue: S Ganesh <ganesh@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152048}
2023-06-01 19:20:55 +00:00
f38e2c690b Documentation on how to configure the build.
Also includes some brief troubleshooting advice, links to the CLI doc
section of the functional spec in the other parts of the documentation
where someone might reasonably expect to find those usage instructions,
and a stub about what the various build outputs are.

This was all stuff I had to ask about or independently dig up when
getting (re)started with updater development.

Bug: 1448709
Change-Id: I1cee0e98c335bc7c48072b53172ee003bda23b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4563059
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Adam Norberg <norberg@google.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152022}
2023-06-01 18:36:46 +00:00
8ecd16fd40 Reland WebUI: Enforce convention for manifest filenames.
This is a reland of crrev.com/c/4562723

This CL fixes a reference to the outputted manifest file of
merge_js_source_maps().

Prior to this change, some targets output manifests to *.manifest, while
others output to *_manifest.json. This CL conforms all usages
to the latter convention. Notably, ts_library() was changed to output
manifests to ${target_name}_manifest.json by default.

This is the better convention as it preserves the filetype. This has
benefits in the context of highlighting in editors as well as improving
code clarity.

Change-Id: Ie3fc8575a635c591bfc25d14323832025095231f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576506
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151585}
2023-06-01 00:47:22 +00:00
27b059622d Update RE2 stance to allow untrusted patterns
As we said in https://crrev.com/c/3209461, we chose to err on the
conservative side until we had more instances where we might need
to deal with untrusted patterns. We've now seen some cases like
that, and looking at how some other teams at Google expose RE2 this
seems like an appropriate risk tradeoff.

Change-Id: I97ad3ac03b41d8bf8e733be01f8ca53f3989b8e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575173
Commit-Queue: Matthew Riley <mattdr@google.com>
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Auto-Submit: Matthew Riley <mattdr@google.com>
Cr-Commit-Position: refs/heads/main@{#1151519}
2023-05-31 22:43:56 +00:00
197b492ab7 Clarify compile_commands.json command in the clangd Quick Start.
Several engineers all independently missed a critical step while setting
up clangd for VSCode, and each encountered the same issue - missing
headers, as highlighted at
https://clangd.llvm.org/troubleshooting.html#cant-find-includes-within-your-project.
This is an easy mistake to make while copying/pasting lots of commands
during the setup process. Simplified and clarified this step a bit.

Change-Id: I6f7c909724f302b622b172d7e05c575910db1f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573756
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1151417}
2023-05-31 19:26:33 +00:00
1623df1518 [Android] Use FeatureMap to generalize ContentFeatureList
This reduces code duplication in ContentFeatureList.java and
content_feature_list.cc, reusing the code in base
FeatureMap.java and feature_map.cc.

ContentFeatureList is kept for convenience static methods to
access ContentFeatureMap, but we can inline and update callers in
a follow-up if desired.

Also add a TODO to ContentFeatureList since I noticed the constants
there with feature names largely overlap with the constants in the
generated ContentFeatures.

Using this opportunity to update documentation
(since ContentFeatureList is used as an example) with the new
FeatureMap API.

Change-Id: I2360830bfbceff20714fc65db4dce5ef743ab95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544343
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151372}
2023-05-31 18:23:35 +00:00
3c65cd4902 [docs] clang_sheriffing.md -> clang_gardening.md
Chromium is renaming sheriffing to gardening:
https://groups.google.com/a/chromium.org/g/chromium-dev/c/_HKudNO1zPE/m/2vc8imguAAAJ

Bug: 1444839
Change-Id: I947799ba96e48d312d08be5e9eaa504860de5c7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547500
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151341}
2023-05-31 17:46:08 +00:00
d0f90c9d31 doc: Fix link to gdbinit.md & lldbinit.md on linux/debugging.md
- Fix the broken link to gdbinit.md & lldbinit.md on linux/debugging.md.
- Additionally, replace the absolute link to gdbinit.md with a relative
  link to maintain notation consistency with the other links in this
  doc.

Bug: n/a
Change-Id: Idc275f63de05264b66d0fbe022f26dc0e0b63599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573957
Auto-Submit: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150998}
2023-05-31 00:55:23 +00:00
1f8b00067c Update links from Security FAQ to Web Platform Security Guidelines
One link was broken and one was outdated.

Change-Id: Ia56ff52bf7f330fec487318d4a0f4daa8cb174ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575187
Auto-Submit: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150985}
2023-05-31 00:38:49 +00:00
d168e09e85 Revert "WebUI: Enforce single naming convention for manifest files."
This reverts commit 0ee133da5d.

Reason for revert:
LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8779630082027991633

Sample failed build: https://ci.chromium.org/b/8779630082027991633

If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8779630082027991633&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4562723

Original change's description:
> WebUI: Enforce single naming convention for manifest files.
>
> Prior to this change, some targets output manifests to *.manifest, while
> others output to *_manifest.json. This CL conforms all usages
> to the latter convention. Notably, ts_library() was changed to output
> manifests to ${target_name}_manifest.json by default.
>
> This is the better convention as it preserves the filetype. This has
> benefits in the context of highlighting in editors as well as improving
> code clarity.
>
> Change-Id: I67509fbc0f4e7caddf2cbbdf905aa3ac17710e59
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562723
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1150707}
>

Change-Id: I37b3625537e1553bcec3b45579383971d4380f81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575466
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1150954}
2023-05-30 23:48:32 +00:00
f770978461 Add username mapping for liza@
BUG=None

Change-Id: I715b13aaf6f1e7020019d0035c7cf3c0e76dfd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4572639
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150937}
2023-05-30 23:13:55 +00:00
0ee133da5d WebUI: Enforce single naming convention for manifest files.
Prior to this change, some targets output manifests to *.manifest, while
others output to *_manifest.json. This CL conforms all usages
to the latter convention. Notably, ts_library() was changed to output
manifests to ${target_name}_manifest.json by default.

This is the better convention as it preserves the filetype. This has
benefits in the context of highlighting in editors as well as improving
code clarity.

Change-Id: I67509fbc0f4e7caddf2cbbdf905aa3ac17710e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562723
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150707}
2023-05-30 18:34:59 +00:00
760b0c0362 Note git fsmonitor in documentation for iOS also
Bug: None
Change-Id: Ib7e6b10965b9bcd5c4b51e3119ce3c3471699567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573501
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Tiago Vignatti <tvignatti@igalia.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150320}
2023-05-29 19:45:24 +00:00
c0f6793aca Note git fsmonitor in documentation
Bug: none
Change-Id: Iae166494eb3cbce14be6510b6915cf808533733f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566415
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149857}
2023-05-26 19:22:44 +00:00
a127340f6c Simplify lifetime reasoning of AppController: it's a singleton
Make AppController be a singleton and to always be the
NSApp delegate. This simplifies reasoning about the code.

Bug: 1280317
Change-Id: Iebddee9077c9ec4f786a3e3307a10e812a187457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566530
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1149854}
2023-05-26 19:17:43 +00:00
f5bfe3c345 Mandatory enrollment support is needed on Windows only.
Checked the original documentation and Keystone's implementation, looks
we don't need mandatory enrollment support on macOS at this time. We
can change this behavior if new request is made.

Bug: 1345407
Change-Id: I0db62e5b9843351fc92cfd749835171e76c25af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571240
Auto-Submit: Xiaoling Bao <xiaolingbao@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1149827}
2023-05-26 18:29:46 +00:00
3aafdb20f6 Fix clang_format -> clang-format.
Bug: 1447924
Change-Id: If8534649c05d95b87c10afac383f45633699db2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567226
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149721}
2023-05-26 15:03:31 +00:00
28bba1f26a Work around DIR_PROGRAM_FILES6432 gets C:\Program Files (x86) on Arm64
This CL works around issue 1448952 that calling `base::PathService::Get`
with `DIR_PROGRAM_FILES6432` gets `C:\Program Files (x86)` instead of
`C:\Program Files` for an `x86` process on `Arm64`.

Bug: 1448952
Change-Id: I79ad9d70d2b2cd8c1726748b970639c1e50307d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567072
Auto-Submit: S Ganesh <ganesh@chromium.org>
Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org>
Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149318}
2023-05-25 20:06:26 +00:00
1419175c9c Fix summary table for configuration options
Fix summary table to match prose.

Bug: 1444202
Change-Id: I5f14b494906562cadcf8f0ddd363451315f6f6d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4558828
Commit-Queue: Eric Lawrence <ericlaw@microsoft.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148846}
2023-05-25 00:02:17 +00:00
e368f0d138 WebUI: Leverage minify_js() and bundle_js() in optimize_webui.gni.
This CL maintains the optimize_webui() build rule, but refactors it to
use bundle_js() and minify_js(). Since optimize_webui.py is no longer
used, the file has been removed along with optimize_webui_test.py.

This CL also modifies minify_js() to take in out_manifest as an
optional argument, to specify where to save the manifest. If none is
specified, the manifest will default to ${target_name}_manifest.json.
This is because several usages of optimize_webui() need to pass in
a manifest path. As such, explicit references to the previous
minify_js_manifest.json have been updated to reference the new filename.

Bug: 1431253
Change-Id: I056a8820ef085ec73c4dec6014e3b56791150357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489793
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148842}
2023-05-24 23:56:13 +00:00
e444505628 Add new clang_format/scripts/ path in chromium/src.
Bug: 1447924
Change-Id: I689fd2c838e3e41fce9e6adb3976db5466f69ba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4553897
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148030}
2023-05-23 17:54:19 +00:00
d6d7ab9c74 Preventing a dangling ExtensionRegistrar::extension_system_.
When `KeyedService`s are getting destroyed, their dependencies might
already be gone (and pointers to such dependencies might be dangling).
As documented in //components/keyed_service/core/keyed_service.h
"two-phase shutdown allows keyed services to have a first pass shutdown
phase where they drop references".  This was discussed in the following
(Google-internal, sorry) email thread:
https://groups.google.com/a/google.com/g/chrome-memory-safety/c/kLaT9TsZyS8/m/9t5KGRnvBQAJ

Bug: 1444204
Change-Id: If69aaddafccd3be331045686c71fd40ae884d1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4550894
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147993}
2023-05-23 17:16:08 +00:00
8ca0146898 WebUI: Allow custom out folder in bundle_js().
Bug: 1431253
Change-Id: I812b79460d4025a603c9f6990f87cba165ac09b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546324
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1147364}
2023-05-22 18:34:11 +00:00
312d681c63 Doc: add how to handle interactive login is required error from mb.
Bug: 1327486
Change-Id: Iac19e130360902f5ec2790376c73a821ab7876f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4550398
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Xiaoling Bao <xiaolingbao@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1146814}
2023-05-20 01:16:55 +00:00