This change removes references to git versions since Chromium developers
should be using git from depot_tools, and since it isn't completely
clear whether 2.39 is greater or lower than 2.8.
This change also makes it clear that fsmonitor should be enabled on a
per-repo basis rather than globally, for the best cost/benefit ratio.
This change was inspired by the realization that enabling fsmonitor
globally on Windows caused 179 fsmonitor process to be spawned when
"gclient sync" was run. These processes commit an average of 86 MB
on Windows leading to 15 GB of commit (only a few hundred MB of
physical memory is used, but the commit usage is large enough to
matter).
Change-Id: I21c042462022088e11883bbf827276ee585fdaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622567
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1159338}
Turns out that `git cl format` uses clang-format to format Java code,
and the current instructions using JDT would produce formatting that can
be quite different. Fix the instructions to make VS Code format Java
files in the exact same way `git cl format` does.
Change-Id: I7d0476bf9c2d84d2c9dfe3ca13be4811079d45b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614846
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Auto-Submit: Etienne Dechamps <edechamps@google.com>
Cr-Commit-Position: refs/heads/main@{#1158331}
Replace the `enable-experimental-ui-automation` switch with a
disabled-by-default `UiaProvider` feature. Users must now start the
browser with `--enable-features=UiaProvider` rather than
`--enable-experimental-ui-automation` if they wish to manually enable
the provider.
As a consequence, tests that added the old switch to the process command
line to enable the provider now use a ScopedFeatureList.
Bug: 845471,1453247
Change-Id: I92cd8248486b29aad8c887a0dd141da8b546d6b8
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604052
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158014}
This CL introduces a new way to set up VS Code to edit Java code in
Chromium. It makes it possible for the Java language server to
successfully build .java files in a way that is (mostly) identical to
the way the Chromium build system builds them, and without relying on a
manually curated Eclipse classpath file. This makes it possible to use
the full potential of the VS Code Java extension including full semantic
analysis, real-time reporting of build errors, etc.
Change-Id: I3a8e7260216a029936b9a684d64814da43dfb307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604730
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Etienne Dechamps <edechamps@google.com>
Auto-Submit: Etienne Dechamps <edechamps@google.com>
Cr-Commit-Position: refs/heads/main@{#1156225}
The GPU process is not sandboxed on some platforms (specifically, it has
the same sandbox as the browser process on Android). It's not correct,
and has never been correct, to treat GPU process bugs as if they are
fully sandboxed.
Change-Id: If1241f38c1a4db1a381e994bdc359a930427c9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604071
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156160}
Fix a typo, improve local link to OWNERS file, and change the desc
text from code literal to normal readable text so it renders better.
Bug: b/284974354
Change-Id: I3413991f601d4c8a7ae4c7b760eefa42333c194c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598188
Reviewed-by: Cole Horvitz <colehorvitz@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1154732}
Make all sensitive policies have same descriptions except two for
extension force installed which only covered non-CWS extensions.
The statement is also added into `description_guidelines.md` for
future usage.
Remove sensitive policies description for the `URLAllowlist` policy
because there is no such check for it.
Also
* Create default value field for some policies.
* Fix indent for all policies that are modified here.
Bug: 1446691
Change-Id: Iee4d73c7b84d36813e186d85cadf4b4adb24fea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585045
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153815}
* We've been shipping with lld for a while now
* ICF works
* LTO works
* Call-graph sorting exists and works
* ld64 got faster in Xcode 14.1
Change-Id: I9d0b4172a5062c2b2ce6320310d61b711f8295ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4097505
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153334}
The current Key_interaction_state_machine focuses only on the SetKeyIdAndRecordLatency algorithm.
The key events state diagram illustrates how the interaction ID is
calculated for keyboard events. It provides a visual explanation of grouping EventTiming keyboard events.
Bug: 1449265
Change-Id: I64173b874a023af610dccc7cc56372d059aec1c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573349
Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org>
Commit-Queue: Aoyuan Zuo <zuoaoyuan@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153202}
Offline installers are currently possible but only if the
`--offlinedir={GUID}` switch is provided. To be able to support
standlone offline installers, it must be possible to run an offline
installer with no switches.
To support this, the meta-installer now searches for an offline install
directory at `bin\Offline\{GUID}` in the directory the embedded
`updater.7z` is extracted to. If it finds one it appends an
`--offlinedir={GUID}` switch to the command line used to run
`updater.exe` indicating an offline install should be performed using
the directory it found.
Bug: 1281688
Change-Id: Idd1e085a781ba248321acd4b15bfbcfa7f257f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573758
Commit-Queue: S Ganesh <ganesh@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152048}
Also includes some brief troubleshooting advice, links to the CLI doc
section of the functional spec in the other parts of the documentation
where someone might reasonably expect to find those usage instructions,
and a stub about what the various build outputs are.
This was all stuff I had to ask about or independently dig up when
getting (re)started with updater development.
Bug: 1448709
Change-Id: I1cee0e98c335bc7c48072b53172ee003bda23b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4563059
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Adam Norberg <norberg@google.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152022}
This is a reland of crrev.com/c/4562723
This CL fixes a reference to the outputted manifest file of
merge_js_source_maps().
Prior to this change, some targets output manifests to *.manifest, while
others output to *_manifest.json. This CL conforms all usages
to the latter convention. Notably, ts_library() was changed to output
manifests to ${target_name}_manifest.json by default.
This is the better convention as it preserves the filetype. This has
benefits in the context of highlighting in editors as well as improving
code clarity.
Change-Id: Ie3fc8575a635c591bfc25d14323832025095231f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576506
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151585}
As we said in https://crrev.com/c/3209461, we chose to err on the
conservative side until we had more instances where we might need
to deal with untrusted patterns. We've now seen some cases like
that, and looking at how some other teams at Google expose RE2 this
seems like an appropriate risk tradeoff.
Change-Id: I97ad3ac03b41d8bf8e733be01f8ca53f3989b8e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575173
Commit-Queue: Matthew Riley <mattdr@google.com>
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Auto-Submit: Matthew Riley <mattdr@google.com>
Cr-Commit-Position: refs/heads/main@{#1151519}
This reduces code duplication in ContentFeatureList.java and
content_feature_list.cc, reusing the code in base
FeatureMap.java and feature_map.cc.
ContentFeatureList is kept for convenience static methods to
access ContentFeatureMap, but we can inline and update callers in
a follow-up if desired.
Also add a TODO to ContentFeatureList since I noticed the constants
there with feature names largely overlap with the constants in the
generated ContentFeatures.
Using this opportunity to update documentation
(since ContentFeatureList is used as an example) with the new
FeatureMap API.
Change-Id: I2360830bfbceff20714fc65db4dce5ef743ab95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544343
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151372}
- Fix the broken link to gdbinit.md & lldbinit.md on linux/debugging.md.
- Additionally, replace the absolute link to gdbinit.md with a relative
link to maintain notation consistency with the other links in this
doc.
Bug: n/a
Change-Id: Idc275f63de05264b66d0fbe022f26dc0e0b63599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573957
Auto-Submit: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150998}
Prior to this change, some targets output manifests to *.manifest, while
others output to *_manifest.json. This CL conforms all usages
to the latter convention. Notably, ts_library() was changed to output
manifests to ${target_name}_manifest.json by default.
This is the better convention as it preserves the filetype. This has
benefits in the context of highlighting in editors as well as improving
code clarity.
Change-Id: I67509fbc0f4e7caddf2cbbdf905aa3ac17710e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562723
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150707}
This CL maintains the optimize_webui() build rule, but refactors it to
use bundle_js() and minify_js(). Since optimize_webui.py is no longer
used, the file has been removed along with optimize_webui_test.py.
This CL also modifies minify_js() to take in out_manifest as an
optional argument, to specify where to save the manifest. If none is
specified, the manifest will default to ${target_name}_manifest.json.
This is because several usages of optimize_webui() need to pass in
a manifest path. As such, explicit references to the previous
minify_js_manifest.json have been updated to reference the new filename.
Bug: 1431253
Change-Id: I056a8820ef085ec73c4dec6014e3b56791150357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489793
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148842}