presubmit now uses python3 only.
This is generated by
$ rg -l '^USE_PYTHON3 = True' | \
xargs sed -z -i "s/\n*USE_PYTHON3 = True\n*/\n\n\n/"
with some more modifications.
This also removes run_on_python2, run_on_python3, and skip_shebang_check
args.
Bug: 1207012
Change-Id: I43ac77120dc2456bc065a41750f1f5ddfd88d9e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576841
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152146}
When opening a text file it is important to specify encoding='utf-8'
since otherwise the behavior will depend on your system locale. This
change fixes all the encoding omissions I could find in the tools
directory, found by running "git cl presubmit --all" with
crrev.com/c/4290775 patched in.
Bug: 1418846
Change-Id: Ie4478ff9b3e3814e6396a5b0c3c0e9c273202838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4295846
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1111897}
JSONDataGenerator converts /, ., and - characters to _ when creating
header guards. On Windows it also needs to convert \ characters so this
adds them to the list (on all platforms).
Bug: 1309977
Change-Id: I34c1a152b6b8ba4ca80c4f804f3d5c86008762e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3642625
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Marcello Salomao <msalomao@google.com>
Commit-Queue: Marcello Salomao <msalomao@google.com>
Cr-Commit-Position: refs/heads/main@{#1002502}
This is part of the Files app Recent filter change. We need a new tool
to utilize one or more JSON5 files as data sources and generate files
based on the templates provided.
The usage of this tool is in CL:3469537 where we use a file_types.json5
file as the single source of truth to generate files both in Javascript
and C++ to maintain consistency.
Bug: 1259359
Change-Id: I49af4a770868b2f454b74255fb6291a74f58eb98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473619
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Wenbo Jie <wenbojie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976052}
