Adding the warning message again to just above the gclient file
contents, the first warning has been missed a few times.
Bug: 325928330
Change-Id: I67d625eb21178744542976a19cdf73bfa23aac41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5426233
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Michael Savigny <msavigny@google.com>
Cr-Commit-Position: refs/heads/main@{#1285094}
This is a reland of https://crrev.com/1277898
Reason for reland: b/331404365 is fixed
Projects like V8/WebRTC/Pdfium/etc will also have to:
1. Change DEPS as in this CL
2. Rename instrumented_libraries to instrumented_libs as in this CL
R=thakis,dpranke
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng
Bug: 320564950
Change-Id: Id85151f41cdb44e95f5b6479d59ccbecf184f682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5421930
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282953}
- `nih-dbus-tool` no longer exists, and is no longer needed. Remove it
from the list of packages that need to be installed.
- Run `apt upgrade` after `apt update`, because why not.
- Document several additional build dependencies:
- git so the GN invocation does not fail when trying to exec scripts
that use git
- gyp since several instrumented libraries (e.g. NSS) use gyp
- fakeroot since several instrumented libraries use fakeroot
- Make the command for mounting /dev/shm more copy-pastable.
- Add basic directions for removing chroots.
Bug: 1369167
Change-Id: I89fd7f8bc8e5ec8d621ccdd0a74f4ae1144065be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404471
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279818}
Add docker file, docker installation procedures as per requested by Brian Sheedy in GSoC Mailing List. It installs Ubuntu 22.04, build instructions and persists data on drive.
Change-Id: Id1048d015a3c2d049617d922e94253815a468b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5380520
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279178}
Projects like V8/WebRTC/Pdfium/etc will also have to:
1. Change DEPS as in this CL
2. Rename instrumented_libraries to instrumented_libs as in this CL
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng
Bug: 320564950
Change-Id: I802bce32cc37d0ec9c0081cf08a4f8179293693d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368675
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1277898}
The link for setting up reclient for googlers was actually pointing to the section of
the docs about using reclient, not setting it up. This has led to some
users missing critical setup steps.
Bug: b/308577099
Change-Id: Ic71794db3441a4af8d919deacc4c3f3e7ee37a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4993130
Reviewed-by: Michael Ershov <miersh@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
Cr-Commit-Position: refs/heads/main@{#1217553}
Add support for interactively debugging WPTs with upstream's `wpt run`.
`run_wpt_tests.py --verbose` ensures browser logs are dumped to stdout
so that `debug_renderer` can find the PID to attach to.
Bug: 1440021
Test: ./debug_renderer ./run_wpt_tests.py -t Default
Test: external/wpt/badging/badge-success.https.html
Change-Id: I58323aea67f6232bc28b198b8f18d3d7bb7d8a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4893148
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201810}
We had not updated the docs in a while so there were references
to the Python3 migration and Python3.6 still present in some
places.
This CL updates the docs to refer to the current Python version
(3.8) and removes documentation for the Python3 migration, which
is no longer necessary.
Change-Id: Id59d10d90dbd8ceff0ec8203be5e4dfbdc58c4b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4824013
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1190394}
Currently, the vast majority of chromium builds run on jammy. And
after https://crrev.com/c/4652993, any new builder will automatically
be running on jammy.
So jammy is now the official default for infra jobs. This updates
the docs to mention that, and clarifies them a little since the
statement about "most development" might apply to more than just CI
builds, and we can't be as confident about the OS breakdown outside
of our infra.
Bug: 1412588
Change-Id: I751abf251db9758c0b6c12733a2e06f7a5e3e5c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4654783
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1163837}
- Fix the broken link to gdbinit.md & lldbinit.md on linux/debugging.md.
- Additionally, replace the absolute link to gdbinit.md with a relative
link to maintain notation consistency with the other links in this
doc.
Bug: n/a
Change-Id: Idc275f63de05264b66d0fbe022f26dc0e0b63599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573957
Auto-Submit: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150998}
* Use consistent architecture naming
* Change usage to sysroot-creator.sh {build,upload} <arch>
* Merge sysroot-creator-bullseye.sh into sysroot-creator.sh
since we've only had 1 sysroot for >5 years.
* Remove some unneeded commands like PrintDistro/PrintRelease
* Update references from docs and other scripts
Bug: None
Change-Id: I4809de50a03557df533d1f502f15e5acf793c6a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4535715
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1145773}
This removes a reference to `dcheck_always_on = false` which seems
prevalent through cargo culting. It also removes `is_debug = false`.
Both of these options are implied by `is_official_build` and the latter
is even enforced (`is_debug = true` won't compile with
`is_official_build = true`).
Bug: None
Change-Id: I8cd98694b30d73d7390a409a52aa08d0c1600e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4515157
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141057}
Add a section at the top for build configuration. Move the gdbinit
instructions to the configuration section (it's required before
debugging) and remove the details about why this is required (it's
described on the dedicated page that's linked). Add a link to the
corresponding LLDB page.
Mention flag --gtest_break_on_failure for debugging tests.
Clarify LLDB install (the page used to imply that you had to run apt-get
to get the lldbinit file).
Change-Id: Ib292350ee521bf2bc3c4a836523fe070e4d7694e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482817
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1136698}
In objdump the 5th, 6th, and 7th fields are the VMA, LMA, and file
offset, respectively. These fields are the same for many binaries, but
for recent chrome binaries the VMA and LMA are the file offset + 0x1000.
From recent experience, it appears that gdb is making the calculation
for add-symbol-file based on the VMA, so update the documentation to use
field 5.
Change-Id: Ib49c18abce03a99ce49bc0b4241c3b64b229508a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4455180
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1133426}
If debug_renderer detects that you're running web tests, modifies the
command line flags and adds appropriate run_web_tests flags for
debugging the renderer spawned for individual web tests.
Bug: None
Change-Id: I85980ff57c85738f8ad8d47e83ba9d61d5411e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198115
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109686}
ash::switches::kForceSystemCompositorMode is used to enable system
compositor for mostly testing on ozone platform without a real device.
So, this CL moves it to ui/ozone/public/ozone_switches.h and renames
to ::switches::kEnableRunningAsSystemCompositor for consistency in
naming with ::switches::kDisableRunningAsSystemCompositor.
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Change-Id: I273ac3e8ba63a32ed9e306e975c5c673a4ae79b7
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108574
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yeunjoo Choi <ychoi@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1087072}
This adds the --wait-for-debugger-on-navigation flag which pauses
renderers when the target URL is known displaying a message for
each. The debug_renderer script is also updated to automatically
debug the site passed and unblock all other renderer processes.
Documentation in linux/debugging.md is updated to explain how
to use the updated script and flag.
Bug: 730065
Change-Id: I758bf6d10ba9b6a846d216987c20053d4c5ac240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4028699
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1073426}
Adds a short section to the Linux build instructions on getting Chromium
compilation to work in a Docker container. This is not a common setup,
but this should give anyone that does need to use it a good starting
place.
Bug: 1377520
Change-Id: I64b78d2578012faab5070582a28d0dc9c6f41c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4018936
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1069443}
Compiling chromium has higher requirements for device resources than in the past.
Since version 106, some combinations of gn params will trigger
OOM(out of memory) errors under the default settings of the
compiled device.
This error can be solved by adjusting the vm.max_map_count param
of system.
Bug: 1380991
Change-Id: I649e9fbcfccf0576f6d4ff6a8fa4fe8b61549e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4005227
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068964}