chromium/src
0
Fork 0
Code Activity
1,561,125 Commits 3 Branches 23,233 Tags
06c3f41ef96e7261c10699a7b14d4149b6547f08
Commit Graph

55 Commits

Author SHA1 Message Date
Andrew Grieve
1c332f417e nullaway.md: Advice for structs, assertBound(), getTabByIdChecked() 
Also updates How do @NullUnmarked and @SuppressWarnings("NullAway")

Bug: 389129271
Change-Id: Ib734602953f0a52f4c3841ef9d4f91fca7303988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6377565
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436172}
 2025-03-21 11:24:25 -07:00
Andrew Grieve
bcbaa357ad Android: Add @MonotonicNonNull and use it in a few spots 
Support for this annotation was recently added to NullAway. It removes
some uses of assumeNonNull().

Note: It does not yet work with static fields. Reported here:
https://github.com/uber/NullAway/issues/1148#issuecomment-2707363431

Bug: 389129271
Change-Id: I1c24769b48cb381ba6a5974b24d04f2c772d226d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334458
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429766}
 2025-03-07 14:39:27 -08:00
Andrew Grieve
1d3befc1a3 Improve wording of "NullAway Shortcomings" 
Change-Id: I6276dfbda629c4268ee4a206ddb5e7788265b9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6248276
Reviewed-by: Sam Maier <smaier@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418437}
 2025-02-10 18:14:12 -08:00
Andrew Grieve
123c98f0d7 nullaway.md - Add a section on assert, assumeNonNull(), and requireNonNull() 
Bug: 40657579
Change-Id: I8222fc2281069ac91b8b01020258a4c34622f266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221343
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1414360}
 2025-01-31 13:04:52 -08:00
Andrew Grieve
506d5626cb java.md: Update @Nullable section to mention NullAway migration 
Change-Id: Ibda8d853d7509cf9b74d67acc13a59d33f6b544a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6214155
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413130}
 2025-01-29 13:15:55 -08:00
Andrew Grieve
d95bb008c8 nullaway.md: Be more explicit that @NonNull is not used 
Change-Id: Ic5dee044b41867fd64e7e9614b076592a635d169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179936
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#1408224}
 2025-01-17 16:06:15 -08:00
Mohamed Heikal
9aeb46eeb8 Change example method names in nullaway.md to reflect usage 
Some methods are doing the opposite of what their name implies. Change the name to make it less confusing.

Change-Id: I17629dc3098ecea69e4cee144c262c78c6b3e9e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180061
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1407462}
 2025-01-16 11:13:31 -08:00
Andrew Grieve
5c4de79c47 nullaway.md: Mention @Contract bug and migration plan 
Bug: 40657579
Change-Id: I34dd6d412c54fe6ace31bf873bb549dce4f0f2e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6175953
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1407297}
 2025-01-16 06:59:50 -08:00
Andrew Grieve
19c214d287 Android: Add markdown docs about NullAway 
Bug: 40657579
Change-Id: I6c7ffe50b6affa97afceb3f24719eb00ae5c4af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169986
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1406310}
 2025-01-14 12:50:06 -08:00
Andrew Grieve
31928c9844 Reland "Android: Add Error Prone warning against Java stream() apis" 
This reverts commit 8ff33dbc1d.

Reason for reland: Internal fix landed

Original change's description:
> Revert "Android: Add Error Prone warning against Java stream() apis"
>
> This reverts commit e910d272c0.
>
> Reason for revert: crbug.com/344943957#comment13
>
> Original change's description:
> > Android: Add Error Prone warning against Java stream() apis
> >
> > And minor clarifying tweaks to style guide wrt streams
> >
> > Bug: 344943957
> > Change-Id: I90b976866c8f3f71826459b7d3097692e1f533b4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042674
> > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1388426}
>
> Bug: 344943957
> Change-Id: Ib9b3d8db9f47383eaced5192a15e7cac6427da35
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6051419
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Auto-Submit: Keigo Oka <oka@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1388467}

Bug: 344943957
Change-Id: I6668c182aa455972684e6863925c498f494fd11f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055458
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1389041}
 2024-11-27 21:00:13 +00:00
Keigo Oka
8ff33dbc1d Revert "Android: Add Error Prone warning against Java stream() apis" 
This reverts commit e910d272c0.

Reason for revert: crbug.com/344943957#comment13

Original change's description:
> Android: Add Error Prone warning against Java stream() apis
>
> And minor clarifying tweaks to style guide wrt streams
>
> Bug: 344943957
> Change-Id: I90b976866c8f3f71826459b7d3097692e1f533b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042674
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1388426}

Bug: 344943957
Change-Id: Ib9b3d8db9f47383eaced5192a15e7cac6427da35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6051419
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Auto-Submit: Keigo Oka <oka@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388467}
 2024-11-26 21:39:34 +00:00
Andrew Grieve
e910d272c0 Android: Add Error Prone warning against Java stream() apis 
And minor clarifying tweaks to style guide wrt streams

Bug: 344943957
Change-Id: I90b976866c8f3f71826459b7d3097692e1f533b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042674
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388426}
 2024-11-26 20:20:34 +00:00
Alison Gale
3701577c1e Revert "Make TODO style more explicit in the Chromium style guide" 
This reverts commit d82b399572.

Reason for revert: Needs more discussion

Original change's description:
> Make TODO style more explicit in the Chromium style guide
>
> Change-Id: Ia9ae70da8ec056f271630803fe7cfa5751a24129
> Reference: go/crbug-todo-migration
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598198
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Alison Gale <agale@chromium.org>
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1314069}

Change-Id: I94973e4b0715dd3b2130ce77f513920521b92cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5659428
Reviewed-by: Rick Byers <rbyers@chromium.org>
Auto-Submit: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321143}
 2024-06-28 19:47:48 +00:00
Alison Gale
d82b399572 Make TODO style more explicit in the Chromium style guide 
Change-Id: Ia9ae70da8ec056f271630803fe7cfa5751a24129
Reference: go/crbug-todo-migration
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598198
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1314069}
 2024-06-12 16:45:48 +00:00
Andrew Grieve
1210d14523 Android: Add JavaUtils.throwUnchecked() 
A means of reducing binary size and excessive stack trace
"caused by" clauses.

Bug: None
Change-Id: I4705b0b1a7cd712f6c9fa9c73be8822b082b8b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5594290
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1311328}
 2024-06-06 16:31:47 +00:00
Andrew Grieve
f8a603ce1a Reland "Android: Prevent new Robolectric shadows via an allowlist" 
This reverts commit ac9decf100.

Reason for reland: Added @WrappedPath()

Original change's description:
> Revert "Android: Prevent new Robolectric shadows via an allowlist"
>
> This reverts commit 2392f37108.
>
> Reason for revert: Missed @WrappedPath, breaking running tests
> from non-output-directory CWD.
>
> Original change's description:
> > Android: Prevent new Robolectric shadows via an allowlist
> >
> > Bug: b/341267427
> > Change-Id: I7e02f3ef4ef69930579727735acdb40b0581622c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545930
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1303784}
>
> Bug: b/341267427
> Change-Id: I9a9eb119e8b6bb8aff845b9234741ddd9b56239f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554933
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1303949}

Bug: b/341267427
Change-Id: Iaaf6de65f804060b8091aabbe92405817873312b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554143
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303996}
 2024-05-21 20:09:24 +00:00
Andrew Grieve
ac9decf100 Revert "Android: Prevent new Robolectric shadows via an allowlist" 
This reverts commit 2392f37108.

Reason for revert: Missed @WrappedPath, breaking running tests
from non-output-directory CWD.

Original change's description:
> Android: Prevent new Robolectric shadows via an allowlist
>
> Bug: b/341267427
> Change-Id: I7e02f3ef4ef69930579727735acdb40b0581622c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545930
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303784}

Bug: b/341267427
Change-Id: I9a9eb119e8b6bb8aff845b9234741ddd9b56239f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554933
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1303949}
 2024-05-21 19:03:14 +00:00
Andrew Grieve
2392f37108 Android: Prevent new Robolectric shadows via an allowlist 
Bug: b/341267427
Change-Id: I7e02f3ef4ef69930579727735acdb40b0581622c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545930
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303784}
 2024-05-21 15:31:46 +00:00
Nate Fischer
fc38dc8198 Docs: use 4-space indent in Java styleguide 
This is a minor change to rewrite code snippets in
styleguide/java/java.md to use a 4-space indent for Java code snippets.
The codebase already uses a 4-space indent for actual Java code, so it
makes sense that our sample code should follow the real style.

We observed this inconsistency when reviewing
https://crrev.com/c/5447835.

Test: N/A
Change-Id: I76e186d0ce0935b9eb59a296e204a1c94f7913a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479839
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291950}
 2024-04-24 17:07:26 +00:00
Alison Gale
53c77f6b62 Migrate TODOs referencing old crbug IDs to the new issue tracker IDs 
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:

- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)

Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.

#crbug-todo-migration

Bug: b/321899722
Change-Id: Iabdfea2fd5393d6bbc54390ca0c995eb2c55bbaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469882
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290673}
 2024-04-22 15:16:27 +00:00
Jeff Yoon
da738783d6 [buganizer] Migrate DIR_METADATA for styleguide/ 
Migrate all metadata files for styleguide/ and mixins
used by metadata files under styleguide/.

Verify components with http://b/components/{id} or at
go/chrome-on-buganizer-prod-components.

Bug: chromium:1518875
Change-Id: I13148bda62fb83bd21c247b2f7ee2b201fddca4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263231
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
Cr-Commit-Position: refs/heads/main@{#1257063}
 2024-02-06 23:18:55 +00:00
Andrew Grieve
99e388f67c Java Style: Ban Record, @AutoValue. Discourage #toString() 
Also reorganize the sections a bit.

Bug: 1493366
Change-Id: I7cb72ff8fed70cfa60ba8ae9d07cf04f5b9e7f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980185
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219086}
 2023-11-02 20:46:51 +00:00
Andrew Grieve
d99e3c0580 Android: Add presubmit warning to encourage errorprone-style parameter comments 
E.g. instead of
  bar(/* param */ null)
or:
  bar(null /* param */)
it should be:
  bar(/* param= */ null)

So that errorprone will enforce the parameter name is correct.

Bug: None
Change-Id: Ifb9c99d3db392c2fe85e7ff9398ee5dfea9fb0f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4936726
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214851}
 2023-10-25 14:56:48 +00:00
Andrew Grieve
ec82846017 Add //build/android/docs/static_analysis.md 
* Mostly copied from java_toolchain.md, but also updated.
* Updated some references to clang-format to be google-java-format

Bug: None
Change-Id: Id83be7d9810b3658a0060fcc2fda550a731291f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4943173
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210205}
 2023-10-16 15:53:25 +00:00
Andrew Grieve
0873427619 Java Style Guide: Update guidance on asserts 
The guidance on DCHECK vs CHECK changed, so it makes sense to update
Java's assert guidance as well.

https://groups.google.com/a/chromium.org/g/java/c/CVHgcRA967s

Bug: None
Change-Id: Ifb5b6f6b25f112cea2c308ef47d15ac1d1732010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705109
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1174581}
 2023-07-25 01:14:25 +00:00
Andrew Grieve
11c370078d Java styleguide: Add link to go/clank-test-strategy 
Bug: None
Change-Id: I3c8b72e6bf020a1209d75b0d130f62c693ef2dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4675663
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171715}
 2023-07-18 13:46:46 +00:00
Andrew Grieve
e27a4f715b Java style guide - use @VisibleForTesting for test-only constructors 
Bug: None
Change-Id: Ideb862e1c3ef893286f8cdb092088d426f4e44e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4650698
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1165633}
 2023-07-04 15:16:35 +00:00
Andrew Grieve
0872aad0a7 Android: style guide & presubmit for "@VisibleForTesting fooForTesting" 
Also removes mention of `BuildConfig.IS_FOR_TEST`, since it should
rarely be relevant, and isn't really style-related.

Bug: None
Change-Id: I23dab994391292c6857fe4195cdaf743328ebfa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626901
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1162387}
 2023-06-26 14:16:31 +00:00
Andrew Grieve
8d9e40f319 Android: Mention Java 8 Streams APIs in style guide 
Discussion here: https://groups.google.com/a/chromium.org/g/java/c/X-oBLyTLH6M/m/7Vv_Mmp6AAAJ

Bug: None
Change-Id: I72602e7509efe5fda043a7246061739e60fdb43c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4328531
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117743}
 2023-03-15 21:04:42 +00:00
Andrew Grieve
8282bf2369 Java Style Guide: Remove obsolete information 
With the deprecation of Android M support, some things are now
irrelevant.

Bug: None
Change-Id: I55c4251a73dca01946deb6372346cdbdddb51abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4135208
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092480}
 2023-01-13 17:29:17 +00:00
Andrew Grieve
318b3532ab Java Style Guide: Allow broad catches for IPC 
These are common causes of stability bugs.

Also removes obsolete note about multi-catch statements.
These used to be unsupported on old android versions, but
have been supported now for so long that it's a bit odd to
mention them.

Bug: None
Change-Id: I357e8c3a2698deb6b789c22258f39bf421ceb0ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133542
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092427}
 2023-01-13 16:03:23 +00:00
Nate Fischer
03308e9b5d styleguide: propose var keyword for Java styleguide 
This proposes the `var` keyword to be allowed for the chromium Java
style guide, with some additional guidance for best practices.

Test: Upload to gerrit > open file > click "preview"
Change-Id: I8b65493ecbce056a21f980fc9b66ded3466a367b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3996182
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068196}
 2022-11-07 18:14:59 +00:00
Sam Maier
7452a0d26d Guarding ForTesting call behind compile-time-available IS_FOR_TEST 
Bug: 1322880
Change-Id: I9ed4e49cf07a886ed20b2539ef790db83b065099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3774076
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026333}
 2022-07-20 18:24:35 +00:00
Nate Fischer
4570ebc331 Android: fix styleguide for BuildConfig changes 
No change to logic, only docs. This updates the Java style guide for
BuildConfig.ENABLE_ASSERTS:

* BuildConfig moved to the "org.chromium.build" package in
  https://crrev.com/c/2774858
* DCHECK_IS_ON was renamed to ENABLE_ASSERTS by
  https://crrev.com/c/2731127

Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I414be4b35c08bf8a85d70de6154e2ed0b71ea212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2937883
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889088}
 2021-06-04 00:44:45 +00:00
Carlos Knippschild
f2e58c1dd9 Add Java style guide entry for using IntDef instead of enum. 
Change-Id: Ifa76576d626518f822fcfc3007707ce05fbc8514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2927898
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888708}
 2021-06-03 01:43:37 +00:00
John Palmer
be05130dfd [COIL] Change chromium code search type links to use main rather than master for styleguide 
See this doc: go/chromium-coil-change for more info
    BUG=1210385

Change-Id: I9b7ab9492650ec2d40d825c0a5b7146d3d4f3de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2902875
Auto-Submit: John Palmer <jopalmer@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Owners-Override: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#884419}
 2021-05-19 11:48:35 +00:00
Nate Fischer
74cd25c0d4 Android: use AndroidX classes in styleguide 
This updates the styleguide to recommend androidx.annotation.Nullable
because android.support.* is generally deprecated. We've already
migrated chromium to the AndroidX imports, so this just updates the
styleguide to be in line with our current practices.

This deletes the word "other" from the section header because this is
the only reference I could find to Java annotations.

Test: tools/md_browser/md_browser.py styleguide/java/java.md
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I84a78e3396fc05eeabda1114aab1658593a9be66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593182
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837588}
 2020-12-16 16:17:03 +00:00
Edward Lesmes
07c97c0f0b Add DIR_METADATA files to //styleguide 
Generate DIR_METADATA files and remove metatada from OWNERS files for //styleguide.

Bug: 1113033
Change-Id: Ia223073dc571c11b1bc55eeaba7e8a9d738de16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451392
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814302}
 2020-10-06 18:31:20 +00:00
Bo Liu
9bb53ca112 Mention LifetimeAssert in finalizer styleguide 
Change-Id: Ib1c8c8f6cb1f74c32c543ae84844e634b26fcb79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422428
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809144}
 2020-09-22 00:48:10 +00:00
Dirk Pranke
2c0d2f0045 Update TEAM in OWNERS for build-related directories. 
Now that there's a build@chromium.org list, this CL
updates the various TEAM= entries in the OWNERS files
to reflect that.

R=agrieve@chromium.org, thakis@chromium.org, mark@chromium.org

Change-Id: I8c41a604dd89aa20c9b381090701eff699c1d302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209616
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770658}
 2020-05-20 17:39:31 +00:00
Caitlin Fischer
7776cfd416 Fix the markdown links. 
Bug: 1079253
Change-Id: I886e737cc791f54d8758dbb337a63b51539fc806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188528
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766708}
 2020-05-08 03:15:24 +00:00
Caitlin Fischer
210cfaba30 Tweak Java and C++ test-only documentation. 
Bug: 1079253
Change-Id: I30a45ef2eebcf946eecde0d5806478b4a4c3cbfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186364
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#766552}
 2020-05-07 20:04:30 +00:00
Andrew Grieve
ace8fe8521 Java: Remove no-longer-true note about stateless lambdas 
Bug: 952833

Change-Id: Ic091cb7cc1b0d619cd38f8e80de8201a66166f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173084
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763818}
 2020-04-29 14:55:45 +00:00
Yun Liu
f40227d9c8 Fix import order issue for androidx 
Bug: 948803
Change-Id: I61de64544305af054571c3aa5f535a8b95f611a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542137
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#647808}
 2019-04-04 17:37:46 +00:00
agrieve
16c6fe8960 java.md: Add text about finalizers to style guide 
Based on java@ discussion:
https://groups.google.com/a/chromium.org/d/topic/java/9WZLCc14oss/discussion

Bug: 149440
Change-Id: Ie36166fe2282af564daafb13fbcb91af1a4ab6c1
Reviewed-on: https://chromium-review.googlesource.com/c/1344889
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611176}
 2018-11-27 17:47:49 +00:00
agrieve
467c108f1e Java Style Guide: Call out that stateless lambdas are special. 
Change-Id: I94c4c9fb89e6e33f2f87345218607a1ea772d800
Reviewed-on: https://chromium-review.googlesource.com/1212564
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589572}
 2018-09-07 17:44:08 +00:00
agrieve
50430de07a Java style guide: Avoid extraneous strings in Exceptions. 
Change-Id: I34b87a55631eda7a76c5291c95444848c051b6cf
Reviewed-on: https://chromium-review.googlesource.com/1175861
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583309}
 2018-08-15 17:49:16 +00:00
agrieve
398286b617 Java Style Guide: Logging, Support Annotations 
Plus re-ordered content a bit.

Change-Id: I363ffcb5c2a4cb36afcb980503a12564d9e7199b
Reviewed-on: https://chromium-review.googlesource.com/1162112
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583120}
 2018-08-15 01:44:45 +00:00
agrieve
0e6bdf2db2 Add Desugar gotchas to java style guide. 
Change-Id: Ic00b45ead72fcaa0ec0d90d2188a9447e8bf6e02
Reviewed-on: https://chromium-review.googlesource.com/1160782
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580537}
 2018-08-03 14:25:24 +00:00
Samuel Huang
3b10f2dff0 [Styleguide] Fix Java comments on assert. 
Discussion thread:
https://groups.google.com/a/chromium.org/d/topic/java/CpIn_jDOgRk/discussion

Bug: 
Change-Id: I3331d3180d9ee88993c942ef20d045f545ff4cbc
Reviewed-on: https://chromium-review.googlesource.com/671025
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502606}
 2017-09-18 17:43:23 +00:00