chromium/src
0
Fork 0
Code Activity
1,441,209 Commits 3 Branches 23,233 Tags
0d3ea0a54ae56a5fe217e963dcc2976c595add0f
Commit Graph

9 Commits

Author SHA1 Message Date
Avi Drissman
8ba1bad80d Update copyright headers in components/ 
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
No-Presubmit: true
Bug: 1098010
Change-Id: If6a3370b0b2849d889ce797596fe1ccbad2f3fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891619
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046502}
 2022-09-13 19:22:36 +00:00
Roland Bock
e5346551e4 Reland "Remove PrefService::Get" 
This is a reland of commit 0dbb10a87d

The code that caused the revert was migrated in
crrev.com/c/3798165/4..5


Original change's description:
> Remove PrefService::Get
>
> PrefService::Get has been replaced by PrefService::GetValue.
>
> Bug: 1334665
> Test: Existing unit tests
> Change-Id: Iec3458bdde235172ca86549328e24006dd584727
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827209
> Commit-Queue: Roland Bock <rbock@google.com>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1038763}

Bug: 1334665
Change-Id: I939a9254af25727aa97b95cabdb859b62798c79d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857319
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040951}
 2022-08-30 14:34:45 +00:00
David Baron
9a2e54ed94 Revert "Remove PrefService::Get" 
This reverts commit 0dbb10a87d.

Reason for revert: compilation failure at https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/24095

Original change's description:
> Remove PrefService::Get
>
> PrefService::Get has been replaced by PrefService::GetValue.
>
> Bug: 1334665
> Test: Existing unit tests
> Change-Id: Iec3458bdde235172ca86549328e24006dd584727
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827209
> Commit-Queue: Roland Bock <rbock@google.com>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1038763}

Bug: 1334665
Change-Id: Idded32f1dbb3ec8aecf455f85fc052039a830941
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853602
Auto-Submit: David Baron <dbaron@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038787}
 2022-08-24 15:19:50 +00:00
Roland Bock
0dbb10a87d Remove PrefService::Get 
PrefService::Get has been replaced by PrefService::GetValue.

Bug: 1334665
Test: Existing unit tests
Change-Id: Iec3458bdde235172ca86549328e24006dd584727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827209
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038763}
 2022-08-24 14:35:48 +00:00
Roland Bock
a6b631458f Refactor unit tests to use PrefService::GetValue* 
This is part of a larger migration effort based on
go/trust-your-prefs.

Bug: 1342019
Change-Id: I17bf467422005ad629112f3cab21e684f9d7cccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3790858
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1029841}
 2022-07-29 17:23:19 +00:00
Guido Urdaneta
ef4e919472 Reland "Move base/test/bind_test_util.h to base/test/bind.h" 
This reverts commit 8bd07a6cf9.

Reason for revert: This revert was incorrect and breaks the build.

Original change's description:
> Revert "Move base/test/bind_test_util.h to base/test/bind.h"
>
> This reverts commit a4493a6f80.
>
> Reason for revert: This CL breaks internal builds (e.g. /chrome/browser/media/kaleidoscope/internal/kaleidoscope_browsertest.cc).
>
> Original change's description:
> > Move base/test/bind_test_util.h to base/test/bind.h
> >
> > Stop relying on us to remember arcane file names when writing tests,
> > and repeating the directory hierarchy into the file name.
> >
> > R=​dcheng@chromium.org
> > TBR=
> > NOPRESUBMIT=true
> >
> > Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099
> > Commit-Queue: danakj <danakj@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#825145}
>
> TBR=danakj@chromium.org,dcheng@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: If165b8443662baa564895e994ea0d772348e6da6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526102
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825328}

TBR=danakj@chromium.org,dcheng@chromium.org,antrim@chromium.org

# Not skipping CQ checks because this is a reland.
NOPRESUBMIT=true
NOTREECHECK=true

No-Try: True
Change-Id: I6a8c0c8bbb1c8f87cc7f2df7a8b3388971292975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526683
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825329}
 2020-11-09 15:06:24 +00:00
Denis Kuznetsov [CET]
8bd07a6cf9 Revert "Move base/test/bind_test_util.h to base/test/bind.h" 
This reverts commit a4493a6f80.

Reason for revert: This CL breaks internal builds (e.g. /chrome/browser/media/kaleidoscope/internal/kaleidoscope_browsertest.cc).

Original change's description:
> Move base/test/bind_test_util.h to base/test/bind.h
>
> Stop relying on us to remember arcane file names when writing tests,
> and repeating the directory hierarchy into the file name.
>
> R=​dcheng@chromium.org
> TBR=
> NOPRESUBMIT=true
>
> Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825145}

TBR=danakj@chromium.org,dcheng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If165b8443662baa564895e994ea0d772348e6da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526102
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825328}
 2020-11-09 14:21:28 +00:00
danakj
a4493a6f80 Move base/test/bind_test_util.h to base/test/bind.h 
Stop relying on us to remember arcane file names when writing tests,
and repeating the directory hierarchy into the file name.

R=dcheng@chromium.org
TBR=
NOPRESUBMIT=true

Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825145}
 2020-11-07 01:53:08 +00:00
Dominic Battre
09ca2d1b27 Fix AutofillAutocompleteTest.RetentionPolicy_Init_SavesVersionPref flakiness 
This fixes the flakiness of the test caused by an asynchronous process. It also
adds a helper function to components/prefs to wait for a specific pref value to
be set.

Fixed: 1028765
Change-Id: I23636d9a19c6db1db4fe01257f13a162007ad5c2
Bug: 1028765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939488
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720137}
 2019-11-29 08:15:06 +00:00