The binary shouldn't depend on what system it was built on.
We already have a sysroot for chromium, so just use that.
Built at the same revision as previously (eb85e90350e).
No expected behavior change.
Bug: none
Change-Id: Iddced88221bd8864c5a33963ca7796b0660d0732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2790525
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867197}
Normally we prefer having a dedicated binary each for intel and arm,
but clang-format:
1. is pulled via a .sha1 file and the binary will be next to the .sha1
file
2. the location of the binary is referenced from depot_tools
So adding a second binary would mean adding a second .sha1 file, and
then we'd have to teach depot_tools to look in both places. And
clang-format is reasonably small. So just make it a universal binary
instead.
I built clang-format at the same revision the intel-only binary
was built at (eb85e90350e), using the steps in
docs/updating_clang_format_binaries.md. The only change I made
was to also pass `'-DCMAKE_OSX_ARCHITECTURES=arm64;x86_64'` to
cmake (need to include the quotes, else the shell uses the `;` as
statement terminator -- luckily the `../llvm` part was after it
so cmake informed me of missing this at first).
Bug: 1190868
Change-Id: I092c4b1e9d37ddd7aeb4caef7d612a8df44092f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2786107
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866974}
This includes spelling mistakes like:
accomodate->accommodate
ommited->omitted
unuseable->unusable
dependant->dependent
enviroment->environment
preceed->precede
occurrance->occurrence
occurrances->occurrences
intergrated->integrated
altough->although
appriopriate->appropriate
corresponing->corresponding
dependecies->dependencies
leniant->lenient
overriden->overridden
persisten->persistent
specifyinhg->specifying
As well as capitalization changes like:
javascript->JavaScript
Webkit->WebKit
linux->Linux
A couple other minor things:
the the -> the
trybot -> try bot
etc.
Review-Url: https://codereview.chromium.org/2551513002
Cr-Commit-Position: refs/heads/master@{#436046}
During the wiki->docs/*.md conversion, someone added a bunch of TODO
comments and then never acted on them. Since having TODOs in documentation
is pretty gross and since the TODOs don't make much sense, remove them.
BUG=none
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1636073003 .
Cr-Commit-Position: refs/heads/master@{#371532}
Initial migration of wiki content over to src/docs
There will be a follow-up CL to ensure docs are following chromium’s style guide, links are fixed, etc. The file auditing was becoming too much for a single change and per Nico’s suggestion, it seems to be better to do
+ Bulk import with initial prune.
+ Follow-up CLs to clean up the documentation.
So that each CL has its own purpose.
BUG=none
Review URL: https://codereview.chromium.org/1309473002
Cr-Commit-Position: refs/heads/master@{#345186}
