Robert Kaplow
b3f2df21dc
Remove some internal information in use counter doc.
...
Bug: b/283545491
Change-Id: I5ae8f0649cf5ade6e61ec8a6a40558832b7d016a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4883772
Reviewed-by: Annie Sullivan <sullivan@chromium.org >
Commit-Queue: Annie Sullivan <sullivan@chromium.org >
Auto-Submit: Robert Kaplow <rkaplow@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1199823}
2023-09-21 20:52:37 +00:00
Sun Yueru
4637eec444
Update the link to the internal Blink.UseCounter doc
...
Bug: b/276918116
Change-Id: Ib5230133a1384e7e572bb0164ec98d2f23e81de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618191
Commit-Queue: Sun Yueru <yrsun@chromium.org >
Reviewed-by: Annie Sullivan <sullivan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1158872}
2023-06-16 16:02:01 +00:00
Charlie Harrison
642ada1e86
Clarify browser-side use counter logging for //content code
...
The existing code only works for code that can depend on
components/page_load_metrics, which excludes all //content code.
This code sample should work everywhere even within //content.
Change-Id: Icb8c2df25097174d50f95163333b13784e8cd1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335937
Reviewed-by: Nan Lin <linnan@chromium.org >
Commit-Queue: Charlie Harrison <csharrison@chromium.org >
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1116951}
2023-03-14 14:10:51 +00:00
Caleb Raitto
ca630245c2
Fix browser-side reporting documentation
...
page_load_metrics::MetricsWebContentObserver::RecordFeatureUsage()
should be
page_load_metrics::MetricsWebContentsObserver::RecordFeatureUsage()
Note: Content becomes Contents.
Most code seems to use:
GetContentClient()->browser()->LogWebFeatureForCurrentPage()
But, this just calls:
page_load_metrics::MetricsWebContentsObserver::RecordFeatureUsage()
in all implementations, although some implementations have more
DCHECKS.
Change-Id: Icfcd6d7b204c5a7de7a0a3318bbedd4ff870c0e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310225
Reviewed-by: Russ Hamilton <behamilton@google.com >
Commit-Queue: Caleb Raitto <caraitto@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1113520}
2023-03-06 19:37:23 +00:00
Stephen McGruer
2669ba3d11
Fix references to web_feature.mojom in docs/
...
This file was moved in d8824447b1https://chromium-review.googlesource.com/c/chromium/src/+/3649741
Reviewed-by: Daniel Cheng <dcheng@chromium.org >
Commit-Queue: Stephen McGruer <smcgruer@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1004434}
2022-05-17 20:38:53 +00:00
Wan-Teh Chang
945a554827
Undo chrome:// URL changes in the previous commit
...
Unfortunately the chrome:// URL changes in the previous commit did not
solve the problem when this file is viewed as
https://chromium.googlesource.com/chromium/src.git/+/master/docs/use_counter_wiki.md
in a Web browser. Revert those changes.
Change-Id: I443251a89b668fc2b65d22c13fb4b8cbb05211b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2675091
Reviewed-by: Jason Chase <chasej@chromium.org >
Commit-Queue: Wan-Teh Chang <wtc@google.com >
Cr-Commit-Position: refs/heads/master@{#851112}
2021-02-05 14:57:50 +00:00
Wan-Teh Chang
a2185fcef0
Miscellaneous fixes to the UseCounter Wiki
...
The current enum type is blink::mojom::WebFeature. Add a link to the
.mojom file where the enum type is defined.
In C++ code, the UseCounter features have the 'k' prefix.
Add links to the chrome:// URLs, otherwise when viewed as
https://chromium.googlesource.com/chromium/src.git/+/master/docs/use_counter_wiki.md
the URLs become nonexistent URLs in
https://chromium.googlesource.com/chromium/src.git/+/master/docs/
Change-Id: Ibec2c0053c88dd0ca9fb0eadb620bde1468be8ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676305
Reviewed-by: Jason Chase <chasej@chromium.org >
Commit-Queue: Wan-Teh Chang <wtc@google.com >
Cr-Commit-Position: refs/heads/master@{#850821}
2021-02-04 22:38:20 +00:00
Mason Freed
bef4732041
Update use_counter docs with correct ukm_features.cc path
...
TBR=chasej@chromium.org
Change-Id: Ibf5bca4ed788bdd6d674aff7a125b4294b5f9113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967737
Commit-Queue: Mason Freed <masonfreed@chromium.org >
Reviewed-by: Mason Freed <masonfreed@chromium.org >
Cr-Commit-Position: refs/heads/master@{#724818}
2019-12-13 23:06:31 +00:00
Luna Lu
d1e8057ef2
Create a wiki page for UseCounter
...
Change-Id: I685a94a3b6b61dba274ea853e0f6b7f75edd9595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636393
Reviewed-by: Jason Chase <chasej@chromium.org >
Commit-Queue: Luna Lu <loonybear@chromium.org >
Cr-Commit-Position: refs/heads/master@{#666432}
2019-06-05 20:58:16 +00:00
