This is a reland of 18905f7828
Reland changes: The change was reverted because
ChildProcessLancher::Notify was not called after a policy error,
causing the launch to hang. Now, the FinishStartSandboxedProcess
callback will always run ensuring that Notify will always run, too.
Also, a test was added to show that a failed launch will not hang.
Original change's description:
> Parallel process launching
>
> This change adds support for parallel process launching on Windows.
>
> Background: Processes are launched on a launcher thread, but this thread
> can become bottlenecked if launching multiple processes simultaneously.
> Most of the time spent in the launcher thread is observed to be in the
> CreateProcess call.
>
> This change makes process launching async by moving the target creation
> work to the thread pool. This frees up the launcher thread so it can
> accept tasks more quickly, and multiple target creations can now run in
> parallel.
>
> --enable-features=WinSboxParallelProcessLaunch
>
> Bug: 1499551
> Tests: sbox_integration_tests ParallelLaunchTest.*
> Change-Id: I7add6a6a68d31868a41fb433b223695ff36d8769
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
> Reviewed-by: Will Harris <wfh@chromium.org>
> Commit-Queue: Ben Bamesberger <benb@microsoft.com>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
> Reviewed-by: Bo Liu <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1348194}
content_browsertests
BrowserChildProcessObserverBrowserTest.LaunchPreSpawnFailed
Bug: 40287847
Change-Id: Ia200ec065a9540f9d4790e2c6e0ae98178fdf747
Tests: sbox_integration_tests ParallelLaunchTest.*,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5852357
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1365065}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ibc66b8c440e4bcdef414e77fef4d9874d2ea9951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493800
Auto-Submit: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293330}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ieeb461e2d489e86fd50b87a2a0721a2be34520c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467317
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290198}
This CL updates copyright headers in /content
to the current format:
// Copyright $year The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Generated with:
./tools/git/mffr.py -g "*.cc" -g "*.h" -g "*.mm" -g "*.py" -g "*.js" -g "*.java" -g "*.mojom" -g "*.xml" -g "*.jinja" -g "*.gn" -g "*.gni" -g "*.star" -g "*.icon" -g "*.ts" -g "*.css" -g "*.json" -g "*.html" -g "*.proto" -g "*.idl" -g "*.pins" -g "*.yml" -g "*.sh" 'Chromium Authors\. All rights reserved\.' 'Chromium Authors'
Additional manual fixes were made to files that have extra "(C)"
strings, or where line breaks were wrong.
This CL was uploaded by git cl split.
R=boliu@chromium.org, rakina@chromium.org
Bug: 1457007
Change-Id: I9702c9e35e5f01b6afb8da1cf89f0edaa8d1379a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4823997
Reviewed-by: Bo Liu <boliu@chromium.org>
Auto-Submit: Mark Foltz <mfoltz@chromium.org>
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1190534}
This reverts commit f2137d9fad.
Reason for revert: Fails CacheStorageEagerReadingTest tests that expect blobs to be of a specific size. See https://crbug.com/1457696.
Original change's description:
> Update remaining license headers in Chromium.
>
> These license headers do not conform to the current requirements.
>
> Generated with:
>
> ./tools/git/mffr.py -g "*.cc" -g "*.h" -g "*.mm" -g "*.py" -g "*.js" -g "*.java" -g "*.mojom" -g "*.xml" -g "*.jinja" -g "*.gn" -g "*.gni" -g "*.star" -g "*.icon" -g "*.ts" -g "*.css" -g "*.json" -g "*.html" -g "*.proto" -g "*.idl" -g "*.pins" -g "*.yml" -g "*.sh" 'Chromium Authors\. All rights reserved\.' 'Chromium Authors'
>
> Additional manual fixes were made to files that have extra "(C)"
> strings, or where line breaks were wrong. See the diffs between
> patchsets 2 and 3 and 4 and 6.
>
> No-Presubmit: True
> No-Try: True
> Bug: 1457007
> Change-Id: I1b0707dbd0696da1eb9aaa44e337508516c11995
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641371
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
> Owners-Override: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1161990}
Bug: 1457007, 1457696
Change-Id: I7f9cd8d5a903b251182ca27fdbc66d505baae838
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4642876
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1162042}
These license headers do not conform to the current requirements.
Generated with:
./tools/git/mffr.py -g "*.cc" -g "*.h" -g "*.mm" -g "*.py" -g "*.js" -g "*.java" -g "*.mojom" -g "*.xml" -g "*.jinja" -g "*.gn" -g "*.gni" -g "*.star" -g "*.icon" -g "*.ts" -g "*.css" -g "*.json" -g "*.html" -g "*.proto" -g "*.idl" -g "*.pins" -g "*.yml" -g "*.sh" 'Chromium Authors\. All rights reserved\.' 'Chromium Authors'
Additional manual fixes were made to files that have extra "(C)"
strings, or where line breaks were wrong. See the diffs between
patchsets 2 and 3 and 4 and 6.
No-Presubmit: True
No-Try: True
Bug: 1457007
Change-Id: I1b0707dbd0696da1eb9aaa44e337508516c11995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641371
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Owners-Override: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1161990}
This is a reland of commit e97ada6c24
The revert did not fix the issue so I'm relanding it as-is. The
failing test was disabled in another CL.
Original change's description:
> Add BrowserChildProcessExitedNormally
>
> This new method allows an observer to get the ChildTerminationInfo data
> from a child process that terminates normally.
>
> Bug: 1313215
> Change-Id: Iafd41d9b54e3a47014d350aac0a7658d72ffa9b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792828
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1050887}
Bug: 1313215
Change-Id: Idc623d03b1dde7fbc3f99913f5cecef99806c26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918751
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1052399}
This new method allows an observer to get the ChildTerminationInfo data
from a child process that terminates normally.
Bug: 1313215
Change-Id: Iafd41d9b54e3a47014d350aac0a7658d72ffa9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792828
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1050887}
