This switches to using BrowserContext instead of ResourceContext for
PluginService and plugin_utils.cc. This required moving
PluginRegistryImpl, PluginInfoHostImpl, and
RenderFrameMessageFilter::OnGetPluginInfo to run on the UI thread.
This eliminates one of the major dependencies of extensions::InfoMap.
Bug: 980774
Change-Id: I7b26c5b40dc8b98c518339b771249ef16e6ec856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730093
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684082}
Some of the methods can be run on any threads while not all of them
are explicitly marked so. Update documentation to make it clear and
call it on UI thread during navigation when needed.
Bug: 824840
Change-Id: I138d70338b2a35e164538918e23e034ba5d7045d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687015
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674735}
Expands the management of plugins to consider origin when assigning
a process. Only passes empty origins at present, so no observable
change expected.
Bug: 809614
Change-Id: I129495ddc94c86dc1c4aa1b3a7942354eabe59d4
Reviewed-on: https://chromium-review.googlesource.com/915182
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540294}
CL generated by
git grep -l NON_EXPORTED_BASE | xargs sed -i 's/NON_EXPORTED_BASE(\([^)]*\))/\1/g'
git cl format
I'm not changing compiler_specific.h itself in this cl, to keep the revert
small if the subsequent removal of the actual macro should break something.
Bug: 752837
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I53d6460e592b91a173f7aa55dfdb05631e51e5f7
Reviewed-on: https://chromium-review.googlesource.com/614703
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494486}
Moves the build flag from build/config/features.gni to ppapi/features/features.gni so it's not global any more.
Moves the define from build/config (global) to a generated buildflag header //ppapi/features:features. Updates callers to use BUILDFLAG, include the new header, and depend on this target.
R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2512563003
Cr-Commit-Position: refs/heads/master@{#433426}
This patch does two things:
1) Blocks all non-HTTP and non-FILE plugin loads within plugin_utils.cc (unless the user has chosen ALLOW)
2) Fixes FILE plugin loads. Previously, FILE origins were getting lost in the GetPlugins, since WebSecurityOrigin serializes FILE origins to "null".
This meant that content settings exceptions did not work correctly for the plugin list retrieval. This didn't matter before HBD because the plugin list wasn't affected by content settings until HBD.
This patch fixes it by passing url::Origin throughout the Plugins code rather than GURL for the page origin.
BUG=649223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2378573005
Cr-Commit-Position: refs/heads/master@{#423598}
SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.
Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).
BUG=622400
Review-Url: https://codereview.chromium.org/2319623002
Cr-Commit-Position: refs/heads/master@{#417266}
This pulls a lot of hairballs but that's pretty much everything left.
BUG=493212,123851,234591,238460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1862513003
Cr-Commit-Position: refs/heads/master@{#385358}
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
--enable-npapi-for-testing will remain temporarily until the rest of the NPAPI code and tests are removed.
This is a selective revert of 0539f2f521 and 26d09db193.
BUG=493212,489066
Review URL: https://codereview.chromium.org/1158423003
Cr-Commit-Position: refs/heads/master@{#332006}
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.
This patch was manually generated using a regex and a text editor.
BUG=417463
Review URL: https://codereview.chromium.org/1091093006
Cr-Commit-Position: refs/heads/master@{#326880}
BUG=472648
TEST=manual - verify that NPAPI plugins appear in chrome://plugins when either a machine or user plugin policy is set.
Review URL: https://codereview.chromium.org/1071713004
Cr-Commit-Position: refs/heads/master@{#324754}
Add --enable-npapi flag in chrome://flags to support re-enable.
BUG=295137
TEST=browser_tests, unit_tests, content_browsertests, blink layout tests
Review URL: https://codereview.chromium.org/645203002
Cr-Commit-Position: refs/heads/master@{#312374}
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/667943003
Cr-Commit-Position: refs/heads/master@{#300469}
This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.
BUG=417463
Review URL: https://codereview.chromium.org/637183002
Cr-Commit-Position: refs/heads/master@{#298804}
Some applications need access to dev channel APIs before they will
become stable. As written, this change only performs whitelisting for NaCl
apps; I don't think we have any need for enabling this in the non-NaCl case.
I need to find a good way to test this.
BUG=383937
R=dmichael@chromium.org, jln@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/338523007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278645 0039d316-1c4b-4281-b951-d872f2087c98
As part of supporting "dev channel" methods in Pepper APIs, the plugin needs to
know whether or not it's running in a channel that supports those methods.
This patch plumbs that information through LoadPlugin so it's available by the
time get_interface<>() would ever be called.
TBR=piman
BUG=325403
Review URL: https://codereview.chromium.org/104673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240398 0039d316-1c4b-4281-b951-d872f2087c98
This is part of the work of making ContentRendererClient's OverrideCreatePlugin and CreatePluginReplacement take only a RenderFrame. I'm still not there yet, which is why their signatures haven't been trimmed.
BUG=304341
R=fsamuel@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/107183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239075 0039d316-1c4b-4281-b951-d872f2087c98
-NPAPIPluginsSupported moves to PluginService
-no need to call it in PluginList methods anymore since PluginService is now the only place that calls these methods, and it can check first
-no need for the renderer to call this first since now the browser won't enumerate NPAPI plugins if it's disabled
-CreateVersionFromString moves to WebPluginInfo. I couldn't find a better place to put it.
-move the constants back to plugin_constants_win.h
-move PLUGIN_QUIRK_DIE_AFTER_UNLOAD handling to WebPluginDelegateStub and PluginThread instead of being a global
-GetDefaultWindowParent moves to plugin_constants_win.h. I couldn't find a better place.
-IsPluginWindow moves to PluginService
-GetPluginNameFromWindow and GetPluginVersionFromWindow are both replaced by GetPluginInfoFromWindow which is on PluginService
-IsDummyActivationWindow was called by one place so I moved the code there
BUG=237249
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19844003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212672 0039d316-1c4b-4281-b951-d872f2087c98
