0
Commit Graph

5596 Commits

Author SHA1 Message Date
Nigel Tao
9c6b7ff46a [docs] add "What's Up With Base" transcript
Change-Id: I8fdce93892ddd03258d7f2fe5cc94c38cfd4f49f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166405
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405100}
2025-01-10 16:59:17 -08:00
chromium-autoroll
ede332eece Roll Website from b2946942a27e to 939010115caa (1 revision)
https://chromium.googlesource.com/website.git/+log/b2946942a27e..939010115caa

2025-01-10 vapier@chromium.org CrOS: fix random links after pages shuffled

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I4271f431b4feb651b2c259079763f5d0779c888f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168129
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404965}
2025-01-10 12:49:36 -08:00
Louis Romero
ef34dc8205 Fix typo
Change-Id: Ib7654de0f2abbb352d5f1b1a421fed849717b790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164151
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Louis Romero <lpromero@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404844}
2025-01-10 09:20:33 -08:00
Byron Lee
e8fa826318 [Telemetry] Update doc for network bandwidth routine
Bug: 261312788
Test: CQ

Change-Id: I6829f42217fa668119113d5250494478b0485db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164038
Reviewed-by: Chung-sheng Wu <chungsheng@google.com>
Commit-Queue: Byron Lee <byronlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404653}
2025-01-10 01:08:18 -08:00
chromium-autoroll
500de85a74 Roll Website from 5c146dc01b9d to b2946942a27e (2 revisions)
https://chromium.googlesource.com/website.git/+log/5c146dc01b9d..b2946942a27e

2025-01-10 vapier@chromium.org site: enable code syntax highlighting
2025-01-09 dpranke@google.com site: add markdown-it-footnote to support [^1] syntax

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:40826991
Tbr: dpranke@google.com
Change-Id: I46c28e0be9fd732cc2426c5ad230dcf484f3cc64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166965
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404633}
2025-01-10 00:11:13 -08:00
Weizhong Xia
895774587d Make clear that headless_shell_wpt_tests is the default for WPTs
As WPT migration is mostly done and headless shell is now the default
target for WPTs, make this clear in document and naming to make it
less likely a new WPT accidentally added to the exception list.

Renamed headless_shell.filter to content_shell.filter to make it
obvious that tests listed there are intended to be run with content
shell and is something unusual.

Validate-Test-Flakiness: skip

Bug: 40927590
Change-Id: I787f7c4757aba3f869c4edeb7f43c5aeff79c41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6154686
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404578}
2025-01-09 20:14:36 -08:00
Shuhei Takahashi
c2a265325b [docs] Add instructions to use ChromiumIDE for Java
Bug: None
Test: None
Change-Id: I9dfc971237b3e49ed27c0ca3894b99d815014c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165864
Commit-Queue: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404549}
2025-01-09 18:20:16 -08:00
chromium-autoroll
3ef756c81a Roll Website from 1ae7f54cfc75 to 5c146dc01b9d (1 revision)
https://chromium.googlesource.com/website.git/+log/1ae7f54cfc75..5c146dc01b9d

2025-01-09 vapier@chromium.org build: use standard .patch extension

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Idc3940fc488c2066ea6e06033d254ce327809bb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165365
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404327}
2025-01-09 11:18:21 -08:00
chromium-autoroll
8ff3e12658 Roll Website from 3a33fcb258d6 to 1ae7f54cfc75 (7 revisions)
https://chromium.googlesource.com/website.git/+log/3a33fcb258d6..1ae7f54cfc75

2025-01-08 vapier@chromium.org PRESUBMIT: skip ``` blocks
2025-01-08 vapier@chromium.org enable keep-sorted in more places
2025-01-08 vapier@chromium.org PRESUBMIT: warn about old broken links from Google sites
2025-01-08 vapier@chromium.org fix missing . before extension in LOBs
2025-01-08 vapier@chromium.org fetch_lobs: handle HTTP/404 errors
2025-01-08 vapier@chromium.org finish importing images from chromiumos/docs
2025-01-08 vapier@chromium.org fix broken image links

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ibbafe47395f28bc7508c62b472b67854921d6361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6162219
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404014}
2025-01-08 22:32:35 -08:00
Weizhong Xia
0895abfa52 Build chrome and headless shell in blink_tests
This way developers will only need to build blink_tests to run web
tests and WPTs locally.

Bug: 40927590
Change-Id: Idc83520763a7a159087f8938a13cc751995993d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158486
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Jonathan Lee <jonathanjlee@google.com>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403901}
2025-01-08 15:55:38 -08:00
Haiyang Pan
03b1c6c4c6 Update android_emulator.md for local AVD configs
Also update the config list to catch up with the latest status, and
replace CPU Arch & AVD Target with Form Factor as the former two are
built in the file name already.

Bug: none
Change-Id: Ieabf181feff9116cbab4657f991baa10e32bc513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6154739
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Renuga Nanjappan <rnanjappan@chromium.org>
Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403893}
2025-01-08 15:34:07 -08:00
chromium-autoroll
b9542a14ce Roll Website from a21aecf6b595 to 3a33fcb258d6 (1 revision)
https://chromium.googlesource.com/website.git/+log/a21aecf6b595..3a33fcb258d6

2025-01-08 jyasskin@google.com Merge the TAG and Standards-Positions exceptions into a single section, and add a summary of TAG review.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I36745db678b5978360bc1d4bbe61751e491c09fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6159285
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1403652}
2025-01-08 09:42:53 -08:00
Sylvain Defresne
09a1b99beb [ios] Add IfChange Lint annotations
Bug: none
Change-Id: I9a4f874139d13d3918a197aee0e9572453fa06ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157727
Reviewed-by: Louis Romero <lpromero@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403563}
2025-01-08 07:02:39 -08:00
Rick Byers
8bdaba4f22 Tweak Owners-Override documentation
Change-Id: I01f9a572e13034ee4abe00b488b46b692af22b56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6153756
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403550}
2025-01-08 06:12:30 -08:00
chromium-autoroll
9cac71b251 Roll Website from bee1494dcbf5 to a21aecf6b595 (1 revision)
https://chromium.googlesource.com/website.git/+log/bee1494dcbf5..a21aecf6b595

2025-01-08 davidcross@chromium.org developer-information: Update Steelix, Rusty and Magneton with links and CPU SKU options

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ie2d2303ee5691fb61a28de668f84e718ec81a585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6154890
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1403340}
2025-01-07 17:43:50 -08:00
Erik Chen
b3d9310f62 Update expectations for code review.
Change-Id: I7a87c56968bb23b456409575c0ea2d17a8085daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148520
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403156}
2025-01-07 11:41:35 -08:00
Marian Harbach
314c5e6c99 Add research findings on positioning to Security Considerations for UI doc
Change-Id: I15c1d5436f07e0e3fda328430417f0c895754f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6147438
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Auto-Submit: Marian Harbach <mharbach@google.com>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403125}
2025-01-07 11:10:01 -08:00
Joanna Wang
9b32ab4c51 Redirect users to documentation on how to add GCS deps in chromium/src
Bug: b/384636723
Change-Id: Ieacb7152f68ca236bd4d89ddabaecd04aab79a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6150467
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403021}
2025-01-07 08:39:08 -08:00
Sylvain Defresne
1a98f766a1 [ios] Assert the version of Xcode is recent enough
Building Chrome for iOS requires Xcode 16.0 or higher (documented
in https://crrev.com/c/5899385) but the assertion in gn files was
not updated.

Update the assertion in ios/build/chrome_build.gni while putting
comments in the markdown file to remind people to keep both files
in sync.

Bug: none
Change-Id: Ie2b79461dbe0d4c7a3cd406d6686337b79edfd9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085001
Reviewed-by: Louis Romero <lpromero@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402939}
2025-01-07 06:08:50 -08:00
chromium-autoroll
daed0887e0 Roll Website from 4d214097ba73 to bee1494dcbf5 (3 revisions)
https://chromium.googlesource.com/website.git/+log/4d214097ba73..bee1494dcbf5

2025-01-07 vapier@chromium.org finish importing images from go/howdoicros
2025-01-06 sfrolov@google.com Remove sfrolov from OWNERS
2025-01-06 vapier@chromium.org bluetooth-extension-api: fix local anchor links

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I4800f8794cdef42c450c22a33eeed05b5ac07dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6151866
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1402828}
2025-01-07 00:04:10 -08:00
chromium-autoroll
b0dc86b9e3 Roll Website from 228b145cbe59 to 4d214097ba73 (1 revision)
https://chromium.googlesource.com/website.git/+log/228b145cbe59..4d214097ba73

2025-01-06 vapier@chromium.org sublime-text: use ``` consistently

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I953eff9d1389da883b77c1268887463b9fd6871c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6149888
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1402537}
2025-01-06 11:20:46 -08:00
Chris Harrelson
66168c0708 Improve instructions for finding log lines in Android Chrome debugging.
Change-Id: I860e1bf6d35fbb4228081a7f273789d8d7c7b760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142466
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402502}
2025-01-06 10:42:10 -08:00
Riley
a73939f99e Update GS Bucket creation doc to include self service instructions
Bug: 363140411
Change-Id: I684ede75a38ca128d0a535e579947851a2a6ca63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097155
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Riley Wong <rgw@google.com>
Reviewed-by: Wanda Mora <morawand@google.com>
Commit-Queue: Wanda Mora <morawand@google.com>
Cr-Commit-Position: refs/heads/main@{#1402354}
2025-01-06 06:33:46 -08:00
chromium-autoroll
42e2cf0e03 Roll Website from 568686d75cab to 228b145cbe59 (1 revision)
https://chromium.googlesource.com/website.git/+log/568686d75cab..228b145cbe59

2025-01-03 vapier@chromium.org fetch_lobs: rework progress output

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I1dea35645066b45ac4d5bb14167d585353736ada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142788
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401946}
2025-01-03 13:30:53 -08:00
chromium-autoroll
f4d7cfea10 Roll Website from adc61787dec3 to 568686d75cab (2 revisions)
https://chromium.googlesource.com/website.git/+log/adc61787dec3..568686d75cab

2025-01-03 vapier@chromium.org drop unused file in site root
2025-01-02 vapier@chromium.org fix broken ``` blocks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I2da2ae4d2fa0f91aadcab058e66afa524c9f1df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6139957
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401717}
2025-01-03 00:27:35 -08:00
Ben Pastene
dd94f632a3 docs: Cut mb.py & run-swarmed.py mentions in debugging-with-swarming.md
With the development and use of the UTR as far long as it is, these
old tools likely serve little use. So this begins trying to shift
usage to the much more supported UTR by updating docs.

Future CLs will add deprecation notices to the old tools, and
eventually delete them.

Bug: 386167803
Change-Id: If5265b7fac7959038d9da817cf241db50d6fe56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6124971
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/heads/main@{#1401544}
2025-01-02 12:15:05 -08:00
chromium-autoroll
72b8127c66 Roll Website from 35124dbd5201 to adc61787dec3 (1 revision)
https://chromium.googlesource.com/website.git/+log/35124dbd5201..adc61787dec3

2025-01-02 vapier@chromium.org PRESUBMIT: disallow linking directly to local markdown files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ic9d5ee673ba0d94722859b03bb8ed442a8d17d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138168
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401525}
2025-01-02 11:27:17 -08:00
Lily Chen
efbacb867b Update security FAQ about Safe Browsing warnings
Incorporates post-submission feedback on crrev.com/c/6102607.

Change-Id: Ib00a7c7054ede093f431720d78a1a0ac245b394f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133676
Auto-Submit: Lily Chen <chlily@chromium.org>
Reviewed-by: Seung Jae Lim <andysjlim@chromium.org>
Commit-Queue: Seung Jae Lim <andysjlim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401476}
2025-01-02 09:52:53 -08:00
chromium-autoroll
dabb244b3a Roll Website from 1229734e08d7 to 35124dbd5201 (1 revision)
https://chromium.googlesource.com/website.git/+log/1229734e08d7..35124dbd5201

2025-01-02 vapier@chromium.org fix broken links to direct markdown files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I1970d4d87349ee27b267b0fd971d30db030fc79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6136892
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401309}
2025-01-01 22:33:30 -08:00
Amy Ressler
5e35aa902d VRP FAQ news update - staging
Change-Id: Ibef8d23db21321b2bd6a26090e8b8f20f7889f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6128018
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Amy Ressler <amyressler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400620}
2024-12-27 18:02:07 -08:00
Henrique Nakashima
5425bb6db3 [Android] Recommend static_analysis = "build_server" as default
Bug: 370589852
Change-Id: Iec4d97fa21593b80509e413ff012584fff565210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114354
Auto-Submit: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399903}
2024-12-23 14:09:51 -08:00
Jordan Brown
a376e32751 Deleting reference to README.security from docs
This change updates the documentation, requiring security concerns to
be provided in the 'Description' field of their README.chromium instead
of in README.security files.

Minor change to some of the wording, emphasising the importance of communicating security concerns in the Description for the benefit of security reviewers, but also other users of the dependency.


Bug: 383906216
Change-Id: I5a3465dd08afa503c794fe27aa542d36e8a15b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6107858
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jordan Brown <rop@google.com>
Cr-Commit-Position: refs/heads/main@{#1399680}
2024-12-22 16:25:27 -08:00
chromium-autoroll
cd64574567 Roll Website from 7026ffa285a6 to 1229734e08d7 (4 revisions)
https://chromium.googlesource.com/website.git/+log/7026ffa285a6..1229734e08d7

2024-12-20 vapier@chromium.org use https://www.google.com/ consistently
2024-12-20 vapier@chromium.org 404s: drop unused file
2024-12-20 vapier@chromium.org use https://www.chromium.org/ consistently
2024-12-20 jyasskin@google.com Import bit.ly/blink-signals into version control.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I959fd1398c77d9529cf027f50f1cbd379448b179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115302
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1399441}
2024-12-20 16:44:59 -08:00
Daniel Cheng
0fed915081 Fix robdclark's alias in security shepherding docs
Change-Id: Ide680e0e70f17280371162150908da8cc46044c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102752
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399154}
2024-12-20 06:47:49 -08:00
chromium-autoroll
5efe7088aa Roll Website from 5db4375bda1b to 7026ffa285a6 (10 revisions)
https://chromium.googlesource.com/website.git/+log/5db4375bda1b..7026ffa285a6

2024-12-20 vapier@chromium.org security-bug-lifecycle: point people to canonical doc only
2024-12-20 vapier@chromium.org PRESUBMIT: use relative links to local pages
2024-12-20 vapier@chromium.org use relative links instead of https://www.chromium.org/
2024-12-20 vapier@chromium.org use https://google.com/ consistently
2024-12-20 vapier@chromium.org use https://www.w3.org/ consistently
2024-12-20 vapier@chromium.org use https://en.wikipedia.org/ consistently
2024-12-20 vapier@chromium.org use https://github.com/ consistently
2024-12-20 vapier@chromium.org use https://issuetracker.google.com/ consistently
2024-12-20 vapier@chromium.org use https://crrev.com/ consistently
2024-12-20 vapier@chromium.org use https://crbug.com/ consistently

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Iccded483b90970a8f3ff6d4f8771116fe1bedf16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6112613
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1399094}
2024-12-20 03:50:46 -08:00
chromium-autoroll
93652e902b Roll Website from a92dd07aed39 to 5db4375bda1b (4 revisions)
https://chromium.googlesource.com/website.git/+log/a92dd07aed39..5db4375bda1b

2024-12-19 vapier@chromium.org fix broken links due to missing scheme
2024-12-19 vapier@chromium.org PRESUBMIT: force use of go/ over goto.google.com/
2024-12-19 vapier@chromium.org cleanup weird goog_# gremlins
2024-12-19 vapier@chromium.org PRESUBMIT: require https:// with common known external sites

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I7c7de9c2956da0294330a29a5b3a37dd14ea5de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6112405
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1398889}
2024-12-19 14:51:49 -08:00
Egor Pasko
b9941a6100 android: Extend Startup.Android.Cold.TimeToFirstContentfulPaint3
Extend the lifetime of Startup.Android.Cold.TimeToFirstContentfulPaint3.

The histogram as it is mentioned in the histograms.xml has no data on
the UMA dashboard because the collected histogram adds the suffix
".Tabbed".  Register this suffix in the histogram_suffixes_list to make
it searchable in the dashboard. Mark the histogram without the suffix as
base="true" to make it non-searchable (to avoid confusions).

Adjust the doc and the test accordingly.

Bug: 40926074, 384509264
Change-Id: Id7653a49fd8fff67df5fd046011b2d233d93b779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110414
Owners-Override: Nafis Abedin <nafisabedin@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398663}
2024-12-19 09:40:58 -08:00
chromium-autoroll
6c2f0ba784 Roll Website from 7f60d56071fa to a92dd07aed39 (12 revisions)
https://chromium.googlesource.com/website.git/+log/7f60d56071fa..a92dd07aed39

2024-12-18 lovisolo@google.com Add lovisolo@ to site/chromium-os/OWNERS.
2024-12-18 vapier@chromium.org PRESUBMIT: force people to use youtube.com
2024-12-18 vapier@chromium.org use https://youtube.com/ consistently
2024-12-18 vapier@chromium.org PRESUBMIT: require http:// with known internal sites
2024-12-18 vapier@chromium.org PRESUBMIT: force use of issuetracker.google.com/ over b/
2024-12-18 vapier@chromium.org use http:// with internal sites
2024-12-18 vapier@chromium.org cleanup b/ links to use issuetracker.google.com/
2024-12-18 vapier@chromium.org PRESUBMIT: force use of go/ over goto/
2024-12-18 vapier@chromium.org cleanup goto/ links to use go/
2024-12-18 vapier@chromium.org PRESUBMIT: check for /site/ prefixes in links
2024-12-18 vapier@chromium.org PRESUBMIT: start checking links
2024-12-18 vapier@chromium.org change dev.chromium.org to www.chromium.org

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I67da5f9e870d6bbaad9ad02b9fe1cc1c37f8ca6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110096
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1398467}
2024-12-19 02:09:03 -08:00
Peter Kasting
0eca431de2 Add C++ style change process documentation.
As approved in
https://docs.google.com/document/d/1f2TQ24l2_ztcc-xcG6i8klpKBsfdJQ7G4deluhBldMA/edit?usp=sharing.

Bug: none
Change-Id: Ieace7b308601f73f5233c5f9756aa33c1721265a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941323
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398115}
2024-12-18 11:41:45 -08:00
chromium-autoroll
8f944455d0 Roll Website from 24d837acc567 to 7f60d56071fa (1 revision)
https://chromium.googlesource.com/website.git/+log/24d837acc567..7f60d56071fa

2024-12-18 vapier@chromium.org change chromium.org to www.chromium.org

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I8e284474c263f642aa5936d0edf4508db2b4974a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6106871
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1398097}
2024-12-18 11:20:18 -08:00
Lily Chen
842810ff5b Add a security FAQ about appealing Safe Browsing warnings
Change-Id: Iba395540b16e4992e99a250047398cdb7f7e2813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102607
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397994}
2024-12-18 09:00:40 -08:00
chromium-autoroll
e66055cebf Roll Website from 31a2f432dc14 to 24d837acc567 (1 revision)
https://chromium.googlesource.com/website.git/+log/31a2f432dc14..24d837acc567

2024-12-17 vapier@chromium.org repo: update external/repo fork details

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ie29754a9b64dba70b60ea06a1739777161b477df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6103189
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397651}
2024-12-17 16:27:17 -08:00
Ravi Mistry
6286b7d204 Remove Cluster Telemetry from documentation
Bug: 383737846
Change-Id: I75fc4166e132d1581762cd940a2f4943d8dfc2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102368
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Cr-Commit-Position: refs/heads/main@{#1397454}
2024-12-17 11:08:27 -08:00
chromium-autoroll
5beed340ae Roll Website from ffa936be041b to 31a2f432dc14 (1 revision)
https://chromium.googlesource.com/website.git/+log/ffa936be041b..31a2f432dc14

2024-12-16 hardtmad@google.com archive_mirros: Remove object-level ACL commands

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Id66c4570d400aed92879f36f7bcf0a57b883732a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098446
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397064}
2024-12-16 16:06:01 -08:00
Darren Shen
0e1f621511 Call out BrowserContext in ash code location guidelines.
In one section, the guidelines say:

  Instead of using ProfileKeyedServiceFactory (in //chrome), consider
  using BrowserContextKeyedServiceFactory (in //components) instead.

But in the "Desired State" section, it says:

  The //content directory is the API for building a web browser. Even
  though Ash does use web technology for rendering many things, it is
  not itself a web browser and there should be no OS code in this
  directory or calling directly into it.

And also:

  New features should be designed to adhere to the “desired state” as
  closely as practical.

To resolve some confusion here, explicitly call out BrowserContext as
allowed despite contradicting the desired state.

Change-Id: Iba72f48d9dc054d5012325bc4f384d036cc68b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093907
Reviewed-by: Michael Cui <mlcui@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1396991}
2024-12-16 14:12:03 -08:00
rbpotter
c7acfbd07c WebUI: improve documentation on code location
Change-Id: I2d6ce44d5c9574685db0a583c7e81cb31dcfc6df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093657
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1396289}
2024-12-13 17:37:02 -08:00
Andrew Grieve
f253a880e6 android_build_instructions.md: Update fast_local_dev_server.py instructions
Bug: 370589852
Change-Id: Ida196b388cb71ddd2e9c62883c849018a6a4a77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093970
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1396120}
2024-12-13 12:02:57 -08:00
Peter Kasting
448444ff79 Replace first() with copy_from_prefix()/take_first(): base/
Where applicable.

Bug: none
Change-Id: Ibb5f6a502942d3a04f0c6956277d1fa68b3c8564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6091731
Reviewed-by: Lei Zhang <thestig@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395707}
2024-12-12 17:25:36 -08:00
David Adrian
d8918699cd Update Rust guidelines
Update docs/rust.md and docs/adding_to_third_party.md to remove the 3P restriction. For an extended description of the new process and rationale for changing it, Googlers can see go/rethinking-rust-approvals-chrome.

Change-Id: Ifb6acd08e11eafcbbbe7823803033d38bd384974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980554
Commit-Queue: David Adrian <dadrian@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395613}
2024-12-12 14:02:50 -08:00
Piet Schouten
47e859fa34 Fix grammatical error in the cr docs
This change removes an apostrophe to make the sentence more
grammatically correct.

Bug: 363034680
Change-Id: I2e97b3a71457d99970e19fa82df28d6c06b2e905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092093
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Piet Schouten <Piet.Schouten@microsoft.com>
Reviewed-by: Sam Fortiner <samfort@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1395610}
2024-12-12 13:46:24 -08:00