Hide touch selection handles and menu after if the active client managed
by TouchSelectionControllerClientAura is invalidated. This is to prevent
stray handles and menu staying around after the active client is
destroyed (e.g. after reloading a web page where the active client
corresponds to an iframe).
Bug: b:312312220
Change-Id: I49c828d5d97d3e7347440a4a8643c82933158934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055932
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Michelle Chen <michellegc@google.com>
Cr-Commit-Position: refs/heads/main@{#1229117}
Doc: go/mv-camera-enumeration
We define a new class VideoCaptureDevicesChangedObserver that
establishes a mojo connection between the video capture service and
the browser process and receives OnDeviceChanged events from
video_capture::DevicesChangedNotifier.
These changes are exposed under the feature
'kCameraMonitoringInVideoCaptureService' which will gradually be
rolled out following the finch process.
Bug: 1448798
Change-Id: I60048b3a2cc8f7b844bc823002f12419dde79f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002121
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Palak Agarwal <agpalak@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228892}
As part of the ClientSharedImage refactorization, this CL replaces
the mailbox member in PPB_Graphics3D_Impl::ColorBuffer with
ClientSharedImage, and adds other necessary code changes to support
this replacement.
Bug: 1494911, 1499992
Change-Id: Ie6800b427f70179dbf7cfabacdf49174377a551d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5056072
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228872}
Update ServiceWorkerScriptCacheMap::NotifyStartedCaching to use
the actualy storage key instead of creating a first-party storage
key from the worker scope.
I looked but couldn't find an easy way to test this. This seems
relatively minor, though, and likely not worth the effort.
Fixed: 1501023
Change-Id: I34e1a34850d40e65649e753447103ed509a0e663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5057529
Commit-Queue: Andrew Williams <awillia@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228863}
Minor fixes and improvements to TestTraceProcessor:
- Add a test that SQL window functions are supported (== that we are
linking against the correct version of SQLite).
- Make stdlib module overriding work by stripping .sql suffixes from
filenames.
- Add --ttp-save-trace switch to allow saving the trace and make
debugging easier.
Change-Id: I130cd95e378bd702d4f07dad6cf44e6cb60dd692
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054370
Reviewed-by: Rasika Navarange <rasikan@google.com>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228853}
Change the content_input_actions_parser_fuzzer to ignore huge
inputs, in order to avoid spurious timeout and OOM clusterfuzz
reports.
The exact constant is chosen semi-arbitrarily: we set it at 100 KB;
for reference, the OOM report happened on a 686 KB input.
Fixed: 1497681
Change-Id: Ic501be24c60a8a27f2b4d0317fe73913f80c673f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5057760
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228816}
This CL adds a structure and changes the arguments of FallbackCallback
in `NavigationLoaderInterceptor` to the newly created structure.
The added structure currently has only one field, `load_timing_info`, but we plan to add other fields to update response headers other than
load timing.
This is the preliminary change to fix the bug on DevTools support for SW
Static Routing API.
Bug: 1502443
Change-Id: I742f9277586a29aa7cea2d1f79adcc867193390b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5051307
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Takashi Nakayama <tnak@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228776}
This is a reland of commit 6667207527
We reland the original CL without any change since the test that was failing seems to have no relation with the CL, and it has been disabled by Bug: 1504558 and addressed separately.
Original change's description:
> [bfcache] Enable BFCache for pages with MediaDevicesDispatcherHost
>
> This CL makes kMediaDevicesDispatcherHost no longer a blocker for BFCache. This means that pages that have used the media devices API can be cached when they don't access any MediaStreamTrack. This feature is disabled by default by the newly added feature flag `EnableBackForwardCacheForPagesWithMediaDevicesDispatcherHost`
>
> Bug: 1502395
> Change-Id: I36f71242d03955fd566f9bb800f6413fc788bd61
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5029613
> Reviewed-by: Mingyu Lei <leimy@chromium.org>
> Commit-Queue: Kurumi Muto <mkurumi@google.com>
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1227870}
Bug: 1502395
Change-Id: I644f16c0e24965f88e036d664b907eb64f66596f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054729
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Commit-Queue: Kurumi Muto <mkurumi@google.com>
Cr-Commit-Position: refs/heads/main@{#1228666}
This allows Chrome to properly detect when a ccTLD alias in the
command-line-provided set should be hidden, because the site it
refers to has been shadowed by some site in an enterprise policy set.
This implementation is not fully generalized; it special-cases the
manually-provided set instead of modifying FirstPartySetsContextConfig
more generally to include this information. This is fine for now since
we never need to compute a new config that's layered on top of another
config from a different enterprise policy.
Fixed: 1503736
Change-Id: I3943bddf4a5bcfb266db431e644e1e7100a528b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046372
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228552}
Currently behind the FedCmWithoutWellKnownEnforcement flag we require a
successful well-known fetch and allow the `configURL` not to be part of
the `provider_urls` list.
Given that
1. we ignore the content of the well-known file behind the flag
2. IdPs may not want to deploy well-known file under the root of their
eTLD+1 during early testing
this patch allows fetch failure of the well-known file behind the flag.
Change-Id: Ie80b55704a0a4d62af82ce31fb1551eb6c9f9f5e
Bug: 1458588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054521
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228437}
This adds CHECK()s and a DumpWithoutCrashing() to help isolate cases
where NavigationURLLoaderImpl::OnComplete() may be called with a
successful status and without a prior call to ResponseReceived.
See issue for additional context.
Bug: 1475018
Change-Id: I853affdfbb41ebacdc615c08a369f864ebae3093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041959
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228154}
Currently the BFCache changes are enabled by the same flag that the
locking scheme feature is. This separates them so that we can kill just
the BFCache changes if needed.
Is enabled by default but the changes are only enabled if both the
BFCache flag and the locking scheme flag are enabled. That way by
default the BFCache changes are controlled by the locking scheme flag.
Bug: 1382215, 1241174
Change-Id: Ibe88c3f87f9564eeb3e80e11c1b00487d306277c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5050409
Reviewed-by: Daseul Lee <dslee@chromium.org>
Commit-Queue: Daseul Lee <dslee@chromium.org>
Auto-Submit: Nathan Memmott <memmott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228092}
First test covers case when third party cookie blocking is enabled,
fetch calls to cross-site top level domains should not send cookies. Even when SameSite=None.
Second test covers case when a cross-site redirect occurs which
should send SameSite=None cookies.
Change-Id: If536d35973fcbd79bfe0b004cf36aacae76e9fee
Bug: 1500988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017058
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Auto-Submit: Aaron Selya <selya@google.com>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1228051}
For the moment, the plan is to not support proxy chains in PAC strings.
This CL rewrites a bunch of uses of `{ProxyInfo,ProxyList}.ToPacString`
to use `ToDebugString` (which *can* represent a chain), and removes
TODO's for supporting parsing PAC strings into chains.
Three spots that call ToPacString to return the result of proxy
resolution externally are updated to fail if that result contains a
multi-proxy chain.
Bug: 1491092
Change-Id: I30cdef9d3293312b0c52218f0e0baba639bcb76d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034180
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228039}
Eventually, only a SiteInstanceGroup will be available in this method,
so replace uses of SiteInstance with SiteInstanceGroup.
Test: Update RenderFrameHostManagerTest
Bug: 1261963
Change-Id: Iaccfb2020be40303f6f64c30c7c7b39951c5b3be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5050262
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228030}
The iframe support for adAuctionHeaders is still guarded by the
`kFledgeNegativeTargeting` flag, and this remains the flag that controls
the enablement of the `adAuctionHeaders` attribute on the iframe element.
However, we add a separate `kEnableIFrameAdAuctionHeaders` flag that can
be disabled to remove iframe navigation handling of the ad auction
response headers. When `kEnableIFrameAdAuctionHeaders` is disabled, the `Ad-Auction-Signals` and `Ad-Auction-Additional-Bid` response headers are still cleared for iframes that specify the `adAuctionHeaders` attribute, but this has no user-visible impact because iframe navigation offers no programmatic access to the response headers.
Change-Id: Ic79b902e06bf5c0c1aa8db40bfc9087893050bf3
Bug: 1464874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5049484
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1228007}
