This picks up make_unique changes for target_os = "chromeos" which were
not hit on my previous Mac build.
This is a large-scale change: go/chromium-modernize-make-unique
Bug: 1194272
Change-Id: Ia5c355daecbcb0c81d69db746c97c9f321b22bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826514
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#872701}
It was only deleted at the very end of main when Singletons are reclaimed.
Reclaiming resources then is rather pointless as letting the host process
die has the same effect (OS will close the socket).
The destructor was problematic for
https://chromium-review.googlesource.com/c/chromium/src/+/1283010
as calling PlatformThread::Join() now requires an allowance. An explicit
allowance was added but perhaps just deleting the destructor is better?
Bug: 707362
Change-Id: I41b6479423fff2da64931172acd69c609125104d
Reviewed-on: https://chromium-review.googlesource.com/c/1378683
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623353}
This is a reland of 97120bd710
It was reverted @
https://chromium-review.googlesource.com/c/chromium/src/+/1384626
because it caused failures on an optional bot (crbug.com/916544).
Realizing my initial CL didn't have full coverage : in this reland
I also did a code search for
"ScopedAllow(Blocking|IO)\b (Stop|reset)\(\)"
and migrated everything I found to
ScopedAllowSyncPrimitivesOutsideBlockingScope.
Original change's description:
> [PlatformThread] Join() is a wait, update assertions as such.
>
> This was using ScopedBlockingCall (which was a 1:1 migration from
> AssertIOAllowed()) for legacy reasons.
>
> CL continued from https://codereview.chromium.org/2790473006/
>
> Some of these allowances aren't desired but this CL merely highlights
> existing use cases and as such will not block on fixing them.
>
> TBR=thestig@chromium.org (trivial side-effects chrome/browser/printing/printer_query.cc)
>
> Bug: 707362
> Change-Id: I01a9ae13888ab8602369ddf2d12907388bdc908b
> Reviewed-on: https://chromium-review.googlesource.com/c/1283010
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Julien Tinnes <jln@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617724}
TBR=fdoray@chromium.org (bypassing reviewers from files identical to previous CL)
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
Bug: 707362
Change-Id: Iad5bdb5ba27c7a277dce0072905ddb8c353af881
Reviewed-on: https://chromium-review.googlesource.com/c/1384646
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618109}
This patch does the following:
- Renames render_sandbox_host_linux to sandbox_host_linux
- Moves it from content/browser/renderer_host/ to content/browser/
- Moves sandbox_ipc_linux from content/browser/renderer_host/ to content/browser/
- Updates names in those classes to refer to "sandboxed process" instead of "renderer"
This patch does not affect any behavior.
The motivation for this is the development of out of process rasterization, which
will start rasterizing content on the gpu process. This means that similar access
will be needed from the gpu process as is now required from the renderer process
(specifically font access via FontConfigIPC). Renaming these classes makes it
more clear that there are other processes other than the renderer that use it.
Change-Id: I4d78f3f186f03cc7ad72dab41a7065cc97827180
Reviewed-on: https://chromium-review.googlesource.com/656063
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501084}
