This solves 2 problems:
1. Regenerating MANIFEST.json is failing on ToT (bug 697207)
- Now that MANIFEST.json is in .gitignore, regeneration works
2. Regenerating adds MANIFEST.json to MANIFEST.json (bug 683485)
- MANIFEST.json no longer shows up in MANIFEST.json
BUG=697207,666957,683485
Change-Id: I09987b66027e1f94055888c8ead58e7e40896d62
Reviewed-on: https://chromium-review.googlesource.com/447959
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#454454}
Many pages of testthewebforward.org now redirect, so replace links with
something appropriate from the new documentation.
Since the new documentation consistently says "web-platform-tests"
instead of "Web Platform Tests" and this is what folks like jgraham tend
to write as well, align our own usage with that.
BUG=657117
Review-Url: https://codereview.chromium.org/2696323003
Cr-Commit-Position: refs/heads/master@{#451045}
This CL also adds a section about what kinds of changes
will be upstreamed, and the contributing guidelines for
web-platform-tests.
Review-Url: https://codereview.chromium.org/2681293004
Cr-Commit-Position: refs/heads/master@{#449798}
TestBrowserDialog landed in r440240 and is ready for wider use. Excerpt:
`TestBrowserDialog` provides a way to register an `InProcessBrowserTest`
testing harness with a framework that invokes Chrome browser dialogs in
a consistent way.
The contents are taken from the public doc on chromium.org at https://goo.gl/EFz4r2
BUG=654151
Review-Url: https://codereview.chromium.org/2684513002
Cr-Commit-Position: refs/heads/master@{#449200}
This CL adjusts the work in r434842 to better describe the
differences between pixel tests and render tree tests and when
you want one or the other. It also gets rid of the "DumpRenderTree"
terminology since we don't really use that any more.
R=pwnall@chromium.org, me@gsnedders.com
BUG=665494
Review-Url: https://codereview.chromium.org/2547463003
Cr-Commit-Position: refs/heads/master@{#443810}
Reason for revert:
pwnall@ pointed out that <title> is used in next_default_test_name()
Original issue's description:
> Remove <title> in writing_layout_tests documentation as it
> doesn't appear in test results (thanks to Alan for pointing it out).
>
> Instead we should focus on writing good test descriptions.
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2617083002
> Cr-Commit-Position: refs/heads/master@{#441876}
> Committed: f0c6c6901eTBR=alancutter@chromium.org,thakis@chromium.org,sashab@chromium.org,pwnall@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Review-Url: https://codereview.chromium.org/2624533003
Cr-Commit-Position: refs/heads/master@{#442446}
doesn't appear in test results (thanks to Alan for pointing it out).
Instead we should focus on writing good test descriptions.
BUG=
Review-Url: https://codereview.chromium.org/2617083002
Cr-Commit-Position: refs/heads/master@{#441876}
The main reason for this CL is to change the recommended path for
accessing testharness.js from HTTP tests. The file can be accessed using
both the old path (/js-test-resources/testharness.js) and the new path
(/resources/testharness.js). However, our testharnessresult.js uses the
CSS selector script[src*="/resources/testharness"] to identify
JavaScript tests, causing tests that use the old path to fail without a
text baseline.
The CL also adds an "under construction" unicode character to the
guideline for adding a <meta charset> to every test, as it is still
under discussion.
BUG=
Review-Url: https://codereview.chromium.org/2579953002
Cr-Commit-Position: refs/heads/master@{#439266}
Since almost all Google domains support HTTPS, and it is a good practice to
use HTTPS wherever possible, thus in this patch, I changed most HTTP links
to https whose domains are known to support HTTPS well.
Modifications are generated by running these commands in src/docs directory:
sed -i 's/http:\/\/www.chromium.org/https:\/\/www.chromium.org/g' *.md
sed -i 's/http:\/\/developer.android.com/https:\/\/developer.android.com/g' *.md
sed -i 's/http:\/\/dev.chromium.org/https:\/\/dev.chromium.org/g' *.md
sed -i 's/http:\/\/build.chromium.org/https:\/\/build.chromium.org/g' *.md
sed -i 's/http:\/\/src.chromium.org/https:\/\/src.chromium.org/g' *.md
sed -i 's/http:\/\/crbug.com/https:\/\/crbug.com/g' *.md
sed -i 's/http:\/\/groups.google.com/https:\/\/groups.google.com/g' *.md
sed -i 's/http:\/\/cs.chromium.org/https:\/\/cs.chromium.org/g' *.md
sed -i 's/http:\/\/codereview.chromium.org/https:\/\/codereview.chromium.org/g' *.md
BUG=
Review-Url: https://codereview.chromium.org/2545363002
Cr-Commit-Position: refs/heads/master@{#436501}
This CL converts a massive linked list into a series of sub-headings.
Asides from readability improvements, switching to headings makes it
possible to link to individual guidelines, which may be desirable in
discussions or code reviews.
BUG=
Review-Url: https://codereview.chromium.org/2548693002
Cr-Commit-Position: refs/heads/master@{#435813}
This CL pulls out the content on writing LayoutTests from
layout_tests.md, and does a significant overhaul of it.
BUG=665494
Review-Url: https://codereview.chromium.org/2492733003
Cr-Commit-Position: refs/heads/master@{#434842}
