0
Commit Graph

28944 Commits

Author SHA1 Message Date
Andy Phan
2313f66a40 [OOPIF PDF] Enable PdfOopif in field trial testing config
Add a field trial configuration to enable the PdfOopif feature for tests
by default.

Bug: 324637148
Change-Id: I2b2c0cc5f2b0a2175e8a9507b996158d25897240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444643
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285485}
2024-04-10 23:04:11 +00:00
Noah Rose Ledesma
b4376a3022 Create DynamicCrxDownloaderPriority experiment
The previous experimental setup for the background CRX downloader on Mac
attempted its use for all downloads. Our results indicate that this is
detrimental to the overall health of updates (although, some question
remains about the qualitative effects of an improved user experience due
to less bandwidth contention).

Instead, we would like to propose an experiment in which background
priority is only attempted for larger payloads. Our hypothesis is that
the benefits of background priority and resumability are greater for
large files.

Bug: 40285933
Change-Id: I376834b29ab71e86c96a4da88df125035a070b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444845
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285467}
2024-04-10 22:40:21 +00:00
Marco Georgaklis
4939742b9b Add ondevice quality tests as experimental suite.
Bug: 303679677
Change-Id: Idc3477b31fb385148060ad72e68d83b9e28fd428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444366
Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com>
Reviewed-by: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#1285407}
2024-04-10 21:09:57 +00:00
Calder Kitagawa
6aaf637145 [Tab Switcher] Remove grid-tab-switcher-android-animations from about flags
Remove the grid-tab-switcher-android-animations from about:flags. Don't
delete the flag until Phase 1 of AndroidHub is launched as this greatly
simplifies and de-risks the removal.

Fixed: 330367117
Change-Id: Ie1e04362ecfdcc84d0f3258a8f1bdc1024c18467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445144
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285396}
2024-04-10 20:53:56 +00:00
Kuan Huang
0dd56cb567 Extend the timeout for leveldb_unittests on dbg builds
The Issue320.Test test in leveldb_unittests is time-sensitive and may
not finish within the 45s timeout on some dbg builds.

Instead of adjusting the kTimeoutMultiplier for all dbg builds (as we do
not observe this issue for other test suites and leveldb_unittests is a
third-party unit test suite), this CL specifically increases the timeout
for leveldb_unittests.

Bug: 40282321
Change-Id: I29eaaade7a1913a82421f21a24cb4e725c7038c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5441111
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kuan Huang <kuanhuang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285376}
2024-04-10 20:28:01 +00:00
Xinyi Ji
dd782bc068 [HomeFrequency] Add field trial testing config for increasing the frequency of showing Home on Clank.
Bug: 333569473
Change-Id: I69db2eaa3ffe00e9f011ed3864625dc7b1ca1dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440235
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285329}
2024-04-10 19:41:02 +00:00
chrome-weblayer-builder
eb96bca28e [lacros skew tests] Refresh skew tests for M125
This CL updates the ash version ['125.0.6411.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I204d0ccadcf5a266410ebff451ab0c80c65b0ec7
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5443549
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1285317}
2024-04-10 19:16:40 +00:00
Jacob Stanley
44bedc1bf1 Reland - Adding screenshot verbs to integration - PTB
Bug: 326286372
Change-Id: I612f373b1c7179530a5660ca9741d0e8a986e16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405426
Reviewed-by: Abe Boujane <boujane@google.com>
Commit-Queue: Jacob Stanley <jacobstanley@google.com>
Cr-Commit-Position: refs/heads/main@{#1285311}
2024-04-10 19:10:31 +00:00
Bijan Choobineh
679bd2a9a6 Promote Fake VAAPI VDA Test out of experimental
With the Fake VAAPI VDA test passing on CI builds, we should promote it
out of experimental.

Updates to promote the Fake VAAPI VDA test out of experimental.
Additionally renames the test to |video_decode_accelerator_tests_fake_vaapi|
to allow for additional test variants to be used in the future.

Bug: b:317901106
Test: Ran main.star, sync-pyl-files.py, and generate_buildbot_json.py
Change-Id: I4099f0ba3ff13d379fe6ff3e929e040659d73d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5422228
Reviewed-by: Steve Cho <stevecho@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Bijan Choobineh‎ <bchoobineh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285262}
2024-04-10 17:58:16 +00:00
David Tseng
feda76d755 Fix experiment params for AXTreeCombiner
Originally landed in
https://crrev.com/c/chromium-review.googlesource.com/c/chromium/src/+/

Change-Id: I980a35e2af0ab8e08bffb0d791ef9701cfa33a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437040
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#1285258}
2024-04-10 17:52:51 +00:00
yoshiki iguchi
c627923090 Tast test on Skylab: Reduce max of retries 2 => 1
We have increased the number of retries from 1 to 2 (see b/284825950),
but it looks that it's very rare to catch the flakiness by retries.

And retrying the timeout tests would increases the runtime significantly, and the builders get caused the timeout.

This CL reduces back the number of retries to 1.

Bug: b/333292978
Test: None

Change-Id: I81e6c051711510e766471ab1f4f4880d73b9f06c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439152
Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285234}
2024-04-10 17:17:59 +00:00
adamta
5eac41888f [iOS] Finchable width for NTP containment
Updates HomeModuleMinimumPadding param to use a percentage width instead of a fixed margin (e.g. 92% instead of 24pt).

Internal CL to update feed content width: cl/623234757

Bug: 333398611
Change-Id: I0ddada0e7a72d9058dd8280a756cab28fb7ffc01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440233
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Adam Arcaro <adamta@google.com>
Auto-Submit: Adam Arcaro <adamta@google.com>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/heads/main@{#1285173}
2024-04-10 16:16:30 +00:00
Leszek Swirski
e450c33130 [v8] Add field trial for V8SynchronousSparkplug
Bug: 333670348
Change-Id: Ifabb0437347fabed857c0ee0307b0f3cbd0b3cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5443013
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285098}
2024-04-10 14:07:22 +00:00
Brian Sheedy
8ec79daf7a Enable Dawn Win/Intel x86 exp tester
Enables tests on the Dawn Win/Intel x86 experimental tester since the
x64 tester is currently active.

Bug: 41496254
Change-Id: I2770f51869f529b1aa0e391f02ee45f713931f96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439601
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1285057}
2024-04-10 12:18:38 +00:00
Brian Sheedy
c0f587eb14 Add S24 tester
Adds a Dawn Samsung S24 CI tester and its trybot mirror. The trybot
will share a pool with the S23 trybot for now until we are less
strapped for capacity.

Bug: 333424893
Change-Id: Ifa96e54817c9f61a619d9203d4632dd6b29ae5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437138
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284997}
2024-04-10 09:35:16 +00:00
Brian Sheedy
4e5e64bbaf Add Dawn Win/NVIDIA/x86 exp tester
Adds a Dawn Windows NVIDIA x86 experimental tester to match the Intel
one we already have.

Bug: 297347572
Change-Id: I9befd6ee56488ebb2a559130671d0043e3a7190d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439242
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284985}
2024-04-10 09:22:59 +00:00
Gauthier Ambard
8cca29a28d [iOS] Add a flag to gate tab groups on iPad
This will allow to ship on iPad independently if needed.

Fixed: 333503465
Change-Id: Icda36477b714247738816b2d980d03243f5d730b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5438513
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Quentin Pubert <qpubert@google.com>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Commit-Queue: Quentin Pubert <qpubert@google.com>
Cr-Commit-Position: refs/heads/main@{#1284964}
2024-04-10 08:27:36 +00:00
chrome-weblayer-builder
4f779dd2c7 [lacros skew tests] Refresh skew tests for M125
This CL updates the ash version ['125.0.6410.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I02fc9cae03ce6b303c1e8494b7a0a939f4cd3679
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440241
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1284938}
2024-04-10 07:08:21 +00:00
CJ Huang
5eadb9fcdc launcher: Add segmentation flag for local image search
More flag explanation is on the bug.
Also add an extra fieldtrial testing config that only enable ocr.

Bug: b/332783918
TEST: Verified on DUT.
Change-Id: Icc1398aa67bf323941d72c55b8f3e0428bfa3cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5419457
Reviewed-by: Charles Zhao <charleszhao@chromium.org>
Reviewed-by: Bo Majewski <majewski@chromium.org>
Commit-Queue: CJ Huang <chenjih@google.com>
Cr-Commit-Position: refs/heads/main@{#1284831}
2024-04-10 01:22:57 +00:00
Gregory Guterman
e714842f28 [trooper] Make ash_unittests ci_only
The test more than doubled its runtime Monday 2PM PST and is not causing pending times. E.g. https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-rel/1942600/infra

Bug: b:333572800
Change-Id: Ie9b7c335d9a3d3cefbd31d15604a613b27834865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439895
Commit-Queue: Gregory Guterman <guterman@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Auto-Submit: Gregory Guterman <guterman@google.com>
Cr-Commit-Position: refs/heads/main@{#1284755}
2024-04-09 22:53:39 +00:00
Zhaoyang Li
681c50a863 Add tests of dependency folders to cronet Clang code coverage builder
Bug: b/326598558
Change-Id: I613d483404e8cfd5c74ba69fc7df605cbcae8703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5436442
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Stefano Duo <stefanoduo@google.com>
Reviewed-by: Prakhar Asthana <pasthana@google.com>
Cr-Commit-Position: refs/heads/main@{#1284750}
2024-04-09 22:42:52 +00:00
Peilin Wang
a507f28f92 [AndroidVisibleUrlTruncation] Enable by default
Less jank and less ANRs. No regressions.

Bug: 41492008
Change-Id: Icea6793c1b94c0709e71b80f50da69766c183d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5438419
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Peilin Wang <peilinwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1284725}
2024-04-09 21:54:44 +00:00
Viktor Semeniuk
2f19d1cefe [UPM] Fix a typo in testing/variations/fieldtrial_testing_config.json
Change-Id: I2d7d3bfb2077439a73e62a4ed581013ac982508e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440492
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1284704}
2024-04-09 21:17:59 +00:00
Peter Kvitek
b985bf2cb8 Revert "Add MojoPredictiveAllocation experiment to field trial testing config"
This reverts commit 95eed03c7a.

MojoPredictiveAllocation experiment broke Chrome for Testing tests (https://ci.chromium.org/ui/p/chrome/g/official.cft/builders) and Chrome for Testing build that cannot start unless  --disable-features=MojoPredictiveAllocation is specified.

Original change's description:
> Add MojoPredictiveAllocation experiment to field trial testing config
>
> The feature is already enabled by default on ChromeOS.
>
> Design doc: go/predictive-mojo-allocation
>
> TEST=None
> BUG=40278139
>
> Change-Id: Ie5671ea7d227b4667126c0c005904c187a68cdf4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5427497
> Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
> Commit-Queue: Andrea Orru <andreaorru@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1283704}

Bug: 333477761, 40278139
Change-Id: I45abdc9fb770de3c4f647ab191d71e615887eeac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5438901
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284683}
2024-04-09 20:49:33 +00:00
Benjamin Williams
e5509926d4 [iOS] Bring Docking Promo fieldtrial in sync with Finch changes.
This CL updates the Docking Promo fieldtrial entry to align with the
latest Finch group structure, naming conventions, and parameters. This
ensures compatibility and prevents potential configuration errors with
the test suites.

Change-Id: I3311fc6915779a24e67a939e652dbf1fe41ed94b
Bug: 333559238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440377
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Commit-Position: refs/heads/main@{#1284676}
2024-04-09 20:35:47 +00:00
chrome-weblayer-builder
2c29597539 [lacros skew tests] Refresh skew tests for M125 M123
This CL updates the ash version ['125.0.6409.0', '123.0.6312.112'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I0e1dff388639d42e19d89c1fc258d5521820f905
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440992
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1284660}
2024-04-09 20:08:18 +00:00
Toni Barzic
fbd0ba8771 Update name of rollout feature for recents in continue section
The feature was delayed from 124 to 125, so update the feature name to
avoid finch config unintentionally enabling the  feature on 124.

Change-Id: I539c865aafa57eeb40ea6cafc3a8e97807bfb362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437458
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284659}
2024-04-09 20:07:12 +00:00
Clark DuVall
a2b60d4f89 Optimize XRW origin trial checking flow to avoid UI thread hop
I was looking through some traces of WebView navigation, and saw there
could be quite a long delay starting the request while waiting for the
CheckXrwOriginTrialAsync() call to finish. This call has to post a task
to the UI thread, then post the result back to the IO thread before the
request can start. Posting tasks to the UI thread during navigation can
cause large delays if the UI thread is busy (especially on Android where
the system may be using the main thread).

This change attempts to eliminate the UI thread hop in most cases by
getting the XRW origin trial status as part of a navigation throttle.
Unfortunately, I didn't find a great way to pass this info to
AwProxyingURLLoaderFactory, so it's stored in a map keyed by the unique
navigation ID, which can then be grabbed when needed.

Bug: 332706093
Change-Id: I8bca92d2d3d26c06f9e5ad7f7698dea8683b5daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5427274
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284650}
2024-04-09 19:53:32 +00:00
Etienne Bergeron
27f30e14a2 Add an experiment to run DIPS queries on a foreground sequence
The DIPS database queries are currently executed on a background
sequence.

This CL is adding a feature to allow to make an Arm in the SqlWalMode
study. The goal is to study the impact of background sequence and
WAL mode.

This feature is intended to study performance and won't be shipped to
stable. The study is only targeting Windows since it's the only
platform that do support low IO priority.

Bug: 40256732
Change-Id: Ib65922b481378ceb4fe4bac985da6a7f9d42477d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5392123
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Joshua Hood <jdh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284643}
2024-04-09 19:43:26 +00:00
Yuly Novikov
02b00d91db Target also AP1A.240405.002 for Pixel 6 OS upgrade experiment
Trying a newer OS to see if it improves stability.

Bug: b/319276718
Change-Id: I7351bcc6e6c3a50910a4e7c8673957515984dbbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439477
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284604}
2024-04-09 18:40:47 +00:00
David Maunder
a1ac9c9ebb Add TabStateFlatBuffer to field trial config
Bug: b:307736600
Change-Id: I899f7f4bd116891ce08c6bb5e8790f3ab3045174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5435904
Reviewed-by: Yulun Zeng <yulunz@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284588}
2024-04-09 18:15:20 +00:00
Gyuyoung Kim
3592d0b26a [iOS Blink] Add a components_unittests to the bot
As the unit tests were added to the bot, this CL adds
the components_unittests to the bot as well.

Bug: None
Change-Id: I9b21d5bd99e52e6ea09e52865b726fd81e572278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5427835
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/heads/main@{#1284570}
2024-04-09 17:44:22 +00:00
Gauthier Ambard
0eef7b46fb [iOS] Remove SessionRestorationSessionIDCheck fieldtrial
The feature was enabled by default on crrev.com/c/5435124 but I forgot
to remove the fieldtrial.

Bug: None
Change-Id: I3a34c2244b55ffaf23578a1cf3e62a0571991bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439257
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284556}
2024-04-09 17:25:56 +00:00
Tomasz Jurkiewicz
8bc0b3e1cb Update fieldtrial testing config to avoid to-be-dropped deadline value.
Bug: 318349306
Change-Id: I8fe046b5681ff6a2025be31ea6c34b8467806f01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439556
Auto-Submit: Tomek Jurkiewicz <tju@google.com>
Commit-Queue: Tomek Jurkiewicz <tju@google.com>
Commit-Queue: James Lee <ljjlee@google.com>
Reviewed-by: James Lee <ljjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1284495}
2024-04-09 15:44:18 +00:00
Gauthier Ambard
83471c827a [iOS] Add fieldtrial for TabGroup
Fixed: 331747133
Change-Id: I7967f357c7978f85afa07bf476d6a17729980cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5438216
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284438}
2024-04-09 13:39:03 +00:00
Brian Sheedy
ca8f358c9b Switch Win UHD 630 experimental driver
Switches the Win/Intel UHD 630 experimental builders to target a newer
driver version since the previous one was not actually the most recently
available one.

Bug: 331793619
Change-Id: Id2ab90c3b54a3ddf363c0707a1e6b5851cfe8891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5434635
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284394}
2024-04-09 11:20:27 +00:00
Dmitry Vykochko
be84d52831 Implement the content of the cross domain filling confirmation popup.
Mocks: go/chrome-mullhet#slide=id.g2743136ff94_0_36
Implementation (Linux):
https://screenshot.googleplex.com/6oryxFvmoYNtRXo

Bug: 330303918
Change-Id: I0566ddc12f4c997b072205274ae2dcfd3682c127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393185
Commit-Queue: Dmitry Vykochko <vykochko@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284393}
2024-04-09 11:16:26 +00:00
Michael Ershov
fc1f016409 Kcer: Implement PKCS#12 migration
Implement the migration of the PKCS#12 keys+certs from the NSS
public slot into the private slot provided by Chaps.
The migration will be started after the import of PKCS#12 files
into Chaps is validated. At the moment the migration is disabled
and it’s controlled by the CopyClientKeysCertsToChaps feature flag.

Test: KcerPkcs12MigratorTest
Bug: b/264392421
Change-Id: Iccb817b25be5660738446a7a8b172090f2b6e120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5424951
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Michael Ershov <miersh@google.com>
Reviewed-by: Oleksandr Sarapulov <olsa@google.com>
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284371}
2024-04-09 09:59:17 +00:00
Asami Doi
adca735f60 [ios] Update fieldtrial_testing_config.json for SnapshotInSwift
Experiment for the SnapshotInSwift feature will start by
https://critique.corp.google.com/cl/621161159

Bug: 40943236
Change-Id: Ied55844bf0a67413c19b57434e4fcc4cc392d2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5419123
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Auto-Submit: Asami Doi <asamidoi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284344}
2024-04-09 08:33:22 +00:00
chrome-weblayer-builder
575ab50b65 [lacros skew tests] Refresh skew tests for M125
This CL updates the ash version ['125.0.6408.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I847d60110b9ff91fed4af2a6ff465a7e27bd3a3b
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437860
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1284319}
2024-04-09 07:21:38 +00:00
yoshiki iguchi
ac51f46e4e Add UIDetection variable to MaybeMissingVars on public builders
So the tests using UIDetector won't run on the public builders.

Note that the variable has been added to the tests in CL:5409963.

Bug: b/332415943
Test: None
Change-Id: Ie54d217e1437cd50376bcf43b7a7f6e3cecfd6a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420513
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284268}
2024-04-09 03:48:36 +00:00
yoshiki iguchi
63713219be Public skylab: Use 'hash' method as sharding of tast testing
Previously only one shard took 10x+ time than other shards. This CL
enables the hash method to balance the test execution time among shards.

`shardmethod` argument is added by crrev.com/c/5379569.

Bug: b/328131664
Bug: b/333292978
Test: None
Change-Id: Ib61648a835dea8467ff4749e0f28ec69a9b83479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5392847
Reviewed-by: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284239}
2024-04-09 01:39:03 +00:00
chrome-weblayer-builder
cbbc3bf870 [lacros skew tests] Refresh skew tests for M125
This CL updates the ash version ['125.0.6398.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I2bd11ea16e5034d6049913d903f889c3aa6902d5
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437353
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1284233}
2024-04-09 01:19:38 +00:00
Alexander Tekle
188f5a1f1b Add benefits flags to Fieldtrial Testing Config
Bug: 333446993
Change-Id: I540a7a5658dcaf3abbf2d14e316ba8995ed1a86a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5434476
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Commit-Queue: Alexander Tekle <alexandertekle@google.com>
Commit-Queue: Vinny Persky <vinnypersky@google.com>
Auto-Submit: Alexander Tekle <alexandertekle@google.com>
Cr-Commit-Position: refs/heads/main@{#1284196}
2024-04-09 00:23:20 +00:00
Olivier Li Shing Tat-Dupuis
546006a799 Fully disable ConditionallySkipGpuChannelFlush on ChromeOS
Investigation is needed to understand some test failures:
https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5630126236631040

Fully disabling will stop failures while leaving the code in to allow for lower
channel experimentation and investigation.

Bug: 1500339
Change-Id: Ie727333d282b3b670b2f5e4a777223101f71c8c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5435673
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Olivier Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284167}
2024-04-08 23:39:53 +00:00
Min Qin
84d99dbd6a Set Default OpenDownloadDialog value to true
This is approved for launch

Change-Id: Ic34fdb76e58ef5368f01dc2dd44e005ebd637baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5431348
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284142}
2024-04-08 22:44:33 +00:00
An Sung
cbb43ebeb9 [Blink] Increase shard count for blink_wpt_tests in mac-osxbeta-rel to 18
Bug: 324108421
Change-Id: I21e251c43ca3b32f576bc5f9567eb76804df9ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5415635
Commit-Queue: An Sung <ansung@google.com>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Wanda Mora <morawand@google.com>
Cr-Commit-Position: refs/heads/main@{#1284069}
2024-04-08 20:15:35 +00:00
chrome-weblayer-builder
84e5f84eb7 [lacros skew tests] Refresh skew tests for M125
This CL updates the ash version ['125.0.6407.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I9b34931b8cb70f94b9c176aa0c5875ed4ea3c30e
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5435617
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1284017}
2024-04-08 19:09:29 +00:00
vikas soni
38b699d500 [UseGpuSchedulerDfs] Enable experiment in field trial.
Enable experiment UseGpuSchedulerDfs in field trial for both android and
webview.

Bug: 1511310
Change-Id: If625ee4bab53037d93414288c78a3799a128e527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5435899
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Auto-Submit: vikas soni <vikassoni@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284000}
2024-04-08 19:00:07 +00:00
Chris Lu
2677369454 [ios] Add MagicStackRemoveGradientView fieldtrial test config
Change-Id: I7f4096c650197de65e9d84380ebd7ed52958ab68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5430985
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283998}
2024-04-08 18:58:58 +00:00