This replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes
where a local script is able to detect its insertion place (~Foo() is
public => insert before this line).
This is incomplete as not all classes have a public ~Foo() declared, so
not all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.
IWYU cleanup is left as a separate pass that is easier when these macros
go away.
Bug: 1010217
Change-Id: Iea478401b7580682c7b9f195f7af9cbbdb6ce315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3167292
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923194}
Knowing the URL is very helpful not only for diagnosing renderer
crashes, but also for handling browser crashes, and DwoCs (e.g.
ones issued for renderer kills). This CL introduces a call
to ContentClient::SetActiveURL in 4 places in the browser process:
- RenderViewHostImpl::OnMessageReceived
- RenderFrameProxyHost::OnMessageReceived
- RenderFrameHostImpl::OnMessageReceived
- RenderFrameHostImpl::DidCommitProvisionalLoad
Bug: 797968, 770239
Change-Id: I78481d0fcb40e7c0548eb5ee3bd1ff00c7703592
Reviewed-on: https://chromium-review.googlesource.com/846109
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527031}