0
Commit Graph

11 Commits

Author SHA1 Message Date
qyearsley@chromium.org
7e75117e3e Return 0 for confidence when there's only one good or bad rev.
BUG=

Review URL: https://codereview.chromium.org/463743002

Cr-Commit-Position: refs/heads/master@{#288982}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288982 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-12 15:31:06 +00:00
qyearsley@chromium.org
330aa74f0d Refactor bisect-perf-regression_test.py and add smoke test.
BUG=

Review URL: https://codereview.chromium.org/434043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287737 0039d316-1c4b-4281-b951-d872f2087c98
2014-08-06 09:06:24 +00:00
qyearsley@chromium.org
098647c54b Fix many style issues in bisect-perf-regression.py.
BUG=

Review URL: https://codereview.chromium.org/429143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286573 0039d316-1c4b-4281-b951-d872f2087c98
2014-07-30 19:07:43 +00:00
qyearsley@chromium.org
5dcad27e9a Use Welch's t-test to calculate confidence scores in the bisect script.
BUG=383864

Review URL: https://codereview.chromium.org/413393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286438 0039d316-1c4b-4281-b951-d872f2087c98
2014-07-30 08:00:42 +00:00
qyearsley@chromium.org
1d26b0edc4 Move statistical functions to another module.
BUG=

Review URL: https://codereview.chromium.org/417013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286137 0039d316-1c4b-4281-b951-d872f2087c98
2014-07-29 09:14:42 +00:00
prasadv@chromium.org
469ac37447 Check for chromium revision instead of dependency module revision.
GetCompatibleCommand checks chromium revision to set appropriate browser type.
While processing 3rd party repositories by bisect, it was trying to compare dependency module
revision instead of chromium revision.

BUG=388411
NOTRY=true

Review URL: https://codereview.chromium.org/414893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285103 0039d316-1c4b-4281-b951-d872f2087c98
2014-07-24 01:14:33 +00:00
prasadv@chromium.org
deee216530 Support browser as android-chromium-testshell and android-chrome-shell based on revision.
Prior to crrev.com/274857 *only* android-chromium-testshell. Then until crrev.com/276628 *both* (android-chromium-testshell and
android-chrome-shell) work. After that rev 276628 *only* android-chrome-shell works. bisect-perf-reggresion.py script should
handle these cases and set appropriate browser type based on revision.

BUG=385324
NOTRY=true

Review URL: https://codereview.chromium.org/399463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283308 0039d316-1c4b-4281-b951-d872f2087c98
2014-07-16 00:40:06 +00:00
prasadv@chromium.org
ab99d3ba2e Fix bisect script to match a results with {mean, stddev} format.
Make bisects to look for the pattern RESULT lines with  {mean, stddev} format while parsing results log.

BUG=366431
NOTRY=true

Review URL: https://codereview.chromium.org/288843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270788 0039d316-1c4b-4281-b951-d872f2087c98
2014-05-15 19:56:12 +00:00
simonhatch@chromium.org
1a7ff50d89 Parse DEPS file manually if execfile fails. Some DEPS files pull in a bunch of libraries, so execfile fails. If it does, we'll manually parse out revisions from the vars section.
NOTRY=true
BUG=366392


Bisect could not reproduce a change in the not/valid metric.

Confidence in Bisection Results: 0%

To reproduce locally:
$ echo android-chrome

Tested commits:
         Depot                                        Commit SHA                                    Mean       Std. Error       State    
     android-chrome                    0000000000000000000000000000000000000000                     1.00         +-0.00                  
        chromium                       0000000000000000000000000000000000000000                     0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265919        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265917        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265912        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265904        0.00         +-0.00                  
     android-chrome                    0000000000000000000000000000000000000000                     0.00         +-0.00                  

Average build time : 0:00:00
Average test time  : 0:00:00

WARNINGS:
  !!! Due to build errors, regression range could not be narrowed down to a single commit.
  !!! Tests were only set to run once. This may be insufficient to get meaningful results.
  !!! Confidence is 0%. Try bisecting again on another platform, with increased repeat_count or on a sub-metric that shows the regression more clearly.

Review URL: https://codereview.chromium.org/256593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266322 0039d316-1c4b-4281-b951-d872f2087c98
2014-04-26 02:20:28 +00:00
qyearsley@chromium.org
3cd7e70ea1 Change "percentage change" function and add comments/test for it.
Goal: To make it clearer how percentage change is calculated, and make it so that it's the same as how the dashboard calculates it.

BUG=

Review URL: https://codereview.chromium.org/241273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265791 0039d316-1c4b-4281-b951-d872f2087c98
2014-04-24 00:31:45 +00:00
qyearsley@chromium.org
28733cea82 Refactor CalculateConfidence and add unit test.
This version is a little bit different from the last; main differences:

 - I saw that the "CalculateBounds" was returning the minimum and maximum of the means of the input list, so I thought it would be easier to understand if this was done by mapping CalculateMean and then directly making a tuple with min/max.
 - Since CalculateTruncatedMean(xs, 0) is just the mean, and this is used in several place, I extracted out a convenience function CalculateMean.
 - CalculateConfidence doesn't refer to self, so I thought it was reasonable to move it up to be a top-level function with the other stats functions.

BUG=

Review URL: https://codereview.chromium.org/220113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262924 0039d316-1c4b-4281-b951-d872f2087c98
2014-04-10 05:10:16 +00:00