0
Commit Graph

3 Commits

Author SHA1 Message Date
Lei Zhang
0960d56494 Fix bad refactoring in PluginList::GetPluginInfoArray().
In r630011, a LoadPlugins() call should have been removed, since it was
guarded by a conditional that was always false. Instead, it is always
being called.

Change-Id: I4dfb2294f0ee66aed9ed94a046176eb6b57b38dd
Reviewed-on: https://chromium-review.googlesource.com/c/1464927
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631420}
2019-02-12 22:49:23 +00:00
Lei Zhang
c923379ed9 Remove a check that is always true in PluginList::GetPluginInfoArray().
It only has one non-test caller, and that caller always passes in a
valid |use_stale| parameter. Update the unit tests to pass in the
parameter as well. After that, change it from an out parameter to the
return value.

Change-Id: Ia7862d74363b052c18ed9f37d4253c5f515f1d5f
Reviewed-on: https://chromium-review.googlesource.com/c/1456987
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630011}
2019-02-07 18:13:08 +00:00
Lei Zhang
d8c5318dc8 Move PluginList to content/browser/.
It does not need to live in content/common/. Run git cl format along the
way.

Change-Id: I04e063334b7df182f0c5fa4eb235e61f49e77beb
Reviewed-on: https://chromium-review.googlesource.com/c/1456947
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629754}
2019-02-06 22:24:39 +00:00