Without quotes gn args fails with:
ERROR at build arg file (use "gn args <out_dir>" to edit):5:12: Invalid token.
goma_dir = /path/to/goma-client
^
I have no idea what this is.
Change-Id: I1cfe58a07fe8c4272aca89e1dee10584c7645635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101394
Auto-Submit: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750006}
No change to logic, only docs.
This adds a pros/cons list for emulators. This moves the note about the
Play Store into a con below, and replaces it with a table of contents at
the top.
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I023924b88f53ac0b6b3c96e16743c12cfcf839f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098994
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749773}
The linker tests don't run on bots (and likely not locally either) and
do not support the latest library loading patterns. This is the first
step to remove them, as they add non-trivial complexity in the codebase.
More specifically, this removes the build rules and the test APK.
Bug: 1059707
Change-Id: I12102d59116ad1f0a152d3110cf3346471c8f390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093606
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749238}
This involves
* Moving non-MD-related code out of Initialize into LinearAnimation
* Moving other Initialize() code into the constructor
* Removing all Initialize() calls
* Replacing other static methods with instance methods
* Adding GetInstance() calls to callers to get the instance
* Converting the TestAPI class to a scoping object
* Other assorted #include removal etc. in the process
Bug: 940773
Change-Id: Ieb8d44eabae63b014a90ff452010eb4c067e5e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090877
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748895}
This CL stops rewriting chrome-devtools: scheme URLs into
devtools: scheme URLs, by tweaking
//components/url_formatter/url_fixer.cc.
This CL also stops special-casing chrome-devtools: scheme
in //components/policy/core/browser/url_util.cc.
The CL then also proceeds to remove all other mentions of the
chrome-devtools: scheme from the codebase. This part of the
change was initially done with the following command:
$ git grep -l 'chrome-devtools[^-]' | xargs -n 1 \
sed -i -e 's/chrome-devtools/devtools/g'
and then manually reviewing and tweaking the edited files.
Bug: 1055524
Change-Id: Ie9d51332e4c28fd6201f4b5590bbba5c79fc09d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088335
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748242}
The guides for investigating the representative perf tests are added:
- Common failures listed
- accessing the traces and benchmark logs are documented
Bug: none
Change-Id: Ic087fb97ee362e04d839414f1396165f111b9934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087220
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747732}
Running an ASan build of Clank requires a one-time device set up
instructions. However, the 1-line instruction in asan.md is improperly
wrapped to 2 separate lines. This CL remedies the above.
Bug: 978698
Change-Id: Ie0f5b403cb20a3f4e7bcbe18d56ec339f15f9059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082327
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746806}
CPEs are the way that MITRE tracks different projects and versions, and
that's the input required by Vomit, Google's automated vulnerability
notification system. At present Vomit is unable to identify the versions
for these components and is therefore reporting the wrong CVEs in crbugs.
Adding this CPEPrefix line will enable Vomit to notify for any
vulnerabilities affecting these versions.
This is the first such change to README.chromium files. If successful,
CPEPrefix lines will be added to many others too.
Bug: 895969
Change-Id: Ibec5adf9069cdc20e40fb13658e7b056e938f5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053847
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Auto-Submit: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746237}
There have been occasional instances of marshals responding to security
emails and removing the list outright, rather than bcc'ing. This makes
it hard to distinguish between emails that have had responses and those
that have not.
Change-Id: I55feedc97450149a5dac69b6dd79c29eb5b44d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079331
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745178}
The traffic annotation auditor tool allowed for switching between two
different extractor backends while usage was being migrated to a python
script extractor. This CL removes existing usage of clang-tool as well
as the switching infra, as well as the clang-tool extractor itself.
Bug: 1046869
Change-Id: I4dd77598cc3b7c80723e59951681cef28103670d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070818
Commit-Queue: Ehsan Kia <ehsankia@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745109}
This CL responds to Mark Goldstein's comments on commit_checklist.md.
Mark Goldstein was my instructor for the Technical Writing One course,
and as a follow-up exercise, he asked us to include him as a reviewer
on a documentation-related change. This doc will also form the basis
of my upcoming talk "Life of a CL" at Chrome University, so I want to
make sure it's in tip-top form!
Bug: None
Change-Id: I0aeefcbb149929969f15d375f55ea2d2d44684f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045051
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743465}
The new source.chromium.org site accepts the link as-is, but for
cs.chromium.org, I get a "Request to Git backend failed." error. After
this CL, the link should work for both code search versions.
Change-Id: I576d88b3a6eb8bcbf7fcd26fa5ef6d3bba40d31b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067478
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743304}
This wipes out obsolete references to Service Manager in service-related
documentation and replaces it with simpler docs reflecting the new
service model.
Bug: None
Change-Id: Iab5662bcc48b34954a9003532cd407058e470282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063773
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742677}
1) Clarify that it's not always necessary to reproduce a bug yourself.
2) Move the paragraph about components with their own triage processes
to the beginning of the triage instruction.
3) Slightly change wording in V8 and Skia guidance. Mention Skia fuzzing
bugs explicitly.
Change-Id: Ide0bc021675d4f9ea648af3c777470b4cce9975e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048106
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740366}
