chromium/src
0
Fork 0
Code Activity
1,548,969 Commits 3 Branches 23,233 Tags
3c74eb466268b9b19b2f925b38d870625dcf62e5
Commit Graph

3 Commits

Author SHA1 Message Date
Fred Shih
3ef5fa7865 Fix incorrect boolean array size calculation 
The '+' operator has higher precedent than the '>>' operator:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_precedence#table

This means that the computation:

headerSize + (value.length + 7) >> 3

will end up dividing headerSize by 8 as well. This results in an error:

"RangeError: Offset is outside the bounds of the DataView"

Change-Id: Id9b176d6495581851cab80f863da974bab3a4e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5332847
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Fred Shih <ffred@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267225}
 2024-02-29 21:46:40 +00:00
Avi Drissman
4e1b7bc33d Update copyright headers in content/ 
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
No-Presubmit: true
Bug: 1098010
Change-Id: I8c0f009d16350271f07d8e5e561085822cc9dd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895935
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047456}
 2022-09-15 14:03:50 +00:00
danakj
89f4708621 Move content/shell/$process/web_test to content/web_test/$process 
This separates the web test code out of content/shell/. While it is
built into content_shell, it is only part of it when --run-web-tests
is used, and is not conceptually part of the content shell library
being embedded in other shell apps like extensions's shell, ash shell,
or the views example app.

R=avi@chromium.org, mmoss@chromium.org, sky@chromium.org
TBR=

Bug: 866140
Change-Id: I1787d7bbd3be27d1232ab6ddab64db2b5df1d3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389045
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803914}
 2020-09-02 17:53:43 +00:00