Unlike LSC which is meant for work that spans dozens of CLs, this new change is meant for one-off CLs. It's similar to google3's global approvals mechanism.
base, build, blink, content and url were chosen as an initial set because they are used in many top level directories and are frequently changing.
Also add "set noparent" to top level directories to avoid inadvertent +1s from src/OWNERS bypass owners reviews sometimes.
Change-Id: Iaa397a5e09174139af21fee34dca390de132e216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688805
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857391}
If your project DEPS's in buildtools and needs libunwind, edit your
toplevel DEPS file to have something like
'libunwind_revision': 'a2cc4f8c554dedcb0c64cac5511b19c43f1f3d32',
in its `vars =` section, and an entry similar to
'src/buildtools/third_party/libunwind/trunk':
Var('chromium_git') +
'/external/github.com/llvm/llvm-project/libunwind.git' + '@' +
Var('libunwind_revision'),
in its `deps =` section. Add libunwind_revision to your autoroller
that rolls //build and //tools/clang etc.
Since libunwind is only used in Fuchsia builds and for chrome/android's
sampling profiler, it's possible that no projects other than chromium
actually need this.
This makes it possible to set up an autoroller for libunwind for chromium.
Bug: 1177288
Change-Id: I7a59f11b015acc98b65f4b87a9277a5a3028328d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713283
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#856453}
Following crrev.com/c/2676528, (virtually) all remaining uses of the
deprecated methods have been removed. This cl removes one last
base::Bind use and removes the remaining media/ files from the presubmit
exemption list. This will help prevent reintroduction of the deprecated
methods.
Bug: 1170511
Change-Id: Id1f8e41066759641d5d5a960b41460bd07b4f74b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2673239
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#852495}
Replace input_api.owners_db with input_api.owners_client will
simplify migration from Depot Tools owners to Gerrit native
code-owners.
Owners client is an abstraction that provides a common
interface to both Depot Tools and Gerrit owners backends.
Added `set noparent` to SECURITY_OWNERS.
This makes it easy to list security reviewers, as it is the
same as listing OWNERS of that file.
Change-Id: I6196177e61b1ce19f23cc2645a482b29b92c081d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679444
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851861}
This is a reland of 3f7ffdc226
It should be virtual_depended_on_files instead of affected_files
Original change's description:
> PRESUBMIT.py: Use owners client to check DEPS includes owners.
>
> Replace input_api.owners_db with input_api.owners_client,
> a common interface to check owners using Depot Tools owners
> implementation and Gerrit Code-Owners plugin.
>
> Change-Id: I670c0294ad614537491c492fc53437ecd0305128
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679151
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#851321}
Change-Id: If12d7215648ca3cb7d7d24e3665f182b99596d58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2682755
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851855}
Updates two base::Bind( calls under chrome/browser/web_applications to
match the previously-updated callback type from their underlying
functions.
This is a code health cleanup with no anticipated behavior change.
Fixed: 1170969
Change-Id: I6b160913b12c8d4813cd17bfabc46bd437625960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2659979
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849271}
Adds exceptions for directories/files found to contain base::Bind,
Callback, or Closure methods.
Additionally, fixes a handful of files that only had a single trivial
instance needing to be cleaned up.
Bug: 714018
Change-Id: I7a7ac5f07b7c62fff680ac6daa9e52ce490f24b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2660396
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849214}
Updates base::Bind calls in PluginInfoHostImpl and PluginPrefs to match
the corresponding "Repeating" type of the underlying function being
called.
Updates PluginINfoHostImplUnittest to take a QuitClosure as a
OnceClosure to match it's usage.
Fixed: 1170970
Change-Id: Ifa23e0150587c74b16deb0141c394fb051fdd975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657771
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849210}
The methods that are being called have already been converted from
base::Callback to {Once,Repeating}, this cleans up a few base::Bind
calls to match the underlying function argument explicitly so that the
base::Bind alias can be deprecated.
This is a code health change which should not introduce any behavior
change.
Fixed: 1170952
Change-Id: Id0c023d6adb816464dfd6bf3a6c839e22a47cacb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657846
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849205}
base::Bind and base::Callback are being deprecated in favor of the
{Once,Repeating} versions, and the same goes for base::CallbackList;
this adds a new PRESUBMIT check to ban new usages of base::CallbackList,
while still allowing existing usages.
base::ClosureList is similar in that it should be disallowed, but it was
not used anywhere. As such, the alias has been removed and replaced with
a comment that it should not be re-added.
Bug: 1113007
Change-Id: I1cc60d9b60321c232352d2eb1c1f9df7a48c8c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657022
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848795}
Converts base::Bind/Callback/Closure to {Once,Repeating} variants as
appropriate (with a preference for Once where possible). Most changes
were simple updates to match the underlying types with a couple of
exceptions:
cloud_policy_browsertest.cc:
* on_policy_updated_ was Reset immediately after being run, which is
the behavior of a OnceClosure and thus was converted
extension_policy_browsertest.cc/policy_network_browsertest.cc:
* QuitClosure's should *really* only be OnceClosures; however, since
CreateProfileAsync takes a RepeatingCallback, we cannot bind the
QuitClosure to a RepeatingCallback. (CreateProfileAsync likely
should not be a RepeatingCallback and this is tracked by
Issue 1171905). In order to avoid making additional work in the
future, a pointer to the RunLoop is instead bound to the callback,
which mimics a pattern used by other tests that call
CreateProfileAsync.
This is a code health change with no expected behavior changes.
Fixed: 1170955
Change-Id: I6a4d4337a26542af04d34b2051d03408d3d10c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657796
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848787}
Converts instances of Base::Bind/Closure/Callback to Once/Repeating.
Most QuitClosures were converted to base::OnceClosure, to match their
usage, while most "callback_for_testing_"s were made into Repeating,
since that matched their usage. The Unsubscribe callback was only
expected to be run once by the test that set it, and thus was
converted to a OnceClosure.
This is a code health cleanup and should have no behavior change.
Fixed: 1170968
Change-Id: I44d5f9ea4827116806f604723e2478559931c36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2654427
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848674}
base::Bind/Closure has been deprecated in favor of explicit variations:
{Once,Repeating}. This change converts one instance of a QuitClosure
being stored to a OnceClosure, and otherwise updates the base::Bind
calls to match the underlying function signatures, which were
previously updated/typedefed to RepeatingCallbacks.
This is a code health change and should not have any behavior change.
Fixed: 1170947
Change-Id: I8baa17c626e6c8cf523b49abe08f19611ea8e3df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657751
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848671}
Converts base::Closure and subsequent base::Bind calls in
chrome/browser/service_process to the corresponding "Once" versions.
All Closures in this class were either passed to a method already taking
a OnceClosure, or Reset immediately after being Run, which matches the
usage pattern of a OnceCallback/Closure.
Fixed: 1170978
Change-Id: I73d2ca88b2040b4e241c0cff7ade09dcbcbf04a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2654314
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848162}
This is a code-health cleanup with no anticipated behavior change.
Updates two tests under chrome/browser/translate to use BindRepeating
rather than Bind; the corresponding Callback type had previously been
aliased to a RepeatingCallback.
Bug: 1007635
Change-Id: I40a70099e2c30bfc54d03a77fc7c282ca647dbfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2650429
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847811}
Removes usages of base::Bind(, base::Callback, base::Closure and changes
them to the appropriate {Once,Repeating} version. This is a code health
cleanup, and should have no behavior change.
third_party_blocking_browsertest.cc:
* registry_key_.StartWatching converted to BindOnce to match function
* QuitClosure member changed to OnceClosure, which matches its usage.
Of note, the stored closure was already being moved/run
jumplist.cc:
* Pref change callback is explicitly registered as BindRepeating, per
the underlying type.
Remaining files converted stored QuitClosure's to OnceClosure's, which
matched their usage (as they were already being moved/run).
Fixed: 1170967
Change-Id: I4e87fdb85930e9fa6bf9f759a5fc6907351b6a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2653716
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847762}
Removes and converts banned base::Bind and base::Closure calls in
chrome/browser/renderer_context_menu. This is a code health cleanup that
should have no functional change. The following changes were made:
render_view_context_menu_browsertest:
* QuitClosure's converted to OnceClosure to reflect that they are only
called once.
* Two binds updated to once/repeating per the already updated function
arg.
render_view_context_menu:
* Two binds converted to BindRepeating per the underlying function
being updated explicitly to repeating.
Fixed: 1170971
Change-Id: Id4e8f13361f37a456c114282f171cb29be48bdb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2651453
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847737}
The following lingering changes were found and fixed:
AudioStreamHandler: CancellableClosure was used repeatedly, so converted
to CancellableRepeatingClosure
ContentSecurityPolicyUnittest: Part of a test data struct, which was
only called once, converted to OnceCallback/BindOnce
preferences/README.md: Referenced function and mechanism have been
removed (even from components/prefs where referenced class had moved)
so removed the outdated paragraph.
Bug: 714018
Change-Id: Ibc4d0f6d6de7535dc18d15473dee7311b6b48428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2650626
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847379}
Removes directories from the list which have no results when running:
`git grep -P -r 'base::(Bind\(|(Cancelable)?(Callback[<:]|Closure))'`
Additionally, fixes one directory where the only hit was in a comment.
Bug: 714018
Change-Id: I55a5f0e699b9138b875e98a0f0d1aff2d85b1f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648766
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847010}
